From: Tao Cui <cui.tao@linux.dev>
To: Tejun Heo <tj@kernel.org>
Cc: cui.tao@linux.dev, void@manifault.com, arighi@nvidia.com,
changwoo@igalia.com, liwanwu@kylinos.cn, usama.arif@linux.dev,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, Tao Cui <cuitao@kylinos.cn>
Subject: Re: [PATCH 0/6] sched_ext: fix kfunc, sub-sched, flatcg and idle-mask issues
Date: Fri, 13 Nov 2026 12:07:19 +0800 [thread overview]
Message-ID: <2df669c7-d321-4cf3-8e04-250ad527a28c@linux.dev> (raw)
In-Reply-To: <eb63bdf20dd6e2f09b0e7c81bc905878@kernel.org>
Hello Tejun,
在 2026/11/13 01:34, Tejun Heo 写道:
> Hello, Tao.
>
> On Thu, Nov 12, 2026 at 09:09:28PM +0800, Tao Cui wrote:
>> This series fixes six issues in the sched_ext core, the scx_flatcg
>> example scheduler and the CID helpers. The core.c fixes travel as a
>> separate series.
>
> There's one actual fix here (1/6) and the rest are rather vacuous. Can you
> please think more through each change and whether it makes sense in the
> context of actual usage? If these are coming from LLM scans, please don't
> just follow the details that they surface. It'd help to actually use the
> thing that you're producing patches for and think through the implications
> of the changes that you're suggesting.
>
Thanks for the feedback.
I did use LLM as a development aid. Some of the patches started with
issues it identified.
I see your point. I focused too much on the issues and not enough on
whether the fixes made sense in the context of actual sched_ext
usage. I'll keep that in mind for future submissions.
Thanks,
Tao
> Thanks.
>
> --
> tejun
prev parent reply other threads:[~2026-11-13 4:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 13:09 Tao Cui
2026-11-12 13:09 ` [PATCH 1/6] sched_ext: Reject DSQ iterator kfuncs in tracing programs Tao Cui
2026-11-12 17:34 ` Tejun Heo
2026-11-12 13:09 ` [PATCH 2/6] sched_ext: Make scx_bpf_cid_node() a benign lookup for invalid cids Tao Cui
2026-11-12 17:34 ` Tejun Heo
2026-11-12 13:09 ` [PATCH 3/6] sched_ext: Return -EBUSY from a pre-init scx_bpf_sub_caps() read Tao Cui
2026-11-12 17:34 ` Tejun Heo
2026-11-12 13:09 ` [PATCH 4/6] sched_ext: Reject cid_online/cid_offline on sub-schedulers Tao Cui
2026-11-12 17:34 ` Tejun Heo
2026-11-12 13:09 ` [PATCH 5/6] tools/sched_ext: scx_flatcg: Don't strand a cgroup on the ENQ_RACE path Tao Cui
2026-11-12 17:34 ` Tejun Heo
2026-11-12 13:09 ` [PATCH 6/6] sched_ext: Clear the built-in idle masks on CPU hotplug transitions Tao Cui
2026-11-12 17:34 ` Tejun Heo
2026-11-12 17:34 ` [PATCH 0/6] sched_ext: fix kfunc, sub-sched, flatcg and idle-mask issues Tejun Heo
2026-11-13 4:07 ` Tao Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df669c7-d321-4cf3-8e04-250ad527a28c@linux.dev \
--to=cui.tao@linux.dev \
--cc=arighi@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=changwoo@igalia.com \
--cc=cuitao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=liwanwu@kylinos.cn \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=usama.arif@linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®