From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754063AbcHZSCn (ORCPT ); Fri, 26 Aug 2016 14:02:43 -0400 Received: from mout.web.de ([217.72.192.78]:64697 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbcHZSCl (ORCPT ); Fri, 26 Aug 2016 14:02:41 -0400 Subject: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() To: linux-ia64@vger.kernel.org, Fenghua Yu , Tony Luck References: <349bbfb4-bada-628e-2981-ca2a315299fc@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <2e046b40-1c8e-717f-68b1-534c3125724c@users.sourceforge.net> Date: Fri, 26 Aug 2016 20:02:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <349bbfb4-bada-628e-2981-ca2a315299fc@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:o5qV68fNyg6+iYdThdjqDCZaFWE/neUX0x0+sJtrCSjHu0Mtjur Aw2KOo7LTVqw9qgsB+l9KGjwqmr2Yz1xUr72YBbzQfTDdmtM7ImMPHC2eOQSHj742ZzJZvJ GBiDmoKbuDSSIxpOrH3/3lBlKV1dTNaYqIA4R5DCq8uYNZCnXzsWOrmOfRo7K/fW7i/W4Xx M0wkPAciJiQ6NbrT8P40w== X-UI-Out-Filterresults: notjunk:1;V01:K0:OjxJgxc8V9o=:+/bkdw0sR86Y3Rvgu+BKy/ aW3IDu/kUx/g4c9Hgt9PxEV4Nd0L48EW8VsX6F4gv6iPOunB8z3C2IsHGC2WtNT8V/ygHGX61 Dqgb2E/hdi9rtz72HS22AkscigdjLixAFVE4CoVgqZWidUNzJrtDGhU0kkEzYiUxhkVTn2K9D F0qRE+tRVrPWZu6NXHklN1TLCzzT1dhGAsVGMFAJgK4Qg4vq3WmRb4AUzc/gV2zWtaLdt6aUj V/dPEaEaHIb4Uc+YmkcVDPF50INy5eo+FlkTX/V5IyQPZZuylupaEBG+1ZOnzXXommP1pCJpJ ZPD1F26AJUGEIx2i9NVRvoQ5+ZDrN+292eS3Cr7CSa7uyVguq5qXpldWQfLuvh800KUDqcc4V AwZAq6Es9NfTnHVIRrWvbwiqFjOaXYKrouX1yNBzbchFPOEuN7Kq7m9H3jONzxvhAaDKkvowb e6CLJmlvOPGeoEgFtu+raLl9uRFjnrqLlaRxefv0xVRXIa5F8fxNHNSuB35OUdAN+xZRGVc0+ HoJDSBwzhTQrNo14ttXgLxa28hTtiaGCacyrbVshUaQCt6SaF9BUaHezCHDGeQymFWE35i5Lb RPTmYy0WR6SoJMrgo+NEYK5G9rCrPUg1FIEamPXOj/YSWNhdz5ktZHUVwMvhA2hLPkjE0bNht KB9r4pGFXkJbO6huNjyJ/woPr84S60UanvjEWLvi1cDHU3bRLSK8wbifsksvOCJyOODDAmyFK sO7XM7kW9BMf2T35Pg/KufjPxcDfumRYDgFpvwXIZ7cyFnFqBe4C44MPQJqw1l0DQNrEU5a8t EPZeZuU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 26 Aug 2016 18:32:53 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of data structures by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/ia64/sn/kernel/irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ia64/sn/kernel/irq.c b/arch/ia64/sn/kernel/irq.c index 85d0951..c7f9eea 100644 --- a/arch/ia64/sn/kernel/irq.c +++ b/arch/ia64/sn/kernel/irq.c @@ -474,12 +474,12 @@ void __init sn_irq_lh_init(void) { int i; - sn_irq_lh = kmalloc(sizeof(struct list_head *) * NR_IRQS, GFP_KERNEL); + sn_irq_lh = kmalloc_array(NR_IRQS, sizeof(*sn_irq_lh), GFP_KERNEL); if (!sn_irq_lh) panic("SN PCI INIT: Failed to allocate memory for PCI init\n"); for (i = 0; i < NR_IRQS; i++) { - sn_irq_lh[i] = kmalloc(sizeof(struct list_head), GFP_KERNEL); + sn_irq_lh[i] = kmalloc(*sn_irq_lh[i], GFP_KERNEL); if (!sn_irq_lh[i]) panic("SN PCI INIT: Failed IRQ memory allocation\n"); -- 2.9.3