mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Arav Verma <svav2021@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] platform/x86: intel: wmi: Use sysfs_emit in sbl-fw-update
Date: Thu, 17 Sep 2026 17:50:59 +0300 (EEST)	[thread overview]
Message-ID: <2e047550-6272-9b5a-60b3-0f2c1742b555@linux.intel.com> (raw)
In-Reply-To: <20260822174038.619473-1-svav2021@gmail.com>

On Sat, 22 Aug 2026, svav2021@gmail.com wrote:

> From: Arav Verma <svav2021@gmail.com>
> 
> Modernize firmware_update_request_show by replacing legacy
> sprintf() call with sysfs_emit. When altering string,
> corrected format specified from %d to %u to match u32 type of
> target variable.

Hi,

Unfortunately, we cannot accept changes that are not signed off. Please 
see Documentation/process/submitting-patches.rst for more information what 
you certify when signing off a patch and how to do that.

-- 
 i.

> ---
> v3: Resending as v3 due to git send-email formatting error, no code changes have been made.
> 
>  drivers/platform/x86/intel/wmi/sbl-fw-update.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/wmi/sbl-fw-update.c b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> index 62c9c7f1842ba..cfef71f4f3284 100644
> --- a/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> +++ b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
> @@ -61,7 +61,7 @@ static ssize_t firmware_update_request_show(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	return sprintf(buf, "%d\n", val);
> +	return sysfs_emit(buf, "%u\n", val);
>  }
>  
>  static ssize_t firmware_update_request_store(struct device *dev,
> 

-- 
 i.


      parent reply	other threads:[~2026-09-17 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-22 17:40 svav2021
2026-08-22 17:40 ` [PATCH v3 2/2] platform/x86: intel: wmi: Remove redundant callbacks svav2021
2026-09-17 14:50 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e047550-6272-9b5a-60b3-0f2c1742b555@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=svav2021@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®