From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BC3C76195 for ; Thu, 23 Mar 2023 10:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230291AbjCWKFF (ORCPT ); Thu, 23 Mar 2023 06:05:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjCWKFD (ORCPT ); Thu, 23 Mar 2023 06:05:03 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A33E192; Thu, 23 Mar 2023 03:05:01 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 5E6AC5FD46; Thu, 23 Mar 2023 13:04:58 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1679565898; bh=4I6K2VuM3Da1cSkhjgvGdlFDwk1yFiCLVbvH4zYxFMI=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; b=cXqZeHxwQKL7MWm8AKzKeg7/EgsGf33Phk4U5AQxeHyAk6yCh1vDw8YgBVRfnEXVT EPsWLCRlSQYLbfjELBDFN11GRS/G8rGipqLO2OmPIdmKPRrAiNeD/kAdo5q7vamxN2 07RapRFHxJgIVwjqVaUt2wa1UYGHD/lUZNx52ZDY6KMXk16Ym9u9/BQ2BJKmmlkQQI DE0wofm95yvQ2DxtojbW5NYW9LrrRME52CMf9Rfg4c8nt46ep5/l3VHf9wa6DE4BuD 7WX5efTJQZ3cA0qPlciLt9Nrn3WKmPQ6kkEscAwCSkSaUbGCrGmtFGqYYMPm0ggKYJ 8N86WVQcvSqFw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Thu, 23 Mar 2023 13:04:52 +0300 (MSK) Message-ID: <2e06387d-036b-dde2-5ddc-734c65a2f50d@sberdevices.ru> Date: Thu, 23 Mar 2023 13:01:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC PATCH v5 0/2] allocate multiple skbuffs on tx Content-Language: en-US To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bobby Eshleman CC: , , , , , References: From: Arseniy Krasnov In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/23 05:59:00 #20997558 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Stefano, thanks for review! Since both patches are R-b, i can wait for a few days, then send this as 'net-next'? Thanks, Arseniy On 22.03.2023 21:34, Arseniy Krasnov wrote: > This adds small optimization for tx path: instead of allocating single > skbuff on every call to transport, allocate multiple skbuff's until > credit space allows, thus trying to send as much as possible data without > return to af_vsock.c. > > Also this patchset includes second patch which adds check and return from > 'virtio_transport_get_credit()' and 'virtio_transport_put_credit()' when > these functions are called with 0 argument. This is needed, because zero > argument makes both functions to behave as no-effect, but both of them > always tries to acquire spinlock. Moreover, first patch always calls > function 'virtio_transport_put_credit()' with zero argument in case of > successful packet transmission. > > Link to v1: > https://lore.kernel.org/netdev/2c52aa26-8181-d37a-bccd-a86bd3cbc6e1@sberdevices.ru/ > Link to v2: > https://lore.kernel.org/netdev/ea5725eb-6cb5-cf15-2938-34e335a442fa@sberdevices.ru/ > Link to v3: > https://lore.kernel.org/netdev/f33ef593-982e-2b3f-0986-6d537a3aaf08@sberdevices.ru/ > Link to v4: > https://lore.kernel.org/netdev/0e0c1421-7cdc-2582-b120-cad6f42824bb@sberdevices.ru/ > > Changelog: > v1 -> v2: > - If sent something, return number of bytes sent (even in > case of error). Return error only if failed to sent first > skbuff. > > v2 -> v3: > - Handle case when transport callback returns unexpected value which > is not equal to 'skb->len'. Break loop. > - Don't check for zero value of 'rest_len' before calling > 'virtio_transport_put_credit()'. Decided to add this check directly > to 'virtio_transport_put_credit()' in separate patch. > > v3 -> v4: > - Use WARN_ONCE() to handle case when transport callback returns > unexpected value. > - Remove useless 'ret = -EFAULT;' assignment for case above. > > v4 -> v5: > - Remove extra 'ret' initialization. > - Remove empty extra line before 'if (ret < 0)'. > - Add R-b tag for the first patch. > - Add second patch, thus creating patchset of 2 patches. > > Arseniy Krasnov (2): > virtio/vsock: allocate multiple skbuffs on tx > virtio/vsock: check argument to avoid no effect call > > net/vmw_vsock/virtio_transport_common.c | 63 +++++++++++++++++++------ > 1 file changed, 49 insertions(+), 14 deletions(-) >