From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83946C04A6A for ; Mon, 7 Aug 2023 18:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbjHGSlE (ORCPT ); Mon, 7 Aug 2023 14:41:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjHGSlB (ORCPT ); Mon, 7 Aug 2023 14:41:01 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81AE4171A; Mon, 7 Aug 2023 11:40:58 -0700 (PDT) Received: from [192.168.0.192] (unknown [194.146.248.75]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: andrzej.p) by madras.collabora.co.uk (Postfix) with ESMTPSA id 81B4766071D9; Mon, 7 Aug 2023 19:40:56 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691433656; bh=Pdhld7CSHiyTrZxNklyN3L0UxgiiUZ9zkGHGlQbYfWU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Icq4D61GPjqlFEyPKVmpZHJ3Dc9/3UwVqv3Rt9aclFwd6nHB6/Xcby5jdjejtsMP8 lHgjJ69YWWjzzgB9jxBQkFHUnrHkJyBJSU69OhhvFnPQA1c3ZdzYOSexgcsRMK1E26 SqZ6XGNWeWnd/9lALY5ffGGyeGRyta7bKXpSy49XWg1GC1hVEY/sJspIrs2NdtapdU Mx5GoPne5iwxLgszbV8Ogwr5ai13Q75jI1pLlwkIDr3iBQI9y5sPurPdDFjndiFTKf ZRZe6Au0lKYkZH/SEY4I1+JxV6FS9TS1BmXibVwHnCDV/naKGigPlYP5aJ88ZdDbTO yZ3YWaotvP1Lg== Message-ID: <2e08b843-d1f3-a095-8e5c-cc4997773040@collabora.com> Date: Mon, 7 Aug 2023 20:40:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/5] docs: uapi: media: Add a layout diagram for MT2110T Content-Language: en-US To: Nicolas Dufresne , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno Cc: kernel@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230804192737.19016-1-nicolas.dufresne@collabora.com> <20230804192737.19016-5-nicolas.dufresne@collabora.com> From: Andrzej Pietrasiewicz In-Reply-To: <20230804192737.19016-5-nicolas.dufresne@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, W dniu 4.08.2023 o 21:27, Nicolas Dufresne pisze: > This diagram details the partitioning done in each tiles. If I understand correctly there are 8 partitions in the diagram, each partition consists of 80 bytes, 64 bytes containing MSB data and 16 bytes containing LSB data. The diagram says "MSB 8 bits" and "LSB 2 bits" which might be confusing because it suggests that the length of the partitions is maybe 8 bits plus 2 bits. IOW it is not clear that the numbers (8 and 2) refer to the kind of contents rather than lengths. Maybe to the left of the diagram should be some arrows/curly braces describing the partitions' lengths? Regards, Andrzej > > Signed-off-by: Nicolas Dufresne > --- > .../userspace-api/media/v4l/mt2110t.svg | 268 ++++++++++++++++++ > 1 file changed, 268 insertions(+) > create mode 100644 Documentation/userspace-api/media/v4l/mt2110t.svg > > diff --git a/Documentation/userspace-api/media/v4l/mt2110t.svg b/Documentation/userspace-api/media/v4l/mt2110t.svg > new file mode 100644 > index 000000000000..d4fc223f5fde > --- /dev/null > +++ b/Documentation/userspace-api/media/v4l/mt2110t.svg > @@ -0,0 +1,268 @@ > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + MSB 8 bits > + > + > + > + > + > + > + LSB 2 bits > + > + > + > + > + > + > + MSB 8 bits > + > + > + > + > + > + > + LSB 2 bits > + > + > + > + > + > + > + MSB 8 bits > + > + > + > + > + > + > + LSB 2 bits > + > + > + > + > + > + > + MSB 8 bits > + > + > + > + > + > + > + LSB 2 bits > + > + > + > + > + > + > + MSB 8 bits > + > + > + > + > + > + > + LSB 2 bits > + > + > + > + > + > + > + MSB 8 bits > + > + > + > + > + > + > + LSB 2 bits > + > + > + > + > + > + > + MSB 8 bits > + > + > + > + > + > + > + LSB 2 bits > + > + > + > + > + > + > + MSB 8 bits > + > + > + > + > + > + > + LSB 2 bits > + > + > + > + > + > + > + > + > + > + > + 16 px > + > + > + > + > + > + > + > + > + > + > + 32 px > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > +