From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756755AbcFGWU2 (ORCPT ); Tue, 7 Jun 2016 18:20:28 -0400 Received: from resqmta-po-04v.sys.comcast.net ([96.114.154.163]:51307 "EHLO resqmta-po-04v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756723AbcFGWUZ (ORCPT ); Tue, 7 Jun 2016 18:20:25 -0400 X-Greylist: delayed 489 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Jun 2016 18:20:25 EDT Subject: Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ? To: Alexandre Belloni , David Binderman References: <20160607153027.GK3363@piout.net> Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, dcb314@hotmail.com From: Joshua Kinard Message-ID: <2e0e2f2f-6e19-6727-fbc2-0712e32da18e@gentoo.org> Date: Tue, 7 Jun 2016 18:12:04 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160607153027.GK3363@piout.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2016 11:30, Alexandre Belloni wrote: > Hi, > > On 07/06/2016 at 16:18:31 +0100, David Binderman wrote : >> Hello there, >> [snip] >> Duplicate. Also in the same file: >> >> [drivers/rtc/rtc-ds1685.c:265]: (style) Variable 'ctrlb' is assigned a >> value that is never used. This looks like it can be removed. I believe it's a relic of before I added the handling of either BCD or Binary modes for the SGI Octane's RTC interface. >> [drivers/rtc/rtc-ds1685.c:812]: (style) Variable 'ctrlc' is assigned a >> value that is never used. This needs to be wrapped in #ifdef CONFIG_RTC_DS1685_PROC_REGS, as the value of 'ctrlc' is displayed in /proc/drivers/rtc if that kconfig option is selected on supported systems. -- Joshua Kinard Gentoo/MIPS kumba@gentoo.org 6144R/F5C6C943 2015-04-27 177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943 "The past tempts us, the present confuses us, the future frightens us. And our lives slip away, moment by moment, lost in that vast, terrible in-between." --Emperor Turhan, Centauri Republic