From: Malcom Blaney <malcolm.blaney@maptek.com.au>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org
Subject: Re: is_device_dma_capable
Date: Wed, 17 Jun 2009 10:40:10 +0930 [thread overview]
Message-ID: <2e115de50906161810j48db4b42if2dae7c48df4116b@mail.gmail.com> (raw)
In-Reply-To: <20090616175549Y.fujita.tomonori@lab.ntt.co.jp>
Thanks Fujita, your patch worked a treat!
2009/6/16 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>:
> On Tue, 16 Jun 2009 17:53:03 +0930
> Malcom Blaney <malcolm.blaney@maptek.com.au> wrote:
>
>> Hi Fujita,
>>
>> 2009/6/16 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>:
>> > You use X86_32, right?
>>
>> I have CONFIG_X86_32=y in my config file.
>>
>> >
>> > In 2.6.25, X86_32 and X86_64 had the own dma_alloc_coherent
>> > implementations; X86_32 accepted a device having dma_mask that is not
>> > initialized however X86_64 didn't, I think.
>> >
>> > When we merged them, we chose to prohibit a device having dma_mask
>> > that is not initialized. I'm not sure the DMA docs say this but IMO
>> > it's good to require drivers to set up dma_mask (and
>> > coherent_dma_mask) properly if the drivers want DMA.
>> >
>>
>> If you could point me in the direction of how to set these values
>> correctly, I would appreciate it.
>
> You hit the problem that a device that parport_pc_probe_port creates
> but doesn't set up the dma_mask properly, right (I'm not familiar with
> the driver at all so I might misunderstand something)?
>
> If so, I guess that the following patch works (only compile tested).
>
>
> diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
> index 151bf5b..1af57b7 100644
> --- a/drivers/parport/parport_pc.c
> +++ b/drivers/parport/parport_pc.c
> @@ -2271,6 +2271,9 @@ struct parport *parport_pc_probe_port(unsigned long int base,
> if (IS_ERR(pdev))
> return NULL;
> dev = &pdev->dev;
> +
> + dev->coherent_dma_mask = DMA_BIT_MASK(24);
> + dev->dma_mask = &dev->coherent_dma_mask;
> }
>
> ops = kmalloc(sizeof(struct parport_operations), GFP_KERNEL);
>
prev parent reply other threads:[~2009-06-17 1:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 7:24 is_device_dma_capable Malcom Blaney
2009-06-16 8:12 ` is_device_dma_capable FUJITA Tomonori
2009-06-16 8:23 ` is_device_dma_capable Malcom Blaney
2009-06-16 8:55 ` is_device_dma_capable FUJITA Tomonori
2009-06-17 1:10 ` Malcom Blaney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e115de50906161810j48db4b42if2dae7c48df4116b@mail.gmail.com \
--to=malcolm.blaney@maptek.com.au \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®