mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
	Stephen Boyd <sboyd@kernel.org>, Niklas Cassel <nks@flawful.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Robert Marko <robimarko@gmail.com>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	Marijn Suijten <marijn.suijten@somainline.org>
Subject: Re: [PATCH v11 6/9] soc: qcom: cpr: Use u64 for frequency
Date: Tue, 27 Jun 2023 14:15:09 -0600	[thread overview]
Message-ID: <2e11a98a-3e44-7164-84cc-7bbd519b608a@quicinc.com> (raw)
In-Reply-To: <20230217-topic-cpr3h-v11-6-ba22b4daa5d6@linaro.org>

On 6/27/2023 12:30 PM, Konrad Dybcio wrote:
> 32 bits is not enough for over-2.changeGHz frequencies. Move all variables
> that operate on Hz to u64 to avoid overflows.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>


I get the following warning when building this -

   CC      drivers/soc/qcom/cpr-common.o
In file included from ./include/linux/device.h:15:0,
                  from ./include/linux/platform_device.h:13,
                  from ./include/linux/of_device.h:5,
                  from drivers/soc/qcom/cpr.c:18:
drivers/soc/qcom/cpr.c: In function ‘cpr_corner_init’:
drivers/soc/qcom/cpr.c:870:21: warning: format ‘%lu’ expects argument of 
type ‘long unsigned int’, but argument 4 has type ‘u64 {aka long long 
unsigned int}’ [-Wformat=]
    dev_dbg(drv->dev, "freq: %lu level: %u fuse level: %u\n",
                      ^
./include/linux/dev_printk.h:129:27: note: in definition of macro 
‘dev_printk’
    _dev_printk(level, dev, fmt, ##__VA_ARGS__);  \
                            ^~~
./include/linux/dev_printk.h:163:31: note: in expansion of macro ‘dev_fmt’
    dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
                                ^~~~~~~
drivers/soc/qcom/cpr.c:870:3: note: in expansion of macro ‘dev_dbg’
    dev_dbg(drv->dev, "freq: %lu level: %u fuse level: %u\n",
    ^~~~~~~

  reply	other threads:[~2023-06-27 20:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 18:30 [PATCH v11 0/9] Add support for Core Power Reduction v3, v4 and Hardened Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 1/9] MAINTAINERS: Add entry for Qualcomm CPRv3/v4/Hardened driver Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 2/9] dt-bindings: opp: v2-qcom-level: Document CPR3 open/closed loop volt adjustment Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 3/9] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3 driver Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 4/9] soc: qcom: cpr: Move common functions to new file Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 5/9] soc: qcom: cpr-common: Add support for flat fuse adjustment Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 6/9] soc: qcom: cpr: Use u64 for frequency Konrad Dybcio
2023-06-27 20:15   ` Jeffrey Hugo [this message]
2023-06-27 20:51     ` Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 7/9] soc: qcom: cpr-common: Add threads support Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 8/9] soc: qcom: Add support for Core Power Reduction v3, v4 and Hardened Konrad Dybcio
2023-06-27 18:30 ` [PATCH v11 9/9] arm64: dts: qcom: msm8998: Configure CPRh Konrad Dybcio
2023-06-27 21:36 ` [PATCH v11 0/9] Add support for Core Power Reduction v3, v4 and Hardened Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e11a98a-3e44-7164-84cc-7bbd519b608a@quicinc.com \
    --to=quic_jhugo@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=nks@flawful.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=robimarko@gmail.com \
    --cc=sboyd@kernel.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®