From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C592331E84B for ; Fri, 17 Jul 2026 13:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784296186; cv=none; b=EY+574qSQUsc31upsdMtg990v1pccAAck50NscKVobsMJcTmbtjHbAVjq/NCP7Vb8Cu3k8yRc1lXY/+0nMJt5cDKKQSyCASOoJ5T2pEqy4PdBpaJZg0pmPUGvIPFjHlYC96JlFQhY+7XeMZA6gtiyrETGxb7cgklXOOidbLZ8rE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784296186; c=relaxed/simple; bh=OvEADiHpOBB3dVuihCnRCwwHQrm/Ih1b4OA5KmQrVd0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cF1ZNy2nYWypHuOjMDl+nofxr0pTClSE4PQyCaqpFhSjMh4F/gDnALnd/b6lYZISQYxf8Wf/0rIiCn00OGU1mlzcmrgqzFyf/EuvWJmskYJCzd0eDTZiTrn4aFFFORSJnkFkowqbgQGQdErI7HlCgaCg2mQNTiqYTejQVMej4b4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=jAsVjlnU; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="jAsVjlnU" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HCg3v32049367; Fri, 17 Jul 2026 13:49:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=G4C4Sk c+SEnb8rb8rQyOm4B4rEiSnVWgmBM7gzvlELk=; b=jAsVjlnUi4Qmhz/JoEZaXS AKC1ZJZjsIpkDRAGgm5kqRfmsddh5xcfJ5f63hIi3Dmh5mks0GlxIqyo/M8hTHCL 5TjWnAXztSbidQBUVBK+J22AGPD7bivpw+diPO4ambTDEvbxTObCWHKaC2M/Yzpu vo6S3d8eyO5p/9A4RjCkjpqkFg5OiICXCUR/woj6joD6FSGXwnUgH6M9dNLpxUK+ 5MIdY32OVV/Kgf8VUvWNSrYnln+8vrLylOuXz4cvIMFcmg3T4i6uA3WPdavYnPil b0/vQnMVArM6KR1Mt3SXQrUbDIBfw/0nmSvjcEdpI3Ww/NNi3CjiNPRkRZ962LHw == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fbepxxqqs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Jul 2026 13:49:09 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66HDYZ5p002016; Fri, 17 Jul 2026 13:49:08 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4fc2uyhm6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Jul 2026 13:49:08 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66HDn6kS46596378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Jul 2026 13:49:06 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AEEC42004F; Fri, 17 Jul 2026 13:49:06 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 12AC020063; Fri, 17 Jul 2026 13:49:04 +0000 (GMT) Received: from [9.39.31.65] (unknown [9.39.31.65]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 17 Jul 2026 13:49:03 +0000 (GMT) Message-ID: <2e141369-1b6f-425e-8648-a8969ee5d1b3@linux.ibm.com> Date: Fri, 17 Jul 2026 19:19:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] sched: dynamic: Simplify irqentry_exit_cond_resched() To: Mark Rutland , "Christophe Leroy (CS GROUP)" Cc: linux-kernel@vger.kernel.org, frederic@kernel.org, jstultz@google.com, juri.lelli@redhat.com, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, vincent.guittot@linaro.org, vschneid@redhat.com References: <20260703133358.698078-1-mark.rutland@arm.com> <20260703133358.698078-5-mark.rutland@arm.com> <4905f97c-9154-4794-b337-808f6eec2949@linux.ibm.com> From: Shrikanth Hegde Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: flDykTJLsLg8r-tfy6RLIyKJLtWoUDQP X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDEzOSBTYWx0ZWRfXyDQ8ozbnnQqY 3ngLps/hdT3aWVTw7JB1grAM1mj9tGaJjILzIem/OK09iuyYjcAqoGH1jhqSvV7IKMm2beiiB7o gMM4lIl2R/wN4UIQEPRFcaW7x76f9WU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDEzOSBTYWx0ZWRfXyT+HhRI836R9 boWH6/LvQKv1WixcW49aPIsWuCi990uRIb2pCoq2uQ0tm5V8iw8NgWYr3YO4zIUmY1kXfce/moA sj+G3so4KPs2CKkOymXP/wcKD496l4Sfl6AnVYK2VDDBsgGRP03pwqUihAtkmE4Kqb8qnoSpfmO XtfH1tSkZLTLLsy1lBqVysXg7uZTV1AT6SZ5rpq62Cyq/wL3IFtWqUtXIrWzjNah/Bd3+L5tkld eFkZYF7fus6H1bBs0HHiMwkbupyRqgycQpHHWkvYP4dyC8AEm+PPVAO2aeC+Tw7/Pqn0RX1c6K+ tGstRlY8Xrfvi6DnXNwycPhkA14ZPraAvU7VwqsxS7ggyDjJtkNPYdNiGdKr1Gob53qKQpNwXII TvEu46265CghbX6qAiHFYA5zhnEqMI87nb9AM7VV3dNY4c7Usjx5MNdsaNfm8wQkp6ITDD4DwD1 Do8Y/OeoQdKXxgp7CIQ== X-Authority-Analysis: v=2.4 cv=XbS5Co55 c=1 sm=1 tr=0 ts=6a5a32d5 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VwQbUJbxAAAA:8 a=7CQSdrXTAAAA:8 a=20KFwNOVAAAA:8 a=1XWaLZrsAAAA:8 a=JfrnYn6hAAAA:8 a=KKAkSRfTAAAA:8 a=VnNF1IyMAAAA:8 a=Gdm6AL5Tl5LgmcgaYAEA:9 a=QEXdDO2ut3YA:10 a=a-qgeE7W1pNrGK8U0ZQC:22 a=1CNFftbPRP8L7MoqJWF3:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: ZMu-X_2mZdL44mu4JiQxRLJNDLaJHfG8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_03,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170139 Hi Mark, On 7/17/26 4:35 PM, Mark Rutland wrote: > On Mon, Jul 06, 2026 at 10:12:29AM +0530, Shrikanth Hegde wrote: >> +cc Christophe. >> >> On 7/3/26 7:03 PM, Mark Rutland wrote: >>> PREEMPT_DYNAMIC is now limited to the FULL and LAZY preemption models. >>> In either model, irqentry_exit_cond_resched() is always called and never >>> disabled. >>> >>> Remove the unnecessary code for this when PREEMPT_DYNAMIC is selected. >>> >>> Signed-off-by: Mark Rutland >>> Cc: Frederic Weisbecker >>> Cc: Ingo Molnar >>> Cc: John Stultz >>> Cc: Juri Lelli >>> Cc: Peter Zijlstra >>> Cc: Thomas Gleixner >>> Cc: Valentin Schneider >>> Cc: Vincent Guittot >>> --- >>> arch/powerpc/include/asm/preempt.h | 7 ------- >>> include/linux/irq-entry-common.h | 17 +---------------- >>> kernel/entry/common.c | 17 ++--------------- >>> kernel/sched/core.c | 7 ------- >>> 4 files changed, 3 insertions(+), 45 deletions(-) >>> >>> diff --git a/arch/powerpc/include/asm/preempt.h b/arch/powerpc/include/asm/preempt.h >>> index 000e2b9681f30..79fc1f9df88d9 100644 >>> --- a/arch/powerpc/include/asm/preempt.h >>> +++ b/arch/powerpc/include/asm/preempt.h >>> @@ -4,13 +4,6 @@ >>> #include >>> -#if defined(CONFIG_PREEMPT_DYNAMIC) >>> -#include >>> -DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched); >>> -#define need_irq_preemption() \ >>> - (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) >>> -#else >>> #define need_irq_preemption() (IS_ENABLED(CONFIG_PREEMPTION)) >>> -#endif >> >> JFYI, >> Christophe had sent this patch, I am sure you guys will sort out the >> conflicts. (I don't see it merged yet, but likely might) >> >> https://lore.kernel.org/all/2bf10a0afffefb6aca44bf2f864cc17471a80e31.1781870889.git.chleroy@kernel.org/ > > Thanks for the heads-up! > > Sorry, I'd skipped Ccing all the arch folk as I hadn't expected anyone > was likely to be doing similar in the arch code right now. I'll make > sure you're both Cc'd for any subsequent versions. > > It looks like the only difference for powerpc is that I leave > need_irq_preemption() lying around. Christophe, if you're happy with > this series, I could pick a patch from you to remove that (e.g. take > your patch and apply it to the end of this series, reduced to removing > need_irq_preemption()). > > Any preference? I will go by Christophe preference. But i see it is in powerpc fixes branch and part of pull request. https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=fixes So, you might have to rebase on top of it. > > [...] > >> Change per se, looks good to me. >> >> Reviewed-by: Shrikanth Hegde > > Thanks! > > Mark.