From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B7F4364054 for ; Fri, 6 Mar 2026 11:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772797991; cv=none; b=CwGCkRFmoGW/QxQ3lFWAMq0t5ClbhfOE5WIB3WGtTb3SEp9JOo6xWz14krrfkQH2O5GmcS6io9F6pqGA8OrBbRyXCdzBDgthgl8gRuhxSnOPubLexAXk0bvGFm/d2uc2901KYEhVRFWAm6mCou/PWzQqTv+/m1Cff1Xcv5uTG9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772797991; c=relaxed/simple; bh=Z+OP+Frmk8PTztxIx1kU+lYtsUJc/JdSqfG/6fvWrME=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=Uh5K8BwlNMH30guBIvTxJNxscx1fxJb4B0o1+2BNiNJrGj6zcg+dQUXois4uMglpZe2tQ3t30z1E/UAjjqx506CEPbu9gBNpUVf+bYWS3jNRrYoQnX38UfHbti2FUhfGKydJd34bSootkqwINgwhQQiRvHhI70vSdEou9YP1jGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=pjbKKorn; arc=none smtp.client-ip=212.227.17.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="pjbKKorn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1772797962; x=1773402762; i=markus.elfring@web.de; bh=/1rX7wd4BEjJDAzBHRrSKQB6zvMSiWQfDT9upLx84Zg=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=pjbKKorn1q9+sWUpeZEAUc8PRNVjTTaX2Tof4mzp9naU1NRcGIWkhCu923JNm/iC i8KwkPc34KP38xG/MwOZPvH7GD2b/FQQq9RZpzpfkzIoWKJdyBtQWG/M+x4yIulOW tss5u3SW1bZUFvKKZg8dGOFnbOaq6N1hFzXa0lpcupCpWQy083q8qo1MlUkzkRdUq Y5XV9eviPMTvNkC5yZOJBEj7mUi1G0QLErDpkVfsNcP3B46trStpksTaajsKJQpgn xsjaNjTMUo0m4TsaILpDub7cIlIU8gOVxBPOSfXfH8swhtPSW46dlcewV4a4aGVw2 K8cssBDsjjBuozC2Bw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from client.hidden.invalid by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MQPZj-1wKhaK3mqH-00HpMJ; Fri, 06 Mar 2026 12:52:41 +0100 Message-ID: <2e15b2b8-7dd4-4e63-b9a9-a664323ebb36@web.de> Date: Fri, 6 Mar 2026 12:52:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Chen Ni , op-tee@lists.trustedfirmware.org, Jens Wiklander Cc: LKML , Sumit Garg , Ulf Hansson References: <20260305083312.1040969-1-nichen@iscas.ac.cn> Subject: Re: [PATCH] optee: Check return value of tee_shm_get_va() Content-Language: en-GB, de-DE From: Markus Elfring In-Reply-To: <20260305083312.1040969-1-nichen@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:jobSu1iFwiWMgxxI2JHBJxugvNyluddBYEQxqOB5kRBnZqToVV5 gNvvAD7i0cSH4WAyTa9Wt6vnYsMJGOfQ9VAY1sOGVTzpJr4Oqb43AjmGbbqUgaeEA0yPxaU f64Zfr70oYHBTrBMviLAmKtZOGLHPWdFn8FqMSm3R2epJD/5bMG6uo3MOAqhc5qRWF3WeJu 3IQe6rj5Rn9dMRLb5y3/Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:yMAo+D9lRKc=;JYB9EILXWKlZBylAOrekmXtQmoJ 254fC+6LrSxiuyl85UbJcO6Cpvjpo+7Qxm5guhX7p5Q6Pdcjl0rScBoqHJOqFbiUJfIEPXUDy PJNNk/lUNcA9UcMmIA9QcQemzkpQPbk5gbf8AJ3hPHKBrVP8D9JGPy+KT9ceL5lOOy03GF3Vp cLCVx0tNlyDSXf+bHdShqNZvpI26yB1eSqCkM2FpEDPt4xnoFqWzfYxYe1wjKZx/AlD8Kfe4i Np3BdR/tEfjjpOGX1nz779jOKxKYNG97tg3LmC4iJJQuth/tUiTi3ievwih4vkkKJsKW1Baco aN9/+tr1GsOoEWGTnxwpFkWsjmE8ooggsPFuKrpufzl8j8cY3cFhHczE4ZghzXK/FnhCHQML9 /xFzuSMyHvM591vJz582pecXhKzUopd/uI1MJdk1p1slBaRsjuF+1nM0SOfaYaJB48IR+LFms H3J/yuvPBxWXMY85GTjZ0OhgUT7alcHyVcbSlSWPpBBGUtoSNKAs9+NYssAIr42cgnaMoy8ru eHVsbB1d0dAEhUWZb5+/ISgMOEWSSWdGXE06vMHek5BZzuW7EUoIrUbpMherzXhG2oFJzxAwi /nMSt0u8CQOxIer0GslJHN0spP2Hi2tdwNQFYr+pQo4wZQIArKHnRv/f+viTi0MaqGEKnGapU DEcGEl6nyYyomuQysVxpCC7Yx/LxJ05njFMnFZ0ARN1mZS/v/1Rdg6Ye21ihVBnamnow6J08u XxJT3PqUddG+RLazkP4DDZeRsZU3doI1FrySAzxUmXgjPB1nWjD0fIDGGUX8ei4Gkhmil1KyX lOio8rn9ky+Z2XvDKrqiSWgA1dKLF/MgYfF/rP89Y4oyzVDuLo3kW7vg+v6qAZwLoncNR4d2D 8tsCJO5TTR+FIfdcvTnHiTRp+6BKUXZKzY5bhv/C373Ej3xA7YGp1/hoXiijjXwWj4dwKRqN3 I/1lomisFWBbPfSrdkLL0DD2C6L7lC/bu1k3M/Iuj4AlOR8qvcgbi8soaY+2lnDjTTX7Fk6V8 z2RQlBhwvdrcPQe/X6KcnBIagfQ3Ad0/Pd6oxhMHsGEJ9Q/3cZSIZQeihyJ83nQbj4/Wv2i8P FWnQS2T+IgvzF5W94t7k9+qIXjxGOI7gxYKkW6unXl8V96oLWG2Oq9xFs7blMnE6QZMtxosaD DuSk2JL/3QrgdyiwY8f2ZYur5Us4FfJ12/jliRno3fZJv/qL3JhCoevjW8BmlLi6brCMMb/yD JS6uwBro4tCZBHa6sMZ85+ZGIDAONfqgg6pz6P8RNfJNyYZk0WS80kXNbGpk8WD71N0AFp13x 2wQQxLfhnUY/CQ/9rfi6RAG67+cPkiufVBZRpatLVAmdSflq0Opc/0yEq8X7fWHGVaPMKUbtb LAUkeHAoUGg12FKjZp22Ty1cKtm0Qj/+kpKMEhvZ1FPNxgZiK8cEqlCpqC116RO+e39e2wdCJ 454bzafwZX49R4cuMzNRuhanZbYOdWluNafokcSLPQ3t4QK/WBEpUK6b+ICwUA26YuoYpTBAh alkk8CHhjKleiUlA6JhoV0W8AHP3BDXaLEQ05Zp417OdMTS5PV8FQgBcZq2VCyXXCc6rbhLYd jvvHIhtRLrGJ26wmsgBZndJxCSp8gJLwHHK9/b9C8Ch7mXBNPNZnPcm6kJYYADT+9dZWVPw19 9X0gPzvaVeGkB3xjV/Q7hapZOjQln/LDuAHGvov+aMDhhPlz2K0Y5fYTQaivODkdKwE23yOxS xMIRCwoaMCFFgnAs8+ikFUxV5wsS6Ly479SLaFv5G4HBJH3GN2QvdwtOrOzuRHucgSMjCMVa+ qSdpPuNfSdTON0WlDdveq0HTZcPpQmi5mNN80THs3llJPvuwfs1xpECeKSt7bMZ1TNrh62RrQ kadF2vx8sKQP5vNskhmdRtCYno5qkGUeI8TzaW5cApVZOc4qWAQN+UuQyc89vZ1vxY8pwmaAO HxGXXi82c/07P1Rrg7LUot5b/1rUyzvaTzgY+4RNysEcoJukfHJ3EsV/UBRHmFGJ5G7k9VptN fY9h5vm1yPac86LXyK2bzgtIGFcOpf0Xd5h2hxmR4nD6HwQjz1JLOraZ2MPA5GGERlkzXRj7S wMEpdtWs3IOZZhFs/Pru9C4kv1dh8zsrXjQWKT3fPRKT8NpW/iWuv/xjdk52RLKyYBnts0Hrn q1vmJazuh4sY0S5LECln8POKaWuUCxxQa+ihmBLccZGQrXAyunAAuZr0nDBY6xU9hrny2YUvq ypMHyYBlaEYXS7jOpHmV+EvUn95C8X4RBaulqFU/Dpfp3LTCABXvuSDXKSCivIXW4KLUV9bKl vMHqSktnBE3x+Zkw7gzqMLq6eypBcqR20ZAGYNkAhB654Zdvqf/IGJZiu+r4TPQYkMxsspqGG 9wmVj8Y4KreVd7serOh+6/KYhdUPs1Rx3r1/U0LmYR5HSnPYSenkGHtv/Mm0BeckW6pwL+tiZ ehJW+aI9tDFhRFJ2oKCoY5FeZEvPH4ZjQONqVXCYnXI52Uv3EAr05LwJpRccdIGSxqmrGdJSV 4b/vHA69/tf2aedBWsr9Do/Oyvx5sSA16+4sGsytE9lt3beavvGL4sSzEdcRr6kmKymEYQIH2 +CufYnL9xkPf5+K0xKCLneTi5SrPOAuh3Qkef5WQsYAaEMp2sh7EkGxITaspnP6cW9g/QjU3o kcfIW86bedYpmKj9Z5fW1mORUVPF151cyr3p6Lcb+iPwMpUxWQonqxbwifAhW3PrinU9n0Aof M8Sgg5Ds0p0aZ0ZwlK/RYQeW0yNM5nYh5vi/gfn2/rOwwOucr5NyxQODAkjjk0MyX5HsUjyvP pfILKgLORdQtyKsXcBdKYr/p2YMCYAf2KNG/y+C+pNVhphYp4sQFeMFGb/hv95MqUtIeew3wQ phdJ3ye0yRz6GKyOFq1liH6RpcjN/Ahl6pbu+apIyUBun+DAoUCEfF+osSCbNA/9WvKRxS2T6 9kJJQVmWrE6RGDKfzlQ+Ny8iRPjoyy75xdP54G7ZkBQAaB0qolqVtsURJ+jLxGP2zBoeDe0ZA 8ZXo8byPDUOlTNU1T073O08erF7UgVOq7z5vbQuljBuoLmzZDzETLnb8fSgXCCi2kt6CxaKXz pNneWZ94Vhitpbcbrpj8ahV2pesCvVM/45LEZJFnoU29MzkqDwwC6pLq3t/KWL32EKsWgZjPs JtMs9yN3git2RFshtekQi97TXdX1HIEiBzbMs4PfMveqYztKHApQ3bfRGQajNY4v9bep6EDok FfB0U3YTIqCw9nb0XDnbCQECqC0K4VnS7UcpCJNhT++r/9p2TvNlxEvGUwiTfuUts5MDFf8Gv PP6nYItUel1zS91dmMEPz9J9aKEzc3LJvS8SZXNwfnImQjzqCtEn/dKFFdN2voGKgIyHtkIpc WC/V6n34028FNfM6DtPsK6BIwNV5zDtan9lFCiLf4DbH8lvQMicB76/X7qXdUhAvjqeIhDNFX js3fzNvOPXp0WWvaBmrOeyHHfqgQQ4x9KFWsLiYioX0a6atf8snJKaP5HOL0yh2SfrcYdWl6C dZhVadtTSXbfs9wJEcxy/ns36onp4xA30E+2zXjLfFU4rRbkiTBjY++3oavPlqO7rx3eZ91IM 2RHfLFaziE1/ONlTOp73eCFqchIQfRBKY4/a5diM6c67QY56rEdvsUAxi96ELuLazri4+hJ5t A8JkVxGt1ybhOy/U4Hd7I4d3/T5/mdiO/B4u2qkv+F7yr0DhVEFEaW344E4SkDv3USbExoaU/ FlniFAuRoLbh/fo7qHRmBiP3SGj1PDyD0jhmv0HEmX4+cvOPlEldCZPoZJ5dBxH95dh1lNh3m 8dtivl7wizbLUgqcWXIdY8DtQ6lDdRlZKf0TM3NWu+26M2qpuPiW+hrLKRTpRdT9LZ1RGfmvn mNEjNan05PUo/TzF/0VKv6WQPxE3QzmTMXTeFmwU7fAawND5DqEO/N8sdZi/ga3RAyijhqd3n N6cz/uNazhQozEJNfhjvoNx+EWvkqEZt7RZ0OIiHVbFIbsBT/SoRNDHvyaOS3kgnyrffEDn2e SRY21GrOHRxFPH33wquqCDnwCf+5FYSa9RidzIaxsYx4DnzuPs4kVCB82YAbOlmpQvkSjMDwf 4ABKNpjxKoguXgyDJjEMHYjDTIdVEcDnjsog1ZRvCw67k4C1MLPZqNmXnY4udffAEDz+WbNXU oVWugaQdoAEoRhmlC9ks5VDV3zvkLzLC6SwG6lBN5h60m+om0eJs2bQLL7LMI5x2AiWWCXUkE PtrviSlWE6KfqGPHWY2UpWtagXW1LoRuBnsxMl22hhd1SlDy+Iritf3SknI6v6H4V/r6n3tAN UJ/Z2/Vyqgivp1W3HpHxC0/xzFCtuhiAXVYz4X6XB4zhG5M6Ew/fh6hZlOF2ydDuEiLtxEJ3j bg6P5Xdw9Mx8WtGcJ+yQIBiynxBlYF8z9GZ78OiI2bbct1j5KOoEERR55R69dVZctwtUVFgju qGtmi7BK5l3Yr542ZjKlZ10PV4YAB3VwV4NoGnk2VZaHm2I5uuZocf2u9GqAyLLamGZAVVWss bQ+Yz8BPrGaEti5cdJcALsMDrlED6oSdyarxx/TjZHNBcFgXoazX9myT+n/mIUqQ35JRIfIDT TpvOh7WQ9oiTSsalDPDdg5bo3pAUNmDDG/vAssl4YBbAC7acj5O3ftIZ5M/z+LoSiq42N3EeZ IZNvFLe/OLJOCSYrwhweec6mc4eqTCbNF565l4PxpW9JulETDVZYIJlWtE0Z09AJkl4z68qxY /TuYAgmsny6mocWN3Bcr9wRq8w+cKYfxQW235bbOfY5YOMy+QKnWA8LKid51Yy6wY2yMJdpwV NFIrmIDa67CpE+Nn8iUskGJCzuWEc06zldnKiQBTemzQ+UQblXT252AFyMmKsqC1A3kB7didS gulEcRME4S4Dte/nO9D3l5PnzpD3P5PAMRL76N4TOYlpgEINdnuz8JQZXXcv5z7RmUwU4pSeR 9V3CINOAS7rUem8oAll1c5uFfzg7HaYlMHmDXgZmK2gh9Bq2Tfr01O042xbHk+Q9xCNhnbFrv 7VgHpQzLRGoQhg39W25EnpqzsM88DLhAULvwH4GKkQKtumZPMa86tXKoZ041uBg7CnSfmMpgh JjWCTtB/zP7EArd/pTrv7s9HVisEwN7RdW6dYnTo5gT7Fpj2qagbZdDIeCZw== =E2=80=A6 > +++ b/drivers/tee/optee/rpc.c > @@ -393,6 +393,11 @@ static void handle_rpc_func_rpmb_frames(struct tee_= context *ctx, > params[0].u.memref.shm_offs); > p1 =3D tee_shm_get_va(params[1].u.memref.shm, > params[1].u.memref.shm_offs); > + if (IS_ERR(p0) || IS_ERR(p1)) { > + arg->ret =3D TEEC_ERROR_BAD_PARAMETERS; > + goto out; > + } > + > if (rpmb_route_frames(rdev, p0, params[0].u.memref.size, p1, > params[1].u.memref.size)) { > arg->ret =3D TEEC_ERROR_BAD_PARAMETERS; =E2=80=A6 How do you think about to use an additional label for the shown error code assignment? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/coding-style.rst?h=3Dv7.0-rc2#n526 Regards, Markus