From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"rohitner@google.com" <rohitner@google.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"CC Chou (周志杰)" <cc.chou@mediatek.com>,
"Ed Tsai (蔡宗軒)" <Ed.Tsai@mediatek.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>
Subject: Re: [PATCH] scsi: ufs: core: Fix mcq mac configuration
Date: Wed, 21 Feb 2024 08:50:12 +0000 [thread overview]
Message-ID: <2e21a0fb608858b2492808ee35da2c335ce4c0c0.camel@mediatek.com> (raw)
In-Reply-To: <20240220095637.2900067-1-rohitner@google.com>
On Tue, 2024-02-20 at 01:56 -0800, Rohit Ner wrote:
> As per JEDEC Standard No. 223E Section 5.9.2,
> the max # active commands value programmed by the host sw
> in MCQConfig.MAC should be one less than the actual value.
>
> Signed-off-by: Rohit Ner <rohitner@google.com>
> ---
> drivers/ufs/core/ufs-mcq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index 0787456c2b89..c873fd823942 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -94,7 +94,7 @@ void ufshcd_mcq_config_mac(struct ufs_hba *hba, u32
> max_active_cmds)
>
> val = ufshcd_readl(hba, REG_UFS_MCQ_CFG);
> val &= ~MCQ_CFG_MAC_MASK;
> - val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds);
> + val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds - 1);
> ufshcd_writel(hba, val, REG_UFS_MCQ_CFG);
> }
> EXPORT_SYMBOL_GPL(ufshcd_mcq_config_mac);
Meidatek host controller MAC_SUPP_MAC setting is 64, which
should config to 0x3F.
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2024-02-21 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 9:56 Rohit Ner
2024-02-20 20:44 ` Bart Van Assche
2024-02-21 8:50 ` Peter Wang (王信友) [this message]
2024-02-21 9:07 ` Can Guo
2024-03-10 21:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e21a0fb608858b2492808ee35da2c335ce4c0c0.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=Chun-hung.Wu@mediatek.com \
--cc=Ed.Tsai@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=rohitner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®