From: John Garry <john.g.garry@oracle.com>
To: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
"Steinar H. Gunderson" <sesse@google.com>,
Qi Liu <liuqi115@huawei.com>, Kim Phillips <kim.phillips@amd.com>,
Florian Fischer <florian.fischer@muhq.space>,
James Clark <james.clark@arm.com>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
Sean Christopherson <seanjc@google.com>,
Leo Yan <leo.yan@linaro.org>, Kajol Jain <kjain@linux.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 01/11] libperf evlist: Avoid a use of evsel idx
Date: Wed, 8 Mar 2023 12:24:01 +0000 [thread overview]
Message-ID: <2e284b0a-1ccb-dcaa-91bf-56dd9428ead8@oracle.com> (raw)
In-Reply-To: <20230308081731.1887278-2-irogers@google.com>
On 08/03/2023 08:17, Ian Rogers wrote:
> Setting the leader iterates the list, so rather than use idx (which
> may be changed through list reordering) just count the elements and
> set afterwards.
>
> Signed-off-by: Ian Rogers<irogers@google.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2023-03-08 12:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 8:17 [PATCH v3 00/11] Better fixes for grouping of events Ian Rogers
2023-03-08 8:17 ` [PATCH v3 01/11] libperf evlist: Avoid a use of evsel idx Ian Rogers
2023-03-08 12:24 ` John Garry [this message]
2023-03-08 8:17 ` [PATCH v3 02/11] perf stat: Don't remove all grouped events when CPU maps disagree Ian Rogers
2023-03-08 8:17 ` [PATCH v3 03/11] perf record: Early auxtrace initialization before event parsing Ian Rogers
2023-03-08 20:32 ` Liang, Kan
2023-03-08 21:22 ` Ian Rogers
2023-03-08 8:17 ` [PATCH v3 04/11] perf stat: Modify the group test Ian Rogers
2023-03-08 8:17 ` [PATCH v3 05/11] perf evsel: Allow const evsel for certain accesses Ian Rogers
2023-03-08 8:17 ` [PATCH v3 06/11] perf evsel: Add function to compute group PMU name Ian Rogers
2023-03-08 8:17 ` [PATCH v3 07/11] perf parse-events: Pass ownership of the group name Ian Rogers
2023-03-08 8:17 ` [PATCH v3 08/11] perf parse-events: Sort and group parsed events Ian Rogers
2023-03-08 8:17 ` [PATCH v3 09/11] perf evsel: Remove use_uncore_alias Ian Rogers
2023-03-08 8:17 ` [PATCH v3 10/11] perf evlist: Remove nr_groups Ian Rogers
2023-03-08 8:17 ` [PATCH v3 11/11] perf parse-events: Warn when events are regrouped Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e284b0a-1ccb-dcaa-91bf-56dd9428ead8@oracle.com \
--to=john.g.garry@oracle.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=florian.fischer@muhq.space \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=seanjc@google.com \
--cc=sesse@google.com \
--cc=suzuki.poulose@arm.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®