From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: phy: Add support for driver-specific next update time
Date: Wed, 5 Feb 2025 18:42:31 +0100 [thread overview]
Message-ID: <2e316ec4-8f5b-4dbd-96d2-aabc29bfae17@lunn.ch> (raw)
In-Reply-To: <20250205091151.2165678-2-o.rempel@pengutronix.de>
> + if (phy_polling_mode(phydev) && phy_is_started(phydev)) {
> + unsigned int next_update_time =
> + phy_get_next_update_time(phydev);
> +
> + phy_queue_state_machine(phydev,
> + msecs_to_jiffies(next_update_time));
Ah, i missed the msecs_to_jiffies() call. But the driver change now
looks wrong. I think to keep things simple, the API should use
jiffies, since that is what phy_queue_state_machine() and
mod_delayed_work() expect.
Did you test with Timer frequency = 100, that should make errors more
obvious.
Andrew
next prev parent reply other threads:[~2025-02-05 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 9:11 [PATCH net-next v2 0/2] Use PHYlib for reset randomization and adjustable polling Oleksij Rempel
2025-02-05 9:11 ` [PATCH net-next v2 1/2] net: phy: Add support for driver-specific next update time Oleksij Rempel
2025-02-05 17:32 ` Andrew Lunn
2025-02-05 17:42 ` Andrew Lunn [this message]
2025-02-05 9:11 ` [PATCH net-next v2 2/2] net: phy: dp83tg720: Add randomized polling intervals for unstable link detection Oleksij Rempel
2025-02-05 17:35 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e316ec4-8f5b-4dbd-96d2-aabc29bfae17@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®