From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8517B39478B for ; Mon, 24 Aug 2026 07:41:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.19 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787557301; cv=fail; b=BUc5Po7c02en983M1fhzNDrKBQup09/c9zCbIAJz/cfPZd3mfJlrhuefZE8QVW+s2XNB3TiBXWaTMjMFZshmZWSQHTVXEpw8OZZKm0yMgRTr0f8O6UeVPu9tUG2occ2CwTToxae6bNzc4NVFfbj3UtoywRMyYhqYgsvUXD4llZQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787557301; c=relaxed/simple; bh=LhuZRzy0lZPA/XOVxxMCUE+gj1cB3uORCOnM2oeRBXs=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=eKbX3qus+lhSwh4e40w9I/7wh6HB7S4sC40th+vEtHmVpoZCSL/IGWInuqvQN7HOakeDWtu7hptPvCNOHdO0aQ4LXp9idbT8hwvTnOZDTqKf3B8h9p1BShP+H45L6cVLR3RdWL+obyaXXvJyiy/bGsTY0Y/A0J39D3QsV2ixWnQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ggUBKPQz; arc=fail smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ggUBKPQz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787557299; x=1819093299; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=LhuZRzy0lZPA/XOVxxMCUE+gj1cB3uORCOnM2oeRBXs=; b=ggUBKPQz+Wv2Lay699xIcsGXao//GwiGEbb09Z7UHuKDC2wpxR+A8ezm Z5RNP8PG5kplSXTfoKXSyY3D987Xec/no6rpO7Q82HtXe90bq/qZLOKkg J+FBhx5BXKiwgitTSgr/6WomVEwZrdwG+UMIhiJ+R/TlQrOdSBtdAkFFr kM1o1hO+fTeUF/1JAkc+XMTCiYRNavjMEE685phNwSX+kaWJq+xMVo0Wz c+TWSI8Nj8sfkXbUOmFSyeQwDK+2a2wKKdvWBEturz7WrN3apXYeVIMaI PzbM8+yjM1xuK6CcX1g+W+zEDzDxjfhn6eU2ZkcFZ7TR26HKaXiMzNKmb Q==; X-CSE-ConnectionGUID: cJtG8FQ3S9CGu4WjHFxHrg== X-CSE-MsgGUID: KPtJnl3cQ7OCb7C+qwPeEw== X-IronPort-AV: E=McAfee;i="6800,10657,11884"; a="86952389" X-IronPort-AV: E=Sophos;i="6.25,240,1779174000"; d="scan'208";a="86952389" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2026 00:39:27 -0700 X-CSE-ConnectionGUID: 5uhDHXsSRYqp073QMH05Sw== X-CSE-MsgGUID: bIr5KPo5TIekIyeBJQ2tYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,240,1779174000"; d="scan'208";a="305126521" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2026 00:39:27 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 24 Aug 2026 00:39:26 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Mon, 24 Aug 2026 00:39:26 -0700 Received: from BN1PR04CU002.outbound.protection.outlook.com (52.101.56.2) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 24 Aug 2026 00:35:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OZL2tmFLxwm7cGuy5h2IT00Fh2+bufqluiCbgonnjTccpg5MSfyAUUh+s6ww8+fB5lJ/4FTT6gVwudHQAknjdYnUjp4qP6Qv5Dm73mYx55mdyxqEymWgQ/Bk/nMXVCSEDCbWZ9Er9ss+eys+lc1FF3sQZnvXXqOJQCCPWVZaEOwas7biU4YLtyzaI+10q0DcMqJAVeOiZd98HGNjTJWo/42qJlayf5l0M12GRjlx5aT7od7Mz84aV6Yh24bo92/dUkY8IP0v+On2cJrbjPW+w5FQaNBGd8payQVO0TrGvGoAFaxdpaJXwUPXc1n4OB849Bnhzq+aj2ztXTr+dEvu7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wQk1hW3cbuwPqII6G07LPFgtBa/vejXMTj/H40CVUuM=; b=fSn27QF0QbjIz133yfy7RUtGaN7QyGtq0UuP7CFot5UmGXAkGFDTPxbZsM98J3kdvOdqQux0IDJ91kO5RaDWvYrLYOH4nAfuc8QDjw9V0ErARjwniNDL5X8CYpawRF+1Kp6T++3dcTl32G5m+dJESHClzIOd62bwSRw08nKSnyACVVUFgErbhhwpI835tZy9YghOpUXG61tzbvMe2FZh0ngH/88mnFIY9gVl02BPeWk0MEITpaPra7bQ2wmBcCIEriRkLr3l8j36j0EGdItPY+0JeMyzrhstcOhFjlllOIghrkB4hkhmB0Lvoh3gDyKA1HNhZdkzvWODKu9qjsX/QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) by SA3PR11MB8118.namprd11.prod.outlook.com (2603:10b6:806:2f1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Mon, 24 Aug 2026 06:41:17 +0000 Received: from IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456]) by IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456%3]) with mapi id 15.21.0339.012; Mon, 24 Aug 2026 06:41:16 +0000 Message-ID: <2e31919b-a60a-42fe-80ee-b728984af75e@intel.com> Date: Mon, 24 Aug 2026 09:41:10 +0300 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] mmc: sdhci-of-k1: use str_fail_pass() helper To: Dmitry Antipov , Andy Shevchenko , Ulf Hansson CC: Kees Cook , Julia Lawall , "Nicolas Palix" , David Rhodes , Richard Fitzgerald , Tony Nguyen , Przemek Kitszel , Edward Cree , References: <20260820061113.4176623-1-dmantipov@yandex.ru> <20260820061113.4176623-5-dmantipov@yandex.ru> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20260820061113.4176623-5-dmantipov@yandex.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P189CA0022.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:552::13) To IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB7198:EE_|SA3PR11MB8118:EE_ X-MS-Office365-Filtering-Correlation-Id: dacd9302-33f2-4b14-1789-08df01aab2d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|7416014|6133799003|56012099006|11063799006|10067099003|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 2DjuxJHJcIR6Ocb0qtummBTIQTtwilM9FppkfPn9o1DsbkNv8RyvVTLGlg5UxS9sJBxYPYMyUWSKT0oHIcGT4B4AlJ/GckHk87jN1Gdn91Xy/l8lN35/K0cd6Jdw9c32K450M/nebxF7mN9V+zxg9ThXvq89fz/kSOsHzlfGzyGI9Ttw+j5gmjHqrV6ig3nOK0tHa+v+TlgCXK75mqeTR8I9ZnMCq0qjQrXOf2R1/oBzUPxWX7iGDToCilRduyvGbNBzY2J1hmKm9Biq8QcPQQr55yDzaUKpyY5QDeZth5ewFeD4yxj8Jd8wYYE8pJLEIZy/7DXdTtSWndsFEyZTnfpg3bqFcGtZ6TVKKoxSamIMosGpj+FSFrA957o6Q3saUY2OLxxmzb1GvnFzIi0O+MZaDXn5/9T1N9oR0urczw7G/Ty1TAuiXx1DsoN2D4TcVXOSkCKsT6j+fYhaDVJVZbjEneLJg0Dy5OYhb2e2AgVbpOnNejp12jvnmNXCvNYgzp9kcxQYtLmDd5hIWP30x1WXipqoV8tX8dU1iZ5uafbxGNefpHwjS8nJy90o45I9BPnlTAmDv9UDFXQhOlYC0hH8AdLScQ51Sudbga4P7MHPgZp/36UCWeG1rOL12gglwL9ADnVAOkNxkJnamfaGCOYxzdo7VsoTLKxqbHferkI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB7198.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(7416014)(6133799003)(56012099006)(11063799006)(10067099003)(4143699003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjA2dG1ReWRubGV1Q3VLNllwTEc2WE1KeHNzM05rcWNpSXNSYWZwNnZsbVR6?= =?utf-8?B?LzJtZmxSRlQ4czdRSlYycVh4RndrVEJDU1FhcnNleXNqRk5UUzdtWFNNYzdl?= =?utf-8?B?bDZVUW02TDhOcFBTeUd6NjZjWTg2L2JkZS9xSXp4QjlhZXdXOFEvc1hoYmFh?= =?utf-8?B?ZWVvU3FOVW1jbFJsTDdoY2ZNWlNiNXl3TCtKUEh1QkxpSTYxZFZmZGhTc2ho?= =?utf-8?B?bm5wOHFsTjQ5bnlMckR6ZG5LTkhQMnlTa21ucHZUeEx4RUk3WVRFTG5hUWpF?= =?utf-8?B?dDlNcFU1SENUalNSN2NZbmwrcWNHVXFaUEQ3ZlBhY1JyeXF0TWdWbzl3TnYw?= =?utf-8?B?VHg1ZXBLdkhPalBlbElNRDVzaU5GNVM2N2dBWWV6amlkZHFxN2tDUUJiUC9Q?= =?utf-8?B?VW5mbWQxd3RmdjcycUFnZzVqdXF1SnVKSzNRaXdRcnFkZXZIRkJsUW1keFI1?= =?utf-8?B?OVViRHdRWHRFa0tWY0dXRkpLWlhIWVR0enZ3QldVQllZM21iL1krTjBsZEdM?= =?utf-8?B?UzFRNXJIVTY5QkVvSUs5MjRERERWN29PdzZFQ2R3eVd3TVVvS1g1MHJNaUtN?= =?utf-8?B?cWEvbUlRd3pybk8yeGpITGZ0bjlsMmhnbjAvVVV4VTErWFVFVWRyZm1SNHUx?= =?utf-8?B?SzhWOUF3cHB6NjZyWlIyUUh6QTFoQ1QrWnk3dW5GYnhtUVhpeTlWUU1DZWFq?= =?utf-8?B?UDhqZk0wbURrNjNHVkkxVnE5NWpPTTh3MVpLd2pBZVNDZ2dINE9EcWRMc3JK?= =?utf-8?B?VWF0MmkwcUJhajJrQXNRTzJBdGJTMXZCZVFLNkpqTHJYc1M2T2tZZjd6b2to?= =?utf-8?B?RFMwWmZxQmF3YXFBWE43OXVnRWZGQnBmOGlvZE1RZkROOUR3SkQyVGlwMW0w?= =?utf-8?B?dnpDTE92alhBTWxGWDF5TVNCb05FZUhVUjJJUENpV2djVzhEdnd2VU5tWHB0?= =?utf-8?B?MU1XanprUmpMenpkcTlVd1RWTFJ2WTFQSEF3OVlrM3hPMUs3bGV0UWIybVM1?= =?utf-8?B?Ynp2bWZYd1lNYXFIeExXWmZKZmkwUGpvcGtVSlB1ajZFM0ZkYnQ1L2RKU1o1?= =?utf-8?B?S2pJS1hIQnQ2ZUZoTDVjUEFSVkhnREI1VnZxbzA1WGZQa2x2N2crdFVBY3J3?= =?utf-8?B?bFltM1Y2U2dhVm5sVlJ2MFVGTHhhdjIyNW1sSS9tQkZYUldNQmVWTk1IOEdt?= =?utf-8?B?SFIzbThJMEluS2RwVnZyMm12NUo3Y0dBbzA0L2M0REVzZkUvSjZlRS9SQkRa?= =?utf-8?B?ZDhtWGsvSXdyWVltZ05IM2ZiY1dUSkcrRlRWZFQ1WkVxMVdkT3BsVUZrVk5H?= =?utf-8?B?Nm5ZbnRkT0x4ZWc5TXJBMEJtc1d6ZEk1M1NmVmJYVUVxQnZ2QU9aZ3dVOTNw?= =?utf-8?B?ZWxzMlZ3UzlrVlZpYytqck5XSlA4S1JaWXQvQjNkVWRkajF5ODNONHNmdGxJ?= =?utf-8?B?QnZkWkF6dWNWOHFEMVlWWFJSNFYvZ2Q0dXFVKzNBWG5hRzZqcEFZYS9ndzJ1?= =?utf-8?B?WWFKdHNHNlhIaXBVRlpZdUhqRnhYSTZ2bjBJWVd4TktnS3lUYXQ1T1ZTQWE2?= =?utf-8?B?RGtSRnR3Y2JGV2JKQmNjY3B0ajJ4UW9uSFNjS05PaGh4QVhSOWRsMzFWNHdE?= =?utf-8?B?VnJwdndoMXlyRVlLVVJGNUg4NGl4UGhTeS85emVxWTRqaGFZaU02L3NqV0tF?= =?utf-8?B?L0oyS1kvSW8yVmlnVTFCTlg2RXo1U08wMG9SQUZNMWQwa0ZLOFdLbTVpMlF5?= =?utf-8?B?eWlQcmwxQWYxL2tWamNPb1RQTXM1NnFlZTgxQzhsMWFXT3FaTER3THA1Wk5m?= =?utf-8?B?N0lXSkFrT24wZm5ISGFGRm1sVjZsb3dRalBCQW45cWRuTy9LZmxtaHJJaCty?= =?utf-8?B?cm5PM2ljUUF1K05UeWRCMm50RVVER0xUN3E0ZUxlSG9GRjNqREpmRDF4VzBj?= =?utf-8?B?VlA4WDBwZ29obWgzRmtUeGp4NUhTV1BiTDQxRFBHbTc0RDVXU1J3YlVnbFBo?= =?utf-8?B?d2NGSklWaTJlMld5M24reEQzWDNtR3o1ZklzYXd1TXdLZ3F6WC84ME5OanFV?= =?utf-8?B?MTNVc2YwWXRaaXFYNGgzd2pmQTVPVjRhcysvMUp6SEZ1UXB3dXFuY0JuaWwy?= =?utf-8?B?OHA2TC9rS0drdk9obGhUQnJyWnFvNjJIWlFCU05xT2NOZENURmgvYWFpODBz?= =?utf-8?B?QW1OdUtCOHA1SkV0UjNVcnNJQzJnMXVkbmJlMElCb1hxb0ZHbUM4R3hZT05C?= =?utf-8?B?UVhSTEoyd3o2eTFjaFNsVEFpYmliKzNDM3RVTzJmM25YNnhoc0w5djExY3BT?= =?utf-8?B?MTN4eDFIVENENTJOTThjc0xQZ1FxbnFYVEZIMUhRUERmdS9QSThRaVZFNnNX?= =?utf-8?Q?GOciBrVb0qZD0AF4=3D?= X-Exchange-RoutingPolicyChecked: tPmnIQB45OB6wckKRjWH6YA2qE4u3U5COrVsOPMOXj0xyF7S59Xxe4WVAlrg/7M8mFr789ZkGKKzAQ473pJRPF8ToFG/915p/9T6Dm6HSzVsbU3ejTEgvXQW9aSmF6W0JyoPUaUPTIpD/XKIKUWArl7phni1i6iBfyqVXbxKi+w9D+lHoz/6nwPhfrmI+8btbswU6YRmh5DzXmVgp2OxYgsV7VSNafoQdYW05oIBdyTcFQamECBcNJFJkXrXp7O/gpptrZr7hFXWGM6nx34DODVblR8OH+HQSAoa/30VdjwFWMCbAVKswGtWESDoAO0qfhmUaY4CFkT29A4ytliN0g== X-MS-Exchange-CrossTenant-Network-Message-Id: dacd9302-33f2-4b14-1789-08df01aab2d9 X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7198.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2026 06:41:16.8379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ny9wEMKWWupqBqMifpt3gtsF7DKgXYYtsd0HocKgxEYuMdJMNGk+I4x+FDzAstqhtsqiIGu6MQMXs0zoGtwQcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8118 X-OriginatorOrg: intel.com On 20/08/2026 09:11, Dmitry Antipov wrote: > In 'spacemit_sdhci_execute_tuning()', prefer 'str_fail_pass()' > choice helper over hardcoded strings. > > Signed-off-by: Dmitry Antipov I would say it is not worth people's time, but the logic is not broken, so: Reviewed-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-of-k1.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-k1.c b/drivers/mmc/host/sdhci-of-k1.c > index 37b0911e7cf2..80986c64eb83 100644 > --- a/drivers/mmc/host/sdhci-of-k1.c > +++ b/drivers/mmc/host/sdhci-of-k1.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > > #include "sdhci.h" > #include "sdhci-pltfm.h" > @@ -293,7 +294,7 @@ static int spacemit_sdhci_execute_tuning(struct sdhci_host *host, u32 opcode) > ret = mmc_send_tuning(host->mmc, opcode, NULL); > > dev_dbg(mmc_dev(host->mmc), "RX delay %d: %s\n", > - i, ret == 0 ? "pass" : "fail"); > + i, str_fail_pass(ret)); > > if (ret == 0) { > /* Test passed - extend current window */