From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C62C647DFA7 for ; Mon, 5 Oct 2026 11:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791199601; cv=none; b=uHB+JkHQEnk+pzSFgIGJarv7BZ/xeBZEGKDTjTMK7au6+9WXa4TxKfRHoKtL7e08XR1WSO57BtUWa4fZ3N7lTDNP8HmZSNnzmcbYsjkYFS0mNxi3UwV+1ZPlscs657nBLM0i5AtMHAdOxJbHbDXi63k07tuGTQaBZnhPxtTPH+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791199601; c=relaxed/simple; bh=yk/Cc2UXGQJHNPGD+r0qn3N86ApXOo+zkdin0WsYYT4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=glARUBue1CfMc4Ce6B3cx4XaclqgJ9/G93q1LNLguBZBZ8H6zJoou3Ohdnq237rRimAHFCICQPYL+Q6IKPAjVEIAC/QYzZvX4h38dUawG7rNKGuwTFn6tUQVDbWNJppP8IyQgpY+nkx30oy7aylycsHfo6P9oGv/mYqtHE8hf9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R3mvDxiv; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R3mvDxiv" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-351348eb579so255286eec.0 for ; Mon, 05 Oct 2026 04:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791199599; x=1791804399; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YmAdUzfHpXWCcsCDGufdmZ0OVPyw9FksvaDdRfTvduQ=; b=R3mvDxiva4mEre220kZ742GtO1GdjtOrUiebPQytFqrsrdI2ABxNZtZZtWDYZlhZ+x aFIbu9aiU51qaCKy5VA+vZvdz4WJWVEbEWKqkiXy2jZGOl+D0ZmCrshuTN+AJrtKJgy8 pesddhRoIJtdPRPqvFgXGzzyglHvR+eOpbLcoO0ZJ03VVJaGe9EiaBMv55Bc7YpoFAXs au7xzuMiolrS4WbPCfmgQQRmizTU+eg1ibnG9iwn978ZqMyxt27+5e/O50mGTA3tJRoN N4T8zeWRN0yAnhkQsChibrBGZ38pXQTRjNJW/A66gJc1+DpRsdoP0hMVlrPwaIX8pQlP LI+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791199599; x=1791804399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YmAdUzfHpXWCcsCDGufdmZ0OVPyw9FksvaDdRfTvduQ=; b=0K+enmJ5U3q2tZ0GjFjqb6OsEEBY5UrA7kK+Xk9+OtM7jjDMesKqDR7ukoVjIlAPTN 6yz7HoAIroB25N2PS2WdV19qUkfj3zbP6AvVfxoCRl8/smPnrBDOMTAsHPktYznc5Aq9 veR5JwkDNz3TJvodDQfaj0atN7WF5eMq3Dk03Ovko8HDQjK1kpAQa2bug8AqG+Ukkxeh 4ckdAmNDLVpZbDj2K5MfzrUWAHNysO+G0xKnrdGG6/uJ/XwvhpJ+5qtHlkn81A+LT5fW s+Z/FspmMFqF4EJx3+qRw6YZsc48xIzkd8JrF7SFdi03WXvYyYIDj80oi+p239znqvUI 5AvQ== X-Forwarded-Encrypted: i=1; AKwUvBxp+j4/6GypmzQaeTzrm37C3vtHwdNS6gKNJu/ifGrFwTOWoZFDsS+B9oYs8lQYb8AAH24B1p1YTU1ZEaM=@vger.kernel.org X-Gm-Message-State: AFuF++lOeFamNr+2bzlroi8PIyoQn5d6dU+kQ4Klaw/BgpkbCZ7HHq4X WUT2edJ/b17M1durgIVZB5G9Djv/KSBag0eWcfU4VRsGL9rhaVLu5Kwz X-Gm-Gg: AYBFou2/32qtjG6lhzhk712qhDwJfzUvTeiIm0Q3XSxZHpmf4PZGNDKneqjfLSgg9EH wXIjse/75Uj2LsTzwdhWiQ0N3Fevc5MI1nXmWmbBetZPry8qv5DwHpOEdgpRR8SCNtjAw5jjjYp kASs/FJuzfFc3KmkHdNyb7s+86Uq8CdpvEf0fLCeyk2aRfMIFDCDwUfhk9KS3QvPexObolB4Czv KjorGEFybhuvDGIz1c/M2hpL5grfYKo+wZuVEtZwLI/xW6xKGPMvKl60XiIgHmdfX+647kwRFoS BOyad9fKtz51S5tefCuTWA/U74Xg9qZ4RQDb7Xz+CKQWx9opebuCQrYVS7Pz9BGlnA03CTn/T4t hW7CwV6F6RV5nhLgLbx++mo4Q+2iq/OZ+8Zi2F0E73tXD41K4nrpTMuufpUh4rIzctqIn9r+ysp 0gofoFUVIwyxJWv9LXBDqhui0OE1pS1gJEM6VvScLUuNF/cJKvq+b8XZB78IfTXYVzj4vhF+Xiq YaEbe4lxSi1lppz X-Received: by 2002:a05:7301:6195:20b0:33e:61ab:8309 with SMTP id 5a478bee46e88-34db72e503amr14890548eec.23.1791199598602; Mon, 05 Oct 2026 04:26:38 -0700 (PDT) Received: from JMD.localdomain ([220.158.183.16]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-351277a2fb4sm14902080eec.26.2026.10.05.04.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 04:26:38 -0700 (PDT) From: Atul Akella To: linux-remoteproc@vger.kernel.org Cc: Atul Akella , stable@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Matthias Brugger , AngeloGioacchino Del Regno , Pi-Hsun Shih , Nicolas Boichat , Erin Lo , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 1/2] remoteproc: mtk_scp: Fix bounds check in mt8183_scp_da_to_va() Date: Mon, 5 Oct 2026 11:25:17 +0000 Message-ID: <2e32034b79ea7cad99b7ea9edfb8b2ad64f5096b.1791198233.git.atul.akella@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mt8183_scp_da_to_va() translates a device address to a pointer into SCP SRAM or DRAM. Its bounds check is wrong in two ways: - offset is an int but is assigned from a u64. For the DRAM window, da = dma_addr + 0x100000010 is truncated to offset 0x10 and passes the check. There is also no da >= dma_addr check, so a da below dma_addr wraps in the u64 subtraction and can truncate to a small positive offset. - (offset + len) is computed in size_t and wraps for a large len. With offset = 0x100 and len = (size_t)-0x80, the sum is 0x80 and the check passes. da and len come from the firmware's ELF program headers (p_paddr/p_memsz) via rproc_da_to_va(), and the returned pointer is then written to by the ELF loader, so a malformed firmware image can make the loader write outside the intended region. Use a u64 offset, check da >= dma_addr before subtracting, and compare len against the remaining window size instead of adding it to offset. Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183") Cc: stable@vger.kernel.org Signed-off-by: Atul Akella --- drivers/remoteproc/mtk_scp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 9751acc2bf83..d18ae676260a 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -754,17 +754,19 @@ static int scp_start(struct rproc *rproc) static void *mt8183_scp_da_to_va(struct mtk_scp *scp, u64 da, size_t len) { - int offset; + u64 offset; const struct mtk_scp_sizes_data *scp_sizes; scp_sizes = scp->data->scp_sizes; if (da < scp->sram_size) { offset = da; - if (offset >= 0 && (offset + len) <= scp->sram_size) + if (len <= scp->sram_size - offset) return (void __force *)scp->sram_base + offset; } else if (scp_sizes->max_dram_size) { offset = da - scp->dma_addr; - if (offset >= 0 && (offset + len) <= scp_sizes->max_dram_size) + if (da >= scp->dma_addr && + offset <= scp_sizes->max_dram_size && + len <= scp_sizes->max_dram_size - offset) return scp->cpu_addr + offset; } -- 2.43.0