From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Leon Romanovsky <leonro@nvidia.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/iser: iscsi_iser.h: fix kernel-doc warning and spellos
Date: Sun, 24 Dec 2023 02:23:31 +0200 [thread overview]
Message-ID: <2e34aa5c-4e50-4492-b3c2-aed9e06e8236@nvidia.com> (raw)
In-Reply-To: <20231222234623.25231-1-rdunlap@infradead.org>
On 23/12/2023 1:46, Randy Dunlap wrote:
> Drop one kernel-doc comment to prevent a warning:
>
> iscsi_iser.h:313: warning: Excess struct member 'mr' description in 'iser_device'
>
> and spell 2 words correctly (buffer and deferred).
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Max Gurtovoy <mgurtovoy@nvidia.com>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Cc: linux-rdma@vger.kernel.org
> ---
> drivers/infiniband/ulp/iser/iscsi_iser.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff -- a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser/iscsi_iser.h
> --- a/drivers/infiniband/ulp/iser/iscsi_iser.h
> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.h
> @@ -182,7 +182,7 @@ enum iser_data_dir {
> *
> * @sg: pointer to the sg list
> * @size: num entries of this sg
> - * @data_len: total beffer byte len
> + * @data_len: total buffer byte len
> * @dma_nents: returned by dma_map_sg
> */
> struct iser_data_buf {
> @@ -299,7 +299,6 @@ struct ib_conn;
> *
> * @ib_device: RDMA device
> * @pd: Protection Domain for this device
> - * @mr: Global DMA memory region
> * @event_handler: IB events handle routine
> * @ig_list: entry in devices list
> * @refcount: Reference counter, dominated by open iser connections
> @@ -389,7 +388,7 @@ struct ib_conn {
> * to max number of post recvs
> * @max_cmds: maximum cmds allowed for this connection
> * @name: connection peer portal
> - * @release_work: deffered work for release job
> + * @release_work: deferred work for release job
> * @state_mutex: protects iser onnection state
> * @stop_completion: conn_stop completion
> * @ib_completion: RDMA cleanup completion
Looks good,
Acked-by: Max Gurtovoy <mgurtovoy@nvidia.com>
next prev parent reply other threads:[~2023-12-24 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 23:46 Randy Dunlap
2023-12-24 0:23 ` Max Gurtovoy [this message]
2023-12-25 8:59 ` Sagi Grimberg
2023-12-26 8:41 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e34aa5c-4e50-4492-b3c2-aed9e06e8236@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®