From: Neil Armstrong <neil.armstrong@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
Mohit Dsor <mohit.dsor@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
vishnu.saini@qualcomm.oss.com,
Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [REGRESSION] Resolutions broken after "drm/msm: dsi: fix PLL init in bonded mode"
Date: Thu, 24 Sep 2026 09:09:39 +0200 [thread overview]
Message-ID: <2e369f45-6c9a-4604-a66e-f35c0904ec0f@linaro.org> (raw)
In-Reply-To: <y64m2frbbg67zfukyuuds5cx65fx3rjxfujbckoerv7sswhk2u@i6p4k3ul4aec>
On 9/23/26 22:58, Dmitry Baryshkov wrote:
> On Wed, Sep 23, 2026 at 12:48:21PM +0200, neil.armstrong@linaro.org wrote:
>> Hi,
>>
>> On 7/8/26 15:31, Dmitry Baryshkov wrote:
>>> On Wed, Jul 08, 2026 at 09:26:04AM +0200, Thorsten Leemhuis wrote:
>>>> On 7/6/26 11:52, Mohit Dsor wrote:
>>>>> On Wed, Jun 03, 2026 at 03:11:34PM +0300, Dmitry Baryshkov wrote:
>>>>>> On Wed, Jun 03, 2026 at 11:56:15AM +0200, Thorsten Leemhuis wrote:
>>>>>>> On 5/4/26 22:09, Mohit Dsor wrote:
>>>>>>>> Sorry for the late reply. I am attaching clk_summary and reg_dump in
>>>>>>>> working and non working case. Lilliput is just a normal display working
>>>>>>>> with hdmi and has 720p as preferred mode. Yes, I was talking about RB3
>>>>>>>> Gen2 only.
>>>>>>>
>>>>>>> Neil, Dmitry, and Mohit: what's the status here? From the outside it
>>>>>>> looks like this regression is still unfixed with nothing happening for
>>>>>>> weeks now. Or has progress been made and I just missed it?
>>>>>>
>>>>>> Thanks as a reminder. Unfortunately, it takes some more time (and I've
>>>>>> been a bit overloaded lately). Worst case I will send a revert soon.
>>>>>>
>>>>> Just wanted to check if you had a chance to look into this issue and whether there's any update on the investigation from your side.
>>>> Hmm, no reply. Given that we are entering holiday season and are way
>>>> past what Linus expects in a situation like this[1] I'd say we should go
>>>> for a revert, unless some fix shows up really soon now.
>>
>> Sorry I'm very late to the party, and checked again, reverting this breaks all dual-DSI setup
>> on SM8650, and probably other similar SoCs.
>>
>> Here's a complete log of the breakage which appears on the Ayaneo PS2 running v7.3-rc3 with mainline panel driver: https://gitlab.postmarketos.org/-/snippets/65
>>
>> I don't see why my fix did break this use case since it reverted the way the dual DSI PHYs
>> were initialized to actually allow the dual-DSI setup.
>
> See commit cb55f39bf7b1. Without PLL_SHUTDOWNB and DIGTOP_PWRDN_B most
> of the PLL registers read as zero. Currently the regs are handled
> correctly (almost). With your patch in place the SHUTDOWNB gets dropped,
> making PLL loose reg contents (and return 0 to CCF as the selected divisor).
> Current code depends on those two bits being set across host_power_on.
Thanks I'll have a look.
Neil
>
>>
>> Thanks,
>> Neil
>>
>>>>
>>>> Ciao, Thorsten
>>>
>>> Please send a revert.
>>>
>>>>
>>>> [1] To quote Linus statements from
>>>> https://www.kernel.org/doc/html/latest/process/handling-regressions.html#on-how-quickly-regressions-should-be-fixed
>>>>
>>>> """
>>>> From 2026-01-22:
>>>>
>>>> But a user complaining should basically result in an immediate fix -
>>>> possibly a "revert and rethink".
>>>>
>>>> With a later clarification on 2026-01-28:
>>>>
>>>> It's also worth noting that "immediate" obviously doesn't mean "right
>>>> this *second* when the problem has been reported".
>>>>
>>>> But if it's a regression with a known commit that caused it, I think
>>>> the rule of thumb should generally be "within a week", preferably
>>>> before the next rc.
>>>> """
>>>
>>
>
prev parent reply other threads:[~2026-09-24 7:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 13:09 [PATCH] drm/msm: dsi: fix PLL init in bonded mode Neil Armstrong
2025-10-27 13:20 ` Dmitry Baryshkov
2025-10-29 0:30 ` Dmitry Baryshkov
2026-04-25 22:08 ` [REGRESSION] Resolutions broken after "drm/msm: dsi: fix PLL init in bonded mode" Mohit Dsor
2026-04-25 22:44 ` Dmitry Baryshkov
2026-05-04 20:09 ` Mohit Dsor
2026-06-03 9:56 ` Thorsten Leemhuis
2026-06-03 12:11 ` Dmitry Baryshkov
2026-07-06 9:52 ` Mohit Dsor
2026-07-08 7:26 ` Thorsten Leemhuis
2026-07-08 13:31 ` Dmitry Baryshkov
2026-09-23 10:48 ` neil.armstrong
2026-09-23 20:58 ` Dmitry Baryshkov
2026-09-24 7:09 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e369f45-6c9a-4604-a66e-f35c0904ec0f@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohit.dsor@oss.qualcomm.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=vishnu.saini@qualcomm.oss.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®