From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: <yexingchen116@gmail.com>, <anthony.l.nguyen@intel.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
ye xingchen <ye.xingchen@zte.com.cn>
Subject: Re: [PATCH linux-next] iavf: Replace __FUNCTION__ with __func__
Date: Tue, 11 Oct 2022 14:46:07 -0700 [thread overview]
Message-ID: <2e38c0f1-1b6c-1825-12c1-5ad135865c0c@intel.com> (raw)
In-Reply-To: <20221011111638.324346-1-ye.xingchen@zte.com.cn>
On 10/11/2022 4:16 AM, yexingchen116@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> __FUNCTION__ exists only for backwards compatibility reasons with old
> gcc versions. Replace it with __func__.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 3fc572341781..98ab11972f5c 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
> iavf_close(netdev);
>
> if (iavf_lock_timeout(&adapter->crit_lock, 5000))
> - dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __FUNCTION__);
> + dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __func__);
> /* Prevent the watchdog from running. */
> iavf_change_state(adapter, __IAVF_REMOVE);
> adapter->aq_required = 0;
yeah, how'd that sneak in there? Thanks!
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2022-10-11 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 11:16 yexingchen116
2022-10-11 21:46 ` Jesse Brandeburg [this message]
2022-10-14 15:10 ` Joe Perches
2022-10-17 22:58 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e38c0f1-1b6c-1825-12c1-5ad135865c0c@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ye.xingchen@zte.com.cn \
--cc=yexingchen116@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®