From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Jason Baron <jbaron@akamai.com>
Subject: Re: [RFC][PATCH 3/2] x86/jump labels: Count and display the short jumps used
Date: Wed, 07 Aug 2013 12:27:51 -0700 [thread overview]
Message-ID: <2e3a4a90-2915-4b75-b807-b0e802e4955f@email.android.com> (raw)
In-Reply-To: <CA+55aFwo4iFk4_6cSoK=NjCWjVgdPgKy0YfKpZd2zSGn_RXHYg@mail.gmail.com>
Well we do... both to extract relocations and to sort the exception table. Perhaps we need to merge those kinds of postprocessing tools?
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>On Wed, Aug 7, 2013 at 10:54 AM, Steven Rostedt <rostedt@goodmis.org>
>wrote:
>>
>> On another box, using a distro config, I had even better results:
>>
>> [ 2.352448] short jumps: 193
>> [ 2.355407] long jumps: 219
>
>.. well, another way of looking at this is to say that all of this
>effort saves just 579 bytes.
>
>Yes, maybe some of those bytes are in really hot paths, but the other
>side of *that* coin is that the 2-vs-5 byte jump doesn't much matter
>if it's already cached.
>
>So I'd vote for not doing this. If we had some simple way to do the
>short jumps, I think it would be lovely. Or if we had to parse the ELF
>files and do instruction rewriting for various other reasons, and the
>jump rewriting was just one small detail.
>
>But using 576 new lines (the diffstat for your patch 1/2 that adds the
>infrastructure to do the rewriting) in order to same just about
>exactly that many bytes in the binary - the effort just doesn't work
>out, imnsho.
>
> Linus
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
next prev parent reply other threads:[~2013-08-07 19:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 17:36 [RFC][PATCH 0/2] x86/jump labels: Add the 5 byte or 2 byte jumps Steven Rostedt
2013-08-07 17:36 ` [RFC][PATCH 1/2] jump labels: Add infrastructure to update jump labels at compile time Steven Rostedt
2013-08-07 17:36 ` [RFC][PATCH 2/2] x86/jump labels: Use etiher 5 byte or 2 byte jumps Steven Rostedt
2013-08-07 17:57 ` Steven Rostedt
2013-08-07 17:54 ` [RFC][PATCH 3/2] x86/jump labels: Count and display the short jumps used Steven Rostedt
2013-08-07 19:22 ` Linus Torvalds
2013-08-07 19:27 ` H. Peter Anvin [this message]
2013-08-07 19:49 ` Linus Torvalds
2013-08-07 20:30 ` Steven Rostedt
2013-08-07 20:19 ` Jason Baron
2013-08-07 20:33 ` Steven Rostedt
2013-08-07 20:47 ` Linus Torvalds
2013-08-07 21:37 ` Jason Baron
2013-08-07 21:56 ` Linus Torvalds
2013-08-10 0:14 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e3a4a90-2915-4b75-b807-b0e802e4955f@email.android.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®