From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CE3A279348 for ; Wed, 23 Apr 2025 14:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745417048; cv=none; b=dm+bdzbeSiB4KdqgX2n1F7pKpJXlw9DSmBPrxgBWKhoQPVnO/mp7sy5aPpsDOCpJ8ZOH5UD7JToX6y8kUU9ag7AIHkpGD20li5UXSb2hasozNsfUInUB8fyHyIPUx+tIfem6ugJX5mPnd4ugySh8TrxGYQCK5bEWFsP5gCTgOy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745417048; c=relaxed/simple; bh=Kpbhj1qhSKEadaVbA0z6YY9AlvNfJBM7kna2rhKpIUE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UFHHH2t5/wNCA/NTXlqxeNcjHonCbMd5LsvDpFA4Oa+uujGm+gppYIG/6LwL9680UZ2ZB71VQ7na8JfE8qJ25/imypqzH+RYdhyO6Gi5EXmrCjunlkBkPaMRwS1QyDHWNaRnX/RTP6JI/WX9whNw7g3wM7UMVDdwlkgtuc1aiT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gqLJFhRC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gqLJFhRC" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53NAkwxp014559 for ; Wed, 23 Apr 2025 14:04:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HK4v2UxJbR5fXrAk1G29VWPj/UWIHaIHZOcZYqRxF9s=; b=gqLJFhRCUndtiYt7 7nVFud9l/0MH6QpvE/kIW4J63tMdeelEMdTC1IAEuFA5K8jVzh0/d2qRdrDKK0pn GZ33/RXPMfhZ4ODI8LwwhwIjrHfe0CCVJ9oGBukOxpkpnVOdAvlmpDk6pQ9Yr6Sd sGmrczDi829QgGOBpgyZcaaTXhafCwhyZ5ukT4NVV2sYiNrr/zgOGkk/+us2b4qe PQ0B8HH0A/1PTId4jL0cQbCi2yPTJVav6wv3gPj9Mryc4kD+5qj9DW91th1v8CHe sqcBZzwfinKADXufKObWXY4eajJl+7rEEMVrYwYjd4EyLomAZtuIXhSz+/e8iXwP 1ecJ8g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh0jays-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 23 Apr 2025 14:04:04 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5841ae28eso122370785a.1 for ; Wed, 23 Apr 2025 07:04:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745417043; x=1746021843; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HK4v2UxJbR5fXrAk1G29VWPj/UWIHaIHZOcZYqRxF9s=; b=gWrzXK2pazAvkS/LBbyXHiQ96+mRpPXVskociLol1SBW8dtTKUNuTnFsTbxgff0Lyk mc4oSESyGumnxLYlgBKJBo4OMASDp+qjXI/qCkWiZVR//AyNQe7xGYbA40kcCgpeg1A5 NHvLEhrRzi0Nwl0CsQat/F/lOWUjREipD6pRTc8s3CYIBhw932dovMH8NAUrXX5fkR9H SUfHY5yjZA9GMPiidDHW8uR+paIQXdJDFtYK8eFt4ORs1E7nAzYVEbUgLZxVZsxsD3ey EKnPDCT71rOZxibaF9GUfRcQza4loa4cPMQLcUVD4WnGaJKYItIKO60urbvcJHqRvqcV ffqQ== X-Forwarded-Encrypted: i=1; AJvYcCWeWsUHdhZwSAynhGnzMu4+noV16qjUQPDQMapYmS9PWIOODQ9pINF6JUB6EObYhu7wRTOB4b2i4GypF+U=@vger.kernel.org X-Gm-Message-State: AOJu0YyVXqnyVrGVEE3d4Z6iz1puazGqRgPFG2DXFRPbKAmH9rCHPPrg oyElBZr7Ld2iGvu7AmUHhT3YWgC2WRtcLu08KrKem0StTjpjhv0fhpysqu87+Mr3O473ZGZ0IvJ Aq4fOxUT0HWm3WT4Qa5HEOENFgF/ivejhweFa78NULqr5t4mfcXa2xm1E8LzDErA= X-Gm-Gg: ASbGncua0U4KBestdk6l99s3kyjZHiGCef69H2FOfq2Ns1otXxezlfulm6FrzlGwgl1 F1+Ki0hT7ojTDkn2sToJI7rzb2qRs2UCaWT7sWM4nQcSrRBCNBWf/56LJuR97gLK0Cy34kG9FUI Q3R9MxDLaJOvxaCvUXxUhnykBldx5B7wLbfok0KEaF15T0DTcdP4YflyFfbuH4Tnyrb6njG28mI tkLueUix/3MM/i+cc+nac6q7LJLCdwpiQlQiP9D3DISfuQm5V9klUjylGQkDSz+JaVSHiSQb9nL X7E4xgLNrgb6InqafRnwigouyh/ot9jftK9+Ze2xjH2IjiZ7HS8vb0duJs+cIL98cbs= X-Received: by 2002:a05:620a:40c4:b0:7c3:bae4:2339 with SMTP id af79cd13be357-7c928038e5emr1063392885a.11.1745417043392; Wed, 23 Apr 2025 07:04:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5Nmp61dxe3+g8XquReGtc6SZo2EBLqOi9MgrQLq0RCvHH8eZt76lUCj3q3b5DnYlZ2FEF3g== X-Received: by 2002:a05:620a:40c4:b0:7c3:bae4:2339 with SMTP id af79cd13be357-7c928038e5emr1063386885a.11.1745417042771; Wed, 23 Apr 2025 07:04:02 -0700 (PDT) Received: from [192.168.65.183] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb6ec4d397sm808450266b.59.2025.04.23.07.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Apr 2025 07:04:02 -0700 (PDT) Message-ID: <2e3d94a4-d9e1-429e-9f65-d004c80180e5@oss.qualcomm.com> Date: Wed, 23 Apr 2025 16:03:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/5] arm64: dts: qcom: Add initial support for MSM8937 To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , =?UTF-8?Q?Otto_Pfl=C3=BCger?= , Linus Walleij , Lee Jones , Joerg Roedel , Will Deacon , Robin Murphy , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Baryshkov , Adam Skladowski , Sireesh Kodali , Srinivas Kandagatla Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Dang Huynh References: <20250421-msm8937-v5-0-bf9879ef14d9@mainlining.org> <20250421-msm8937-v5-3-bf9879ef14d9@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250421-msm8937-v5-3-bf9879ef14d9@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 3fxPG4wnoxzk2ip1JLXEMysw5bksM9UM X-Authority-Analysis: v=2.4 cv=ftfcZE4f c=1 sm=1 tr=0 ts=6808f354 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=bBqXziUQAAAA:8 a=OuZLqq7tAAAA:8 a=GsLbDo3STCR25-WXoqoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=BjKv_IHbNJvPKzgot4uq:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-GUID: 3fxPG4wnoxzk2ip1JLXEMysw5bksM9UM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDIzMDA5OCBTYWx0ZWRfX7xAvskVn99rg wiYqYh0P/ftzxU5s6CWQplawF9rHjrI25kXhH4O30tXYL3DgaV1yJ8cA7mBIC+lbUBb6U0WMTE2 5Fjv30dSRDgnKVeAaOftf8h5O7zMlKlI0+DFCoTdorKMwZtdU6W+aAxMFzhl9KBNN7OoSgi187C S5tSFnd+Og5fLm9F/UzLPk4+UkQsdrcPQYBzc+uEKUPQB/kGE5oJyfNpAdWm7yr3mAP7UVRHuP+ XoZaVbDXp8TALbKR55tm4ZNwAmnRJpCPX8zzgUvVbaIGn7K8tbTJURj1CUU8EwFhCdhxPGMQP5g BZgb9P/Ut+ERl2U2az1B/owmFpr591sumfyVzXkzkhM5M/UuZ7MMunbAtYr0kk2HmJjNk23v+5J gaaagjDpvMjZ1L3HHaJQuLoYys8Ax1v9bI4Oda3/NX5mO2fPt2VIKGtZvYOk1FfZ5QjXay6J X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.680,FMLib:17.12.80.40 definitions=2025-04-23_08,2025-04-22_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504230098 On 4/21/25 10:18 PM, Barnabás Czémán wrote: > From: Dang Huynh > > Add initial support for MSM8937 SoC. > > Signed-off-by: Dang Huynh > Co-developed-by: Barnabás Czémán > Signed-off-by: Barnabás Czémán > --- [...] > + tsens_base1: base1@1d8 { > + reg = <0x1d8 1>; The size part should be hex too [...] > + wcss-wlan2-pins { > + pins = "gpio76"; > + function = "wcss_wlan2"; > + drive-strength = <6>; > + bias-pull-up; > + > + }; > + > + }; random newline /\ [...] > + mdss: display-subsystem@1a00000 { > + compatible = "qcom,mdss"; > + reg = <0x01a00000 0x1000>, > + <0x01ab0000 0x1040>; The latter region is 0x3000-long > + reg-names = "mdss_phys", "vbif_phys"; Please make reg-names a vertical list too [...] > + gpu: gpu@1c00000 { > + compatible = "qcom,adreno-505.0", "qcom,adreno"; > + reg = <0x1c00000 0x40000>; Please pad the address part to 8 hex digits [...] > + gpu_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-19200000 { > + opp-hz = /bits/ 64 <19200000>; > + opp-supported-hw = <0xff>; The comment from the previous revision still stands Konrad