From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A88D4286D6C for ; Wed, 7 May 2025 13:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746626213; cv=none; b=roK/hIDlyHM4EA4Dnn5TJpb42aGJPuQ5LEbO/TknrvFqh7NnmdF5n8maqpUM6m7HSKG0gjIGeTbEIXXf+YBvVDX/DZY1452KrdiVTsb7N6d28mC2VliFgG4lAC8T9NmIuSKQtZES/vm3cV8NwJyiS+/GRqniWgfLKMe4cb13PPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746626213; c=relaxed/simple; bh=sGa1g1PPLfg0IIMC8cBZToyVlaK+S6WfeD7ZsrQBI2s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MnrA2vOO9snwNdDg6qpracIUdsRxKpwyixbC/Klh4Er7CgpUpltl7LpH9CxOb4WBioKzJv3UlOaa6AhL24YPh9JLwXFU9KWpvP41khV5sVRQwDsK3TOKmQjX+35QX7twW8CGZWCFGwSN60rsEWDPvWhuFJjyiAxnL6VyoISifi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ug+uXtEn; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ug+uXtEn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746626210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eCxlh7OLGZ6tmVtPGqGmXKkGEJLdZqILpcZUyhVzTuI=; b=Ug+uXtEn+L3FTvNN+Z9rLoRjvv13bDt6qOk3rFsoBKGqLzYSmMELcuEnDONuaLrUfitp9C 9OODUbZIAOfC1XbFhgvOo+QpPoc6cCHqBhKQcWrpLh1Sqzgfp7U/CoFVReorRR01xPAYW/ wibmCboR/KA2Cw1o6WOj5d6JULg3Ebc= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-slc2Hx5AOXe4P0uxASBc5Q-1; Wed, 07 May 2025 09:56:47 -0400 X-MC-Unique: slc2Hx5AOXe4P0uxASBc5Q-1 X-Mimecast-MFC-AGG-ID: slc2Hx5AOXe4P0uxASBc5Q_1746626205 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE39B1800875; Wed, 7 May 2025 13:56:44 +0000 (UTC) Received: from [10.44.33.91] (unknown [10.44.33.91]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 263381800268; Wed, 7 May 2025 13:56:38 +0000 (UTC) Message-ID: <2e3eb9e3-151d-42ef-9043-998e762d3ba6@redhat.com> Date: Wed, 7 May 2025 15:56:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 8/8] mfd: zl3073x: Register DPLL sub-device during init To: Andy Shevchenko Cc: netdev@vger.kernel.org, Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , Lee Jones , Andy Shevchenko , Michal Schmidt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20250507124358.48776-1-ivecera@redhat.com> <20250507124358.48776-9-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 07. 05. 25 3:41 odp., Andy Shevchenko wrote: > On Wed, May 7, 2025 at 3:45 PM Ivan Vecera wrote: >> >> Register DPLL sub-devices to expose the functionality provided >> by ZL3073x chip family. Each sub-device represents one of >> the available DPLL channels. > > ... > >> +static const struct zl3073x_pdata zl3073x_pdata[ZL3073X_MAX_CHANNELS] = { >> + { .channel = 0, }, >> + { .channel = 1, }, >> + { .channel = 2, }, >> + { .channel = 3, }, >> + { .channel = 4, }, >> +}; > >> +static const struct mfd_cell zl3073x_devs[] = { >> + ZL3073X_CELL("zl3073x-dpll", 0), >> + ZL3073X_CELL("zl3073x-dpll", 1), >> + ZL3073X_CELL("zl3073x-dpll", 2), >> + ZL3073X_CELL("zl3073x-dpll", 3), >> + ZL3073X_CELL("zl3073x-dpll", 4), >> +}; > >> +#define ZL3073X_MAX_CHANNELS 5 > > Btw, wouldn't be better to keep the above lists synchronised like > > 1. Make ZL3073X_CELL() to use indexed variant > > [idx] = ... > > 2. Define the channel numbers > > and use them in both data structures. > > ... WDYM? > OTOH, I'm not sure why we even need this. If this is going to be > sequential, can't we make a core to decide which cell will be given > which id? Just a note that after introduction of PHC sub-driver the array will look like: static const struct mfd_cell zl3073x_devs[] = { ZL3073X_CELL("zl3073x-dpll", 0), // DPLL sub-dev for chan 0 ZL3073X_CELL("zl3073x-phc", 0), // PHC sub-dev for chan 0 ZL3073X_CELL("zl3073x-dpll", 1), // ... ZL3073X_CELL("zl3073x-phc", 1), ZL3073X_CELL("zl3073x-dpll", 2), ZL3073X_CELL("zl3073x-phc", 2), ZL3073X_CELL("zl3073x-dpll", 3), ZL3073X_CELL("zl3073x-phc", 3), ZL3073X_CELL("zl3073x-dpll", 4), ZL3073X_CELL("zl3073x-phc", 4), // PHC sub-dev for chan 4 }; Ivan