From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E70A7C25B42 for ; Mon, 23 Oct 2023 22:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231454AbjJWWgm (ORCPT ); Mon, 23 Oct 2023 18:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjJWWgk (ORCPT ); Mon, 23 Oct 2023 18:36:40 -0400 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4B6E10C for ; Mon, 23 Oct 2023 15:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1698100592; bh=wM+xQTdMWTyO4bxesxODcq1HkQ/m5t1W25dETDzkkEA=; b=vGL0t4lg7LO1B56eQ/jhH2gU0QtuWbHUge5pRcy88wRYxF+Rgkc90x8GB3rVN82SI1Mar8CSy Q4ZlDqT2q7QL1Y+EGwdssNu15AuD7Ss5awxZLgaWZXOamC0tvyMcElN3O5vQQnK+MVMDc4rtRdL MKOhIpInbCgzl47YDFSyNjzDoP4pbPeCpkr3Ma1YnMEAjiKNI+Wl3g1gEabZIrwHAvOuPnV6hht yf7zlzGOTeejHE2YsxDLyYzu/kZWDdW7gfkGEZsKwOJfeenPjzgoQLBpk7ytl8Bseh8YAVes8g7 jh6KjD4hPJhUakn+q/WsrgCV05MHe+dik4J36rC4zxZw== Message-ID: <2e3f27a4-48b7-41ae-a686-930ac3deffee@kwiboo.se> Date: Tue, 24 Oct 2023 00:36:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support Content-Language: en-US To: Christopher Obbard , Heiko Stuebner , Sandy Huang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel References: <20231023173718.188102-1-jonas@kwiboo.se> From: Jonas Karlman In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Report-Abuse-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Complaints-To: abuse@forwardemail.net X-ForwardEmail-Version: 0.4.40 X-ForwardEmail-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-ForwardEmail-ID: 6536f570a54e5ddc6f4f4641 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, On 2023-10-23 19:52, Christopher Obbard wrote: > Hi Jonas, > > On Mon, 2023-10-23 at 17:37 +0000, Jonas Karlman wrote: >> This series add support for displaying 10-bit 4:2:0 and 4:2:2 formats >> produced >> by the Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399. >> Also include 10-bit 4:4:4 support since VOP can support that also. >> >> First patch adds new fourcc 10-bit YUV formats with 4:2:2/4:4:4 sub- >> sampling. >> Second patch adds support for displaying the new fourcc formats. >> >> These patches have been in use by LibreELEC and other distros for the >> past 3+ years, hoping they can be merged this time around. >> >> A rough libdrm/modetest patch [2] have been used to validate use of >> NV15, NV20 and NV30 formats on RK3288, RK3328 and RK3399 boards. >> >>   modetest -s @:-@ >> >> Tinker Board R2.0 (rk3288w): >>   modetest -s 50:1920x1080-60@NV15 >> >> Rock Pi 4 (rk3399): >>   modetest -s 52@44:1920x1080-60@NV15 >> >> Rock64 (rk3328): >>   modetest -s 42:1920x1080-60@NV15 >> >> Changes in v5: >> - Use drm_format_info_min_pitch() for correct bpp >> - Add missing NV21, NV61 and NV42 formats >> >> Changes in v4: >> - Rework RK3328/RK3399 win0/1 data to not affect RK3368 >> >> Changes in v3: >> - No changes, rebased on next-20230616 >> - R-B tags was collected >> >> Changes in v2: >> - Add NV30 format >> - R-B tags was not collected due to NV30 changes >> >> This series is also available at [1] and libdrm/modetest patch at [2]. >> >> [1] https://github.com/Kwiboo/linux-rockchip/commits/v6.6-rc7-vop-nv15 >> [2] https://github.com/Kwiboo/libdrm/commits/nv15 > > Could you open a draft merge request for libdrm upstream at > https://gitlab.freedesktop.org/mesa/drm pointing to this series? If there are > subsequent revisions of this series, it'd be great to link that merge request > in the cover letter. Have created a draft merge reguest for libdrm/modetest changes now. https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/329 The pattern code could really need some improvements/refactoring, in current form it should at least be enough to create a test pattern to help test/validate this series :-) Regards, Jonas > > > Cheers! > > Chris > >> >> Jonas Karlman (2): >>   drm/fourcc: Add NV20 and NV30 YUV formats >>   drm/rockchip: vop: Add NV15, NV20 and NV30 support >> >>  drivers/gpu/drm/drm_fourcc.c                |  8 +++ >>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 36 ++++++++--- >>  drivers/gpu/drm/rockchip/rockchip_drm_vop.h |  1 + >>  drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 66 +++++++++++++++++---- >>  include/uapi/drm/drm_fourcc.h               |  2 + >>  5 files changed, 96 insertions(+), 17 deletions(-) >>