From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4312DC433FE for ; Thu, 10 Feb 2022 20:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344381AbiBJUwI (ORCPT ); Thu, 10 Feb 2022 15:52:08 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344336AbiBJUwG (ORCPT ); Thu, 10 Feb 2022 15:52:06 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C814010B8 for ; Thu, 10 Feb 2022 12:52:05 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id e79so8909863iof.13 for ; Thu, 10 Feb 2022 12:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZDmTcXbfCgXu5awEkEkH5h6M1B7QYIk5NA43T9cuepo=; b=gxHVZlPIYOHcQPLsLrfHJVOy+4sm5LiddBbY884K3dpEMzZVGPqLXx8cPls3wtGXE3 T4KPGCLxJG7ZefY+MDFO2FYShWKMsTqbUUKXkOogoNUCmMBOcim8TauHAL1cEN/Di1sa E9Sp2Rz/bXncSrKDa1xsmtUGNe1p21Z1AAHiU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZDmTcXbfCgXu5awEkEkH5h6M1B7QYIk5NA43T9cuepo=; b=egvkSec3LEE54HaXGNCqv9M+jYSW1Rw/RaDjqNYMnAJlk2J9OJJk0v1LZ9+26DjhRN d6i3NPnrggyTK1EiC6TP9G6j1h7RzG7JgRU4Zc2uwt97RO7oKnnBGVgB57k/NeWPWKGR 0lAjw33W3KIYCIkKyx6AwSKiUUDBxscx6zSUTiPIEVqVVeigItuxUIscOc0y2xxENSM+ +ppLmi5s+Dc2nxGlRhSUUxBr9sUgMFJTCki7FNprFO/N069jqYs0MoD4yNBVtSXDgpoO zWPBzdJBg97xe4C3yx5H7LYaaXlxZJ2quHk2lpc+dNtE/jx7v5M+z7pHAsJ2uzuhcc4a hypA== X-Gm-Message-State: AOAM530kJiNNzKyAtc+Ku8B6wNP57vRXXW9gZHNobgzPZbN2nZmUMAeN KdwGAnOgtTlvmbvrvz56XtJh9g== X-Google-Smtp-Source: ABdhPJzrz7xQPZCYP3BEuJcYIkGZ8gXDQZXXiBB6HqpqMPptfSV1nxX3Wnr697ep6+rpXCCFXzHaCQ== X-Received: by 2002:a02:b0c3:: with SMTP id w3mr4709002jah.37.1644526325191; Thu, 10 Feb 2022 12:52:05 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id l6sm7179414ilt.16.2022.02.10.12.52.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 12:52:04 -0800 (PST) Subject: Re: [PATCH 2/2] selftests: sgx: Treat CC as one argument To: Muhammad Usama Anjum , Jarkko Sakkinen , Dave Hansen , Shuah Khan , Andy Lutomirski , Borislav Petkov , Jethro Beekman , "open list:INTEL SGX" , "open list:KERNEL SELFTEST FRAMEWORK" , open list , Shuah Khan Cc: kernel@collabora.com, kernelci@groups.io, "kernelci.org bot" References: <20220210190642.1477814-1-usama.anjum@collabora.com> <20220210190642.1477814-3-usama.anjum@collabora.com> From: Shuah Khan Message-ID: <2e40809b-fb03-24cb-d68c-c89b464be39b@linuxfoundation.org> Date: Thu, 10 Feb 2022 13:52:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220210190642.1477814-3-usama.anjum@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/22 12:06 PM, Muhammad Usama Anjum wrote: > CC can have multiple sub-strings like "ccache gcc". For check_cc.sh, > CC needs to be treated like one argument. Put double quotes around it to > make CC one string and hence one argument. > > Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX") > Reported-by: "kernelci.org bot" > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/sgx/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile > index 2956584e1e37f..75af864e07b65 100644 > --- a/tools/testing/selftests/sgx/Makefile > +++ b/tools/testing/selftests/sgx/Makefile > @@ -4,7 +4,7 @@ include ../lib.mk > > .PHONY: all clean > > -CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh $(CC) \ > +CAN_BUILD_X86_64 := $(shell ../x86/check_cc.sh "$(CC)" \ > ../x86/trivial_64bit_program.c) > > ifndef OBJCOPY > The intent is testing if $CC is set. Does this change work when $CC is not set? thanks, -- Shuah