From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B549D33EAF9 for ; Fri, 12 Jun 2026 08:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781252806; cv=none; b=jDpkkfsEp2FT7Z0XZ8I9T7+fJzx89lFU4oPGpNPydHObd5F88vfsON0XwLSaJnIqe6i0o6h0B4hlziJLhxtWBBO2Sh+pLsdonxsoKoxlLbIN4PpQveANbP2C59B0xBdKUPNajUJjk8VdulQpUbQiTTMpnBzOrkFS9ttLUxkmbVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781252806; c=relaxed/simple; bh=i0FCGxfW6EIkm/NxdX2agFSlgFexjBEa7DfpTa7qLzg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rtoP0lFENMFVAOftShWE9zuJWtcyA5QtR9D0O3wuuvaVcd4lt2Ck36PSBTztnyEAfTGnrE8wHPbbOoAeg+NZHdSZtQBuZlf6/oA0+ASmlge5cJXFd8aiBlamnymgRiVsvcwK4o9tGJgIhw2ifhp7dGiYKSrZfzgxHisl8jC22Lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J9g+rIf8; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J9g+rIf8" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-39666aac20cso5082241fa.1 for ; Fri, 12 Jun 2026 01:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781252803; x=1781857603; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ly5vjKzyUMJaReNr7K0eOrfFESrcjSA7hgv6nlsIrYc=; b=J9g+rIf8tW0sxMJqCtE+eGOjNKJ19rxRNE1Koyi4O5xqjegQliP06DeN8Rv3AXyMqR tLPIVhhioPaHptVTVzhx0km5Q8hZn0BMctodNki6U+wugUecgfb8Y+UCy6/I1orlysbm QE/PJZvt3jho5GVRY/xxPSNlSutPWobUAlUpxuXU0mQJL/RsFNzJ2mh/plqAG/Z+H3LX gvqZk1h2G2qLKEzoYKXCNGjzOLcdCwSvjKNXKVMc3qXncKu5qKgpj+RGEENQOBHSuXAG sabKFyW8ZoJRs9Tpe/FQ4yxEnhETgehBz1A3kTtjPJiTLI9m3nQmsDQX5kYfn2Ueh8to TK6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781252803; x=1781857603; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ly5vjKzyUMJaReNr7K0eOrfFESrcjSA7hgv6nlsIrYc=; b=Zi4hErMyJNMDHoXgp/vltYBt21vVIL6zvv9rgKVCrrHLJyss6f4lIva3UAij37peBH awfXHx6mm2vKLACiYct0toohXtf1u3RL0m94wGkgj/JKbtJbwuzZou2ITDRf/v1fSBLy 2VDcVsS8mi/VMRwaDNXoOIdw9G12K2Y8O6pdhqECSXfElWX60u1YQnDBQy8duttE3RaV pJSMtW1fNp8v3e95ENSsyxrlPDJstVkDtiMIgVUVeGvc7KmQiNmwzwk0KPZmPAeSrrJ1 /lxM2kInnZvh/SEHbtn9muCWlNkctzqQN1WGxrCItFjPOOtofsQqm3+yZcyYQn5r2LfC hLgw== X-Forwarded-Encrypted: i=1; AFNElJ92oV/U3XD1mCl8Vol9SQGiIezYkddRn/s8ICnckF/jrxmLUCjolupW8OsJtgE6PSpoUSpApclzkxIb2KM=@vger.kernel.org X-Gm-Message-State: AOJu0YwESrr9VGcuuVmMpWDpVeOIDdr2+W8E6UWVRae/0k6FLi6j09v9 4rO1RE/Tmkxrg9RDsloiY+yk0lqXVOOUF9fxxUEZk7RrU4gTltXScPvC4aJ5Gka/ X-Gm-Gg: Acq92OHx1zlOrNf0PjCZ30Ua7SH4hI5tUELmp1lsNKlAI9BG0GVQUIE9OAhTBwYtJsk NtBt6CQqV4QBHl3iSCtUJlS+fQ8aifzDXyowBbpE+NJNwi0URrY1NK27ZWMSJB40LIXWl7Mosjj /kmWYkRLw/c4TI3AQQhwf0wfUJmHwFW5m4DjC5Nlq11R//aq/gNhXlZwh7HZ0RUHcGqZVwIEY2E swkIpXsRIcfgVj44Bkm+6w/59zEwjyRQmQWOeGkiEHiV8Jj04pBCP7CwA4+feYiqtKQ9sq+Ho04 +lews/jJ//7aDpHv56ZckMBw9VPbuBkeo+7xWyWIR8vvz1wyFCdSoBg79d5I0G9ffHBA2RteFqd 2ZA1gn5Vmimu+K9mibsC0fw0UQV2KPI37vizFCUde2KxpseXkhaMMxvenVLUkCDV8PEDvMXjS2n hJ3uZIfax5p+cXDZ1kG+bhLGVgxbDFV1+ymxqCjM4MIWhLcsFzjBnJmQvVRL2EeO1Sw5PMaHQTm NzkFuWyqxVQkpKJXkY= X-Received: by 2002:a2e:be2b:0:b0:393:5920:2c5d with SMTP id 38308e7fff4ca-3992b2b21acmr5598261fa.28.1781252802533; Fri, 12 Jun 2026 01:26:42 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39929c29bc8sm4204741fa.6.2026.06.12.01.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 01:26:40 -0700 (PDT) Message-ID: <2e4375cb-15b0-46f8-bf0c-da077f592056@gmail.com> Date: Fri, 12 Jun 2026 11:26:38 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/2] rohm-bdi718x7/71828: Use software nodes for gpio-keys To: Dmitry Torokhov Cc: Lee Jones , Arnd Bergmann , linux-kernel@vger.kernel.org References: <20260611-rohm-software-nodes-v5-0-0244664a3b65@gmail.com> <075d48b7-5cb2-43a4-aacb-e11a9ac916a5@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/06/2026 08:09, Dmitry Torokhov wrote: > Hi Matti, > > On Fri, Jun 12, 2026 at 07:40:49AM +0300, Matti Vaittinen wrote: >> On 12/06/2026 07:38, Matti Vaittinen wrote: >>> On 11/06/2026 18:48, Dmitry Torokhov wrote: >>>> Now that gpio-keys can use platform resources to identify interrupts >>>> assigned to buttons we can convert ROHM power buttons to use software >>>> nodes and device properties for configuration, removing the need to use >>>> platform data. >>>> >>>> Signed-off-by: Dmitry Torokhov >>> > ---> Changes in v5: >>>> Addressed Lee's comments: >>>> - moved static constants out of function to module level >>>> - added #defines for nodes' indexes >>>> - adjusted error message >>>> - renamed "error" to "ret" >>>> - dropped unneeded comments >>>> - Link to v4: https://patch.msgid.link/20260427-rohm-software-nodes- >>>> v4-0-ffeb5b0c4774@gmail.com >>> >>> I think I did already review these? Is there a reason my tags were dropped? >> >> "These" referring to these patches, not the v5 changes (which seem minor to >> drop the tags). > > Sorry, I decided to exercise caution and not carry over the tags. Understood. I think there is no generally accepted "golden rule" when to drop the tags. I just personally prefer keeping tags unless there are functional changes. That helps me avoid going "Deja Vu" -reviews. The patches look good to me. >> Furthermore, is there a reason I was not CC'd? Especially if >> there was a reason to drop the tags. > > I see the following on the emails: > >> To: Matti Vaittinen , Lee Jones > > so I am not sure why they did not reach you... Ah. This is 100% my bad. I was only checking the CC-field. I need to fix my filters. Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~