From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 071A1403B04 for ; Thu, 11 Jun 2026 15:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781191297; cv=fail; b=AK6a3zI9KXlHymuYQCTQqkc+weLmjI22vqBU2EuJW2JcgjkzidWgqGAmVWRBKpp8gdFG585cD9sQDf7hsbeWnQ5K7h97LVJA4HyJx/OkL3OEkk706D7NZvxRTW5NXdQl2yJf+OmzoVtbnCOzT4Sbbtk4NG/gSmYgbrVhduWg6+w= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781191297; c=relaxed/simple; bh=idVdOeeIOz9VTlA1jWA+mSplXKbcS7I/iwVxm7zYCVk=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=S+87djf52G27Ay1AQrfhAKZb7txENz8+gSl03ieZY5H6l7mOJEecWFF4yYUIzXDfP+91IxBSMtDLP3yqAfSeBB7uwtLDwKknOGLUV2G0nMieeCxeZ/1Eixlk2xJNp83FNDnB859lupN6Ayr0um4MlNqN9AM0vZldlDyoA7sZSrQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Jiz5TsUJ; arc=fail smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Jiz5TsUJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781191297; x=1812727297; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=idVdOeeIOz9VTlA1jWA+mSplXKbcS7I/iwVxm7zYCVk=; b=Jiz5TsUJZCWRQgeGa6lgfV5xa29XZxqmVZGeWE8Zs9nSBN71oYDCTWvm D4yBOWK+ONPtQr2sbjqhixfxyqGNwB+LuFgGZ/tyRNf7r43q6r4vw6YqY uqmVfgGze9Tm7Z09YyZe4SCHMKxWyYv5Cvv2oRr0T49cGD6x2H3zMqDUT tXv0j2HU38p+I6tU4jqveJ7Otz0opkr0BAPl3q6B0LHlfwdZrGC2ryaYm usa86lq0rUlmK2o/aBp/NRWLvEyCVgwUEU/dkeSP3yGFRQZ3l12ImjJnt VdevIESRHaHtJVGPSTvaoXwbB0/PWYw1UrF59zip06P1AIusHyfuadw2T Q==; X-CSE-ConnectionGUID: fMA+rhGmQ96dZS6S5WXWEQ== X-CSE-MsgGUID: oAFgh0xHSIqa8I9cSG3NQg== X-IronPort-AV: E=McAfee;i="6800,10657,11813"; a="85847206" X-IronPort-AV: E=Sophos;i="6.24,199,1774335600"; d="scan'208";a="85847206" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2026 08:21:36 -0700 X-CSE-ConnectionGUID: LiTpyX7QR9C6sLaGi/vz+A== X-CSE-MsgGUID: Z7XL1U4gQyaEOmM1U8k3oQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,199,1774335600"; d="scan'208";a="250790898" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2026 08:21:35 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 11 Jun 2026 08:21:33 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Thu, 11 Jun 2026 08:21:33 -0700 Received: from DM5PR21CU001.outbound.protection.outlook.com (52.101.62.16) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 11 Jun 2026 08:21:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hK2p45BKkn+8xmOkQtIcHP4W4WonyviTGXep0/Vs8/k98qYzKMbpEB/psUsITdZnFoVyb4WfsFF8xhfGJVuwGOUFgUmtBkrLiIJqQ+aAog6CI/CRkzOKdQs8hwaTQQhLKhq/Jm+V8e1mE4i+3b2e8OVtdYgi7aWCMlfzo/UQ5mrrlDcxIja2/YQrr5H9pImB1PKASnrCAuYVAHY5g7hDlPiH2FFZ+uP9KYZiz3eCWM1Rp+cSXojUbRo3Vnpptv5LHV2hmYwwE/UWndsGQGKSv3BqUHgJtB3tJR1HrGGK30hHD6B3x1bQ0JZDm5+suQA/ooDyqDDgBtZ6l6kcEg8MBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=udmkahC1QWJ7RU6e2JjQH/5df2G1NKLwzItHnoutosg=; b=REqt7cTokDe7hh1wCBd8a7vVcGfWZBsFIxZ+cUzYXNDo4KHtQvHh6zH7sCIHXxhahPiwVPjwWHLzx0ZzjuF0ETfbP3e8Pex7zPR5iGfwbUX393Ak0PCHvdV4ZXVB+jo2DODYiYWs6v9xwsI4uuzSI/Kj/WuZqjHwplZ24xrEK6mf8B80tezRxuk81HssozmFklMvskY29PWZt/CKnxdVioCauZ8Q32KWQB4M2jKB7v09pFX7X2QvBycoC1npF5NHxxwCl9j9vUX+t4Qha0aywVd2yw5nlg1z1dAddFk0spcHm37+z9hHR5JyonBhZGV/HfzUesZdHuzKXv/75xTcwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by IA4PR11MB9444.namprd11.prod.outlook.com (2603:10b6:208:563::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.12; Thu, 11 Jun 2026 15:21:30 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%4]) with mapi id 15.21.0092.011; Thu, 11 Jun 2026 15:21:29 +0000 Message-ID: <2e43c776-c43a-4c29-bb2b-dc5faf5febd3@intel.com> Date: Thu, 11 Jun 2026 08:21:28 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [BUG] resctrl: using smp_processor_id() in preemptible code in __l3_mon_event_count() via mbm_handle_overflow() during CPU hotplug To: "Luck, Tony" , Qinyun Tan , "x86@kernel.org" CC: Dave Martin , James Morse , "Babu Moger" , Xunlei Pang , "linux-kernel@vger.kernel.org" References: <20260611071847.1552322-1-qinyuntan@linux.alibaba.com> Content-Language: en-US From: Reinette Chatre In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0172.namprd04.prod.outlook.com (2603:10b6:303:85::27) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|IA4PR11MB9444:EE_ X-MS-Office365-Filtering-Correlation-Id: b790951b-f5cc-4014-242c-08dec7cd1cb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|23010399003|56012099006|4143699003|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: t7vVXD2iacc/9MYCr7anhzRSR3ndzQml6cg6gw6VJI3ttPYWW4Xc/3Ocz/rCzMxCSHLT7hE9PG7CRfhmSigNVVsM9EtB8hzWhO5RLaIFJemxwxhpNiG1Hh7MMjKb/BBfmU3msBC6xgUNQ7bmLUK8XNmiImiD0QlLY4h7gyi6VEU/w5rETJ+95020WhM0oUy7F7oNhK7Pnr+/nI8lg8p+dpfKkd4LMLiklYwWE0rf/xk/SZdEevgJCfy+dZUKjISdNPVe6cJ6Eohwf5S9JDh4K3lBFaiE0wu2HT2qnNk48MQ8LwgpNcZ1EUweZfnNYMS2tt866wBq+tSCoILLAeeFrtibzcWmVVDUEOso5g7nzG4BgrgKQMqfMctuEZIFJ7XWQy5g28IIbzl27vPov6QUs+5lvua6H7vs6E6YZ0zFArIYAg3W8yj5cRTpCtR7vI9F3cjOx6Yw5P2xZJ+AcJ5FWbWW8HB6uHrxGkTBP39mQrCithCpPPgP6oBV05VtFIVzJrRnueCxNh2a7Bf75P7ZFjdCi5HOwoErBQ+ysdlcgy6dSgpHceo39eA12Sr/v8i4nBoaavkmkCBx93JIgd4GiZTUPzpJDJKrm+Gte9x4tLKeHZbx+1Iomfb7+JHLrMcPc6ABx2fi+dncSH6+c4zeZ5+1tihT5jCz37lYo4knjey8NRaLJLk5D08Z2lAlMpHj4hskOFRZgva5zZldctmSWg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(23010399003)(56012099006)(4143699003)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3RzN05pVGppMWhYdE1lbTFyN0hiemR1SjdOQmVUQlRrVC9LS0FINTAybjZx?= =?utf-8?B?MW0rZ3pWTDRXOHU2UmtyVWtMcmNnRzFKMGlEZWtQZS9DQzlxNXpPVko1WWoz?= =?utf-8?B?MzE0TUxwZ1RLc1RxUGFUdFR3aEs1V1d4MlJvbnBRWnV1ZzlWNXBzSTdOakpq?= =?utf-8?B?ZUsvM09wTTFHZEVvajFZd3RJdmdod1Vwek4wWVpXWlJJeHI2bXNIQW9QRVVG?= =?utf-8?B?WkZoY2ZMNWphbHM2OHhNdjNPeFY4b0pmcmRuVCtpTTZNS0xzOWpCdnZhOUdE?= =?utf-8?B?OXRWamZFbDM5eXc3MzdaL2h2aUNmaC8za0ZYZ3liRTJJV3g2YkREdWRXU0wv?= =?utf-8?B?V1NROUxLNnh1SHBtQWlKUVNHYi8yUHJYeHJDbkJzVHZEck5Uc0d6OUxvSlNh?= =?utf-8?B?eXQzL0xkdDFjTGtvc2FUaFEyT2RGU0E0Q3dsUTlScER3TEg1T0pseVRjRWdR?= =?utf-8?B?M3FGbmN4YnM4VkhRYk5CTkhSREZrMXNDblhUZm9Vbmp6Qm5pTTQ5cXBRL2Vz?= =?utf-8?B?LzV6eEs0Nmh4cHFIYSs4L2U2ZzAraHJWK2U2NElUVzRDd2JYUTE0OGdtK2hI?= =?utf-8?B?TmlKK0x1V1RQV2NtbUZoT2NJN0YwbGg3TWNjZXYxSWNrMHl6L1RlTEtIcG1z?= =?utf-8?B?dnUzclErNnQ5Q0dPZE9Xb0hwZ2Q0N3RJakZkQzMrREZCZnp6SHdMQ0RGRkVp?= =?utf-8?B?N3ZYRmR3dHBKWStHSHgxbENZWTVBMVZLTFJBM05yQm1ISjlNdzNyaU05YmFr?= =?utf-8?B?eU8vZE8rVHorTE9xM0ZXQzZLUFVzS1M3K1diN2NNRnNaQUtOeXYzRzlMNnZV?= =?utf-8?B?cDJKOFQwSmk1b0xwT0QyTmhLQlJvdWFubjR4WVZzTGVzb2pVTkM0WXcxdGw3?= =?utf-8?B?ZWp1NEhXYjRwOFQ1ajNsejEySnV1NDJjTDF5cWNWK1djTUt3UmV3VGJ5NG5q?= =?utf-8?B?Z1dTYWNrMFo3c0d2ODQ4OHpqamVFYjFrazBPL3J2bEErMzNUNUZBWlNzMG94?= =?utf-8?B?SUlqL2IwSU5kVndvRGF3d09sMGRIcTZHc2JDN1RUeFRYTUs0OTQ3Y051MkJK?= =?utf-8?B?UmNLTlRuY2RYMlQ2eXZmUmYzZ041TUZHdWs1WUczcW9xWUxleUJzeUFUQkxw?= =?utf-8?B?M1VzNmdoL3FrcWZtMFRsenZWa3dxSlp5Nk1XQ29UQ3VDUXBwZGVFTXR4VHVR?= =?utf-8?B?YUM0djlGQm5MUlVVeU05R3ZKOUkwb0RzenpUTkNVQVJwV3BTREZuLzA1cjFT?= =?utf-8?B?MlBTdmprYVhYMFM2dEtVNmIrZ212aXA0dDZvQTNSOXBQNi9Sc0hqV3NXQVVV?= =?utf-8?B?aDgzVDhxK2hoZHJIWE5uQTQvNDB1czlrNSs4a2plaTNRMzdKR3BZTzN1ZUg5?= =?utf-8?B?c0VTQWkrNTRST0ErNnVsMWNtL3gzZCszS3g0NUlKdWs2UG5VajlZaXl2MHhM?= =?utf-8?B?VXFEZnZhRUsyQmNmQmltUzhZQ2M4ZDdoUG5NeWprTkZBa3BxRzkyTnZEMmdM?= =?utf-8?B?ZkNCY3QyK0NIem1oUUZkd1BzYzA1WlhhdFVNZlNCd3dld3RFc2xTdlFyS0gx?= =?utf-8?B?TmphbmtueG5YeHZhcEkvRGVjYk1GcWp6N3NQdHJ2cENrTjBmMUw2d3lnY1h4?= =?utf-8?B?R0FYQUFHQUZRMDlYTmFUSkM3MkJnbWFxZHJmOVpVWE95ejNtNHFteEVJbVJ5?= =?utf-8?B?YnAwajdnbGhmMUhIMVJnZlFLR3poQ3d5eGthQXhxOXJiMDg0RkdwNDV4Y2kz?= =?utf-8?B?SjBmc3kxamNvd3g0VzI0UHFUaDlGQTlYMzJUODB3aWJqekhKdk1YNDdHd0hz?= =?utf-8?B?RnlQNHJNVUM0QUVOOUZzaG1JeFdVeE9lUjZmTG9iUGp0RmsxVExoM0lxSEU2?= =?utf-8?B?dzdMWjI4aVZUbEc3MkZjbmxWaXBsdXM5czhXQ1hCYWN6OTJEVGNsOUpMeTBF?= =?utf-8?B?dDZheFpHbk15YVZheU4zSUJNczhseElkT1FyWnVNOU9GRW1YTmVDNENRQ1NQ?= =?utf-8?B?U28raUhOR1BOejlNQnJlZXJhd29jTlJTNVlJRVlBdmxJeDQxWElSMGlGb0Z4?= =?utf-8?B?WStVaDcwNDA1dGxBeHBTZDBneEVaQXBTb3hQY1lZOEV0cFhGVnZsUnM0UUJO?= =?utf-8?B?VmkzNFZQeVNIVjBOS0dCSkVLekU2SUtXT0huQ2FXNXd0WTZKa0t5MHU3MkVj?= =?utf-8?B?TFZVdUhNWnc4OHExU3B3MzZUZXduVTVKNG9UTmgwclFORFhORk9mSHhQc0k4?= =?utf-8?B?a21KNWYyRjRGenRJUGZhbStFTzdRN1hyUzQ2UkNnZ2c3eVNmb0htdW5hY1RP?= =?utf-8?B?S3lHRHJjdW5FL2Q1ZUlUeWRKSzZiN21KNG5CLytpd1IzZTZEc0FVVTdqZVZQ?= =?utf-8?Q?fab3cjlstubeo+4Q=3D?= X-Exchange-RoutingPolicyChecked: n41F42kRZvFkWJIWhEPXdf0aSYUsc+tPZ3j/OK7Q1GRStyDej9egIeQfQMTaFv+P/9eyW2I33slNdWo6iGgCtjiMmXYuJec3TpMeQAB92lz30lMwWoNrFqj8sS8tUQXTqmYdB64K9Q3HlxxMM2VYRDMYKLS8U4Lc7hGVotRKPFxs57Ji0S6E3PNsQgr76f4NDbHgDlP3LESx4WOykr6DEuODj+9r+wBoXPDJU0vLRphcn1sG8YwRrqzEgdwFBCvKF97YuujiP9X/5BUKwBhNaEmjoROoKbTOE2cuX1EaftSqiQhFXMTUfkSKwfnJwsAVxhUwkAbFk5ODIb9dVqET7A== X-MS-Exchange-CrossTenant-Network-Message-Id: b790951b-f5cc-4014-242c-08dec7cd1cb1 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2026 15:21:29.8547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NlypVWb371B8C4PHbrAo7s7pNknWcPRG19LLiNOVdjLeRTJgJZFMp4uyQmmdQB4NdkabfdS6Zm9LnhyrvSGm58+OFOP/Bf/TeHUc8CLTLXs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR11MB9444 X-OriginatorOrg: intel.com Thanks to Qinyun Tan for doing this stress testing and creating this detailed report. On 6/11/26 8:02 AM, Luck, Tony wrote: >> I do not have a good fix in mind. The read in __l3_mon_event_count() >> fundamentally assumes it runs on a CPU of the domain, but during hotplug >> the overflow work can be migrated off that CPU; neither the cpus_read_lock() >> held here nor the existing cpumask_test_cpu() guard addresses the >> preemptible-context use of smp_processor_id() itself. >> >> I would appreciate your guidance on how this should best be addressed. >> >> I can provide the full log and a reproducer on request. >> > > Qinyun Tan, > > I think this is addressed by this pending patch: > > https://lore.kernel.org/all/b5178a191a8a660e1f4aed356484d4eebfbd30fc.1781029125.git.reinette.chatre@intel.com/ > > [At least the scenario seems similar with CPU offline and subsequent unbound run of a worker] Indeed. That patch modifies the resctrl CPU offline handler to wait out any existing work. Considering that the resctrl offline handler runs before the workqueue offline handler I thus expect that this change would ensure the work completes on the CPU going offline and there would be no work left for the workqueue offline handler to migrate to another CPU. This same patch also adds an additional protection within the worker against this scenario happening by ensuring that when the worker runs it is still a "per CPU thread" so that it can be assured that once it does start running, smp_processor_id() can be used safely. Reinette