From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2E9C433ED for ; Thu, 15 Apr 2021 08:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B64FE61166 for ; Thu, 15 Apr 2021 08:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231518AbhDOIZl (ORCPT ); Thu, 15 Apr 2021 04:25:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51251 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231215AbhDOIZj (ORCPT ); Thu, 15 Apr 2021 04:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618475115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/bQmWZhJFBGurEcgsfC0EuOHiXGG/UZMr42BKHCg0CM=; b=FrLbKiWI78+iV+MeIABfx+K9zAaRG/DDZJY6QU8LGlMryR2JBVkthmbJWj0GSj+fyfxu1w kCoD4Jofj26FBTwiLgkIoqTirJOGbYiH9fKKAYiCJPDTeOJ2CR423ZNrzaFetgEubFODyr RsvI7E0cksB0klAXaN6FDIZrz35Z4eA= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-MmHzXUJqOXmNGosXnVpltg-1; Thu, 15 Apr 2021 04:25:14 -0400 X-MC-Unique: MmHzXUJqOXmNGosXnVpltg-1 Received: by mail-ed1-f69.google.com with SMTP id ay2-20020a0564022022b02903824b52f2d8so4779686edb.22 for ; Thu, 15 Apr 2021 01:25:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/bQmWZhJFBGurEcgsfC0EuOHiXGG/UZMr42BKHCg0CM=; b=Ag1cbqe1wzTb+ru6FsEyiOuiskuDDJq0nvgsYGCtJeomFZphf19stHq4mSOEpaCNq8 2uuBrtGkSZPFmaOFuziziYpKPSZLNhQD/TMckSwbGohAAormLGFWuVFANR+mIspr59r7 11L38dUrxut2kj7ACcgIAK4ZrloPJra6r7ntrfWfFFatJqllytxY5+b0Ewj6etl5okjj qAddKWMfcI+C6vO0NBCbdb5Ua/ehY186bIOlDq39VWEL910IwAhXiGiJNbsqQ0a/DADl l4JmtP58xaP5i9PdaJ4p9jWJ9jArdARYDrrIGn1DqwqPO+JNp7usNvoo2R85WVrMOYvd RSFA== X-Gm-Message-State: AOAM5329y/Osx1a0/XUzoQ+JZoElGpH1srgyVL1+VHBtbSgx95CTVjAX 3p0Wkfh6UpdjXycWNR6urgFJqA750s9CCaN+CqfMYi4FhJ9Nh5enNVzw5yxzl7WqwiBHDXVuJ9h c+FvWSMyD1rSVG64iu3TOYdhT X-Received: by 2002:a17:906:fb90:: with SMTP id lr16mr2188965ejb.173.1618475113127; Thu, 15 Apr 2021 01:25:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwV9d4Hf8P/msHacfoZkJ3KBX3z8yqEirLBflCXrob29FKDQvETDro/hTdN8fxJUXyuYv/GnQ== X-Received: by 2002:a17:906:fb90:: with SMTP id lr16mr2188956ejb.173.1618475112977; Thu, 15 Apr 2021 01:25:12 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id bm13sm1380535ejb.75.2021.04.15.01.25.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 01:25:12 -0700 (PDT) Subject: Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include To: Masahiro Yamada Cc: Linux Kbuild mailing list , Janosch Frank , Christian Borntraeger , Alexei Starovoitov , Andrii Nakryiko , Benjamin Herrenschmidt , Daniel Borkmann , Harish , John Fastabend , KP Singh , Martin KaFai Lau , Michael Ellerman , Nathan Chancellor , Nick Desaulniers , Paul Mackerras , Shuah Khan , Song Liu , Yonghong Song , bpf , clang-built-linux , kvm@vger.kernel.org, Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linuxppc-dev , Networking References: <20210415072700.147125-1-masahiroy@kernel.org> <20210415072700.147125-2-masahiroy@kernel.org> <9d33ee98-9de3-2215-0c0b-cc856cec1b69@redhat.com> From: Paolo Bonzini Message-ID: <2e46231f-1d30-6a6f-c768-f34295376d0a@redhat.com> Date: Thu, 15 Apr 2021 10:25:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/21 10:04, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:40 PM Paolo Bonzini wrote: >> I think it would make sense to add try-run, cc-option and >> .DELETE_ON_ERROR to tools/build/Build.include? > > To be safe, I just copy-pasted what the makefiles need. > If someone wants to refactor the tool build system, that is fine, > but, to me, I do not see consistent rules or policy under tools/. "Please put this in a common file instead of introducing duplication" is not asking for wholesale refactoring. Paolo