mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
	Clemens Ladisch <clemens@ladisch.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	"ffado-devel@lists.sf.net" <ffado-devel@lists.sf.net>
Subject: Re: [PATCH 3/6] ALSA: firewire: constify snd_pcm_ops structures
Date: Fri, 2 Sep 2016 08:28:47 +0900	[thread overview]
Message-ID: <2e4b67ec-6e8d-b499-06d3-910f6413e3fd@sakamocchi.jp> (raw)
In-Reply-To: <1472767994-26269-4-git-send-email-Julia.Lawall@lip6.fr>

Hi Julia,

On 2016年09月02日 07:13, Julia Lawall wrote:
> Check for snd_pcm_ops structures that are only stored in the ops field of a
> snd_soc_platform_driver structure or passed as the third argument to
> snd_pcm_set_ops.  The corresponding field or parameter is declared const,
> so snd_pcm_ops structures that have this property can be declared as const
> also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

I've realized this issue and will fix in this development cycle for 
Linux 4.9. Thanks for your continuous effort to reinforce software for 
better directions.


Regards

Takashi Sakamoto

> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct snd_pcm_ops i@p = { ... };
>
> @ok1@
> identifier r.i;
> struct snd_soc_platform_driver e;
> position p;
> @@
> e.ops = &i@p;
>
> @ok2@
> identifier r.i;
> expression e1, e2;
> position p;
> @@
> snd_pcm_set_ops(e1, e2, &i@p)
>
> @bad@
> position p != {r.p,ok1.p,ok2.p};
> identifier r.i;
> struct snd_pcm_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct snd_pcm_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>  sound/firewire/dice/dice-pcm.c       |    4 ++--
>  sound/firewire/digi00x/digi00x-pcm.c |    4 ++--
>  sound/firewire/oxfw/oxfw-pcm.c       |    4 ++--
>  sound/firewire/tascam/tascam-pcm.c   |    4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/sound/firewire/dice/dice-pcm.c b/sound/firewire/dice/dice-pcm.c
> index 4aa0249..6074fe1 100644
> --- a/sound/firewire/dice/dice-pcm.c
> +++ b/sound/firewire/dice/dice-pcm.c
> @@ -302,7 +302,7 @@ static snd_pcm_uframes_t playback_pointer(struct snd_pcm_substream *substream)
>
>  int snd_dice_create_pcm(struct snd_dice *dice)
>  {
> -	static struct snd_pcm_ops capture_ops = {
> +	static const struct snd_pcm_ops capture_ops = {
>  		.open      = pcm_open,
>  		.close     = pcm_close,
>  		.ioctl     = snd_pcm_lib_ioctl,
> @@ -314,7 +314,7 @@ int snd_dice_create_pcm(struct snd_dice *dice)
>  		.page      = snd_pcm_lib_get_vmalloc_page,
>  		.mmap      = snd_pcm_lib_mmap_vmalloc,
>  	};
> -	static struct snd_pcm_ops playback_ops = {
> +	static const struct snd_pcm_ops playback_ops = {
>  		.open      = pcm_open,
>  		.close     = pcm_close,
>  		.ioctl     = snd_pcm_lib_ioctl,
> diff --git a/sound/firewire/digi00x/digi00x-pcm.c b/sound/firewire/digi00x/digi00x-pcm.c
> index cac28f7..613f058 100644
> --- a/sound/firewire/digi00x/digi00x-pcm.c
> +++ b/sound/firewire/digi00x/digi00x-pcm.c
> @@ -329,7 +329,7 @@ static snd_pcm_uframes_t pcm_playback_pointer(struct snd_pcm_substream *sbstrm)
>  	return amdtp_stream_pcm_pointer(&dg00x->rx_stream);
>  }
>
> -static struct snd_pcm_ops pcm_capture_ops = {
> +static const struct snd_pcm_ops pcm_capture_ops = {
>  	.open		= pcm_open,
>  	.close		= pcm_close,
>  	.ioctl		= snd_pcm_lib_ioctl,
> @@ -341,7 +341,7 @@ static struct snd_pcm_ops pcm_capture_ops = {
>  	.page		= snd_pcm_lib_get_vmalloc_page,
>  };
>
> -static struct snd_pcm_ops pcm_playback_ops = {
> +static const struct snd_pcm_ops pcm_playback_ops = {
>  	.open		= pcm_open,
>  	.close		= pcm_close,
>  	.ioctl		= snd_pcm_lib_ioctl,
> diff --git a/sound/firewire/oxfw/oxfw-pcm.c b/sound/firewire/oxfw/oxfw-pcm.c
> index 8d23341..f3530f8 100644
> --- a/sound/firewire/oxfw/oxfw-pcm.c
> +++ b/sound/firewire/oxfw/oxfw-pcm.c
> @@ -388,7 +388,7 @@ static snd_pcm_uframes_t pcm_playback_pointer(struct snd_pcm_substream *sbstm)
>
>  int snd_oxfw_create_pcm(struct snd_oxfw *oxfw)
>  {
> -	static struct snd_pcm_ops capture_ops = {
> +	static const struct snd_pcm_ops capture_ops = {
>  		.open      = pcm_open,
>  		.close     = pcm_close,
>  		.ioctl     = snd_pcm_lib_ioctl,
> @@ -400,7 +400,7 @@ int snd_oxfw_create_pcm(struct snd_oxfw *oxfw)
>  		.page      = snd_pcm_lib_get_vmalloc_page,
>  		.mmap      = snd_pcm_lib_mmap_vmalloc,
>  	};
> -	static struct snd_pcm_ops playback_ops = {
> +	static const struct snd_pcm_ops playback_ops = {
>  		.open      = pcm_open,
>  		.close     = pcm_close,
>  		.ioctl     = snd_pcm_lib_ioctl,
> diff --git a/sound/firewire/tascam/tascam-pcm.c b/sound/firewire/tascam/tascam-pcm.c
> index 380d3db..79db1b6 100644
> --- a/sound/firewire/tascam/tascam-pcm.c
> +++ b/sound/firewire/tascam/tascam-pcm.c
> @@ -268,7 +268,7 @@ static snd_pcm_uframes_t pcm_playback_pointer(struct snd_pcm_substream *sbstrm)
>  	return amdtp_stream_pcm_pointer(&tscm->rx_stream);
>  }
>
> -static struct snd_pcm_ops pcm_capture_ops = {
> +static const struct snd_pcm_ops pcm_capture_ops = {
>  	.open		= pcm_open,
>  	.close		= pcm_close,
>  	.ioctl		= snd_pcm_lib_ioctl,
> @@ -280,7 +280,7 @@ static struct snd_pcm_ops pcm_capture_ops = {
>  	.page		= snd_pcm_lib_get_vmalloc_page,
>  };
>
> -static struct snd_pcm_ops pcm_playback_ops = {
> +static const struct snd_pcm_ops pcm_playback_ops = {
>  	.open		= pcm_open,
>  	.close		= pcm_close,
>  	.ioctl		= snd_pcm_lib_ioctl,
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

  reply	other threads:[~2016-09-01 23:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 22:13 [PATCH 0/6] " Julia Lawall
2016-09-01 22:13 ` [PATCH 1/6] ALSA: cs5535audio: " Julia Lawall
2016-09-01 22:13 ` [PATCH 2/6] ALSA: " Julia Lawall
2016-09-01 22:13 ` [PATCH 3/6] ALSA: firewire: " Julia Lawall
2016-09-01 23:28   ` Takashi Sakamoto [this message]
2016-09-02  0:06     ` Takashi Sakamoto
2016-09-01 22:13 ` [PATCH 4/6] ALSA: ad1889: " Julia Lawall
2016-09-01 22:13 ` [PATCH 5/6] ALSA: oxygen: " Julia Lawall
2016-09-01 22:13 ` [PATCH 6/6] ALSA: bt87x: " Julia Lawall
2016-09-02  7:14 ` [alsa-devel] [PATCH 0/6] " Clemens Ladisch
2016-09-02  9:57 ` Takashi Iwai
2016-09-02 10:05   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e4b67ec-6e8d-b499-06d3-910f6413e3fd@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=Julia.Lawall@lip6.fr \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=ffado-devel@lists.sf.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®