From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CE9A236A92 for ; Tue, 14 Jan 2025 12:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736858651; cv=none; b=HgJqHe8Nohpl/6dzaNKFv3ovp3a/jExmksY+WJKjFqRNrtRoOAAvDJveJc9BQD0CMIYFNWciqHmG19KdfJ3cqCeXf2Mgvxu3m18KKxyaH3XdofI6mi1YVu83w7TT2jelBQXsp9/GmRI0WBamRjQMXMaGqc/dbVcxw9qt66ltmts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736858651; c=relaxed/simple; bh=OMKrfMlZN5TDVYArU+0YAZRjYiiWfczb/1GftAm3SMY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ZgKEBSCRbwo8WvabNVNDA8z9sCSL2lguoWZihR2RqklC+b3TLe2k0+xN/x/wodZeAv9hsAfkwOfOFpKx+Ncn7jnSwZqPGTJ9OiVLGvBwR7Im9Oe+7Ui+jhu8cxZoj29LrCZzGc+SNrnz3YmkeNofskjbJGkjnh8iosJ8ac4cPaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M6cNqlWs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M6cNqlWs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736858648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ta39/7Gq7xX5aLwxAYnRlrTh0UUs0/WJpTt34X/Rrf0=; b=M6cNqlWsYxTmJoQdNjzZGTvNyhMa4x+pchgVpY1bF9tx5O2e/MWhlFZ0wHXXzENwbFj5RR 2C2HHzagEH/o52mYKmNt4c/FiNKYxz12wI5uqgZTNZAyJpmKU8J6tmMaC/w47MD1LVy/QW jPfqXzG87hJmtKIXIRtGD2I5H5IJvpg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-Fp-4GHXgMf6tiVHu07u2Mg-1; Tue, 14 Jan 2025 07:44:06 -0500 X-MC-Unique: Fp-4GHXgMf6tiVHu07u2Mg-1 X-Mimecast-MFC-AGG-ID: Fp-4GHXgMf6tiVHu07u2Mg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38a9118c486so3362922f8f.1 for ; Tue, 14 Jan 2025 04:44:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736858645; x=1737463445; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ta39/7Gq7xX5aLwxAYnRlrTh0UUs0/WJpTt34X/Rrf0=; b=aPxB7xk7pLAUo8R6UPOeLbPoF0PvQ3Q3+jtW4L7tdm3g4sJJlugG4EAZs9vAbrCaIs fAMW5wzdnGOSMuoeg4YP76y3Sr5tPDXrcSyu7574vqFhRJmHnlb13u88Cta18nmeNo/v kzB4e1IU721rmCpmXyix49nqZkkNMOTFSkAJP81xiKgE8X5Gde2f+V6I77C0CDV4WIQz D0PyBB4mPEueZwjMG88stXxeYSxi0xcOmUz0AKUYbl0FiwsgYK7qMM4zSFFRcnDKjCpW 1exRBSskiKj+XQcj1nqv0qh8TX7/tqox5x6G5BZUdrXQovKn0jX+Mxmzn6kXx7GO7Fi5 knBA== X-Forwarded-Encrypted: i=1; AJvYcCXpppnAcEwBn5O4im+pEa3tw50980YF9sdb8FNdZWGP0wrsP4lWp+1bMSqrPERpvERNhO+zN3XFdwe9wUs=@vger.kernel.org X-Gm-Message-State: AOJu0YxoxKOehI1qXWviQQcb0RGf2qfMmcljjMYE5q4vjB8ufwQrGq2V UdEx7ZUapt6iOwuhfYaJYKgp7Cl7muQ85kFKPH/fw3zh8AoYXCJFVvHmV/cZtL11ds5RGAnoxFO SC2/vEWVZvLLFGiVKG/PM+/MLtafcyae17LLPKvGM1SmBH5/sFnucF3dqS+P2LQ== X-Gm-Gg: ASbGncvX+jQ2VkjB8bd/VQWdYAWmEQXQfnCwWFGmvhUFIPy1W4CUgRAfY3MrQCtHZmn 1NyR0NSv2d9cj6D2Hx3sV1EUs3NGadbMojUODJLDqR4nFneIfPNUox1m5IIyvzHSo/0Fa+Zb+aj jQyAHRaMj0ddEHV5Gi6dUuJ0KEplJluj2sfmKVZCUGsjCKG5JMYXdZQG6AOjNGN0V9wOGUOW1/9 HQAEXNqCX2aTs9ODUri+2ZKjFclzTwCc3wKdjk7HXKc0vf5fqsapiaKJXsFFc2Pppvw3Qnh+UAt A88C7f0/eTU= X-Received: by 2002:a05:6000:460b:b0:385:dffb:4d56 with SMTP id ffacd0b85a97d-38a87317e45mr20803707f8f.53.1736858645123; Tue, 14 Jan 2025 04:44:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IH8z2W6BEbpjKGLRHPJS/UY8AoBh/kFNQVVZ6bs77tXT63OqEK3gkw3n8/KgPqqOevuPHMV2w== X-Received: by 2002:a05:6000:460b:b0:385:dffb:4d56 with SMTP id ffacd0b85a97d-38a87317e45mr20803688f8f.53.1736858644819; Tue, 14 Jan 2025 04:44:04 -0800 (PST) Received: from [192.168.88.253] (146-241-15-169.dyn.eolo.it. [146.241.15.169]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e37ce18sm15105147f8f.14.2025.01.14.04.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 04:44:04 -0800 (PST) Message-ID: <2e4d11f6-843b-4e25-b4d1-727dc4edbefe@redhat.com> Date: Tue, 14 Jan 2025 13:44:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next PATCH v3 1/6] octeontx2-pf: Don't unmap page pool buffer used by XDP To: Suman Ghosh , horms@kernel.org, sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lcherian@marvell.com, jerinj@marvell.com, john.fastabend@gmail.com, bbhushan2@marvell.com, hawk@kernel.org, andrew+netdev@lunn.ch, ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org References: <20250110093807.2451954-1-sumang@marvell.com> <20250110093807.2451954-2-sumang@marvell.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250110093807.2451954-2-sumang@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/10/25 10:38 AM, Suman Ghosh wrote: > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c > index e1dde93e8af8..8ba44164736a 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c > @@ -2701,11 +2701,15 @@ static int otx2_xdp_xmit_tx(struct otx2_nic *pf, struct xdp_frame *xdpf, > if (dma_mapping_error(pf->dev, dma_addr)) > return -ENOMEM; > > - err = otx2_xdp_sq_append_pkt(pf, dma_addr, xdpf->len, qidx); > + err = otx2_xdp_sq_append_pkt(pf, dma_addr, xdpf->len, > + qidx, XDP_REDIRECT); > if (!err) { > otx2_dma_unmap_page(pf, dma_addr, xdpf->len, DMA_TO_DEVICE); > page = virt_to_page(xdpf->data); > - put_page(page); > + if (page->pp) > + page_pool_recycle_direct(page->pp, page); > + else > + put_page(page); Side note for a possible follow-up: I guess that if you enable the page pool usage for all the RX ring, regardless of XDP presence you could avoid a bunch of conditionals in the fast-path and simplify the code a bit. /P