From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DFF8245020 for ; Thu, 4 Jun 2026 06:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780552867; cv=none; b=iHz/Nhdj5q45gKP9nRo7/QXKi8a1aqosY/OHYo3yURFEg1jEH4tKi26lLpjt42DouQtXqFQMcz6steHM93hbpneEyLU7cnhWRH0OwvbtUSFR34zmb2IFpEUI6/4Wu1rT6N0YObsf7DwXDeKmWdD7cuOBlL7teo1tgQCGT58UC8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780552867; c=relaxed/simple; bh=MvMbsSGoBafGYAqgnlT2r4yR/KgHACSna2mBXP8Ehb4=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=lFAwkoXe7gkwe4mDgSOZu0zbLm2nkuxtsVe8w1KJov/KYkZrK7vZskzj+2AZW0vnPKGmIhWwgLWMtu1nxk11czU1sACCGym1X0yZGyD5C80EtXfarnMUAZFaf0UcsqxRqjiED3PPFVozeYSrLcilzvjk/tEmXRifggBIBZPmUT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fr82q52W; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ezDGFx2g; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fr82q52W"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ezDGFx2g" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65452Sei1039343 for ; Thu, 4 Jun 2026 06:01:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9Rxy84CQtSfLdf5SWlBRH0Dm+BYAxOch+/SAQBO+pwA=; b=fr82q52WQjC9rp8l y1YLPntQJ6LDvPOhZFNfgKMWw8M3pI6lLs3N04QggFm8IWzIrFG2h3HnB9xVOIqE XniqPWq6uuCW9kUm41E+4F8W6JtHuNZbfkBBZTU6q/aVrjBlRNfGk8P7LOBSLaV7 RDX/CL4u4OFvzHfGVCVzbSqbvlAAF8A/tQHfIt9VMkB5JQNXz17Z1vX4uvWCURqJ 69inmbiUJ2mIhcQDS6z0igVBFj7WZEFL03qybSwlsmR4EKfE0Lxd0nLuAe4DVQ58 JUiOSYrzWy88teNRTDThSA4UrNIQaQg39Fdeyq30M0OsPihyaMDWdRhkZUWZyAQj 6nIqvg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejtj8hv56-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Jun 2026 06:01:05 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2c0c36f4b76so4275475ad.3 for ; Wed, 03 Jun 2026 23:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780552865; x=1781157665; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=9Rxy84CQtSfLdf5SWlBRH0Dm+BYAxOch+/SAQBO+pwA=; b=ezDGFx2gurJgPZlnOz6bi5hn081b/S2BBYY9/xKVB6MI9O3dgQhGkYSxWZG9lTrLE2 clGKhaqfoM2fcK0rCJEK0DeLJQQp5bMepHPZDFAFwemAkHjYAJ0A6LmhodrSB5tsuz4p pfZ6Nt2mDcIsejhxETA2HJqcptozoBDEiTThrDXCltmfkh7GNWHoCPk1RFb/yzBFceG6 FS3zOYLqYsMX4Mbv5tbsXMsBUjhTyr68m8joQbLJiWMG5aNAZ4XXnwhq/kM68zXllLUn G3eHGsWmPumcnpaouALJkF3XcPo1FdQiVFiT0H+6Lmrk/iN7yc62O1D1kF3kRxkkA/vM w/vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780552865; x=1781157665; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Rxy84CQtSfLdf5SWlBRH0Dm+BYAxOch+/SAQBO+pwA=; b=JW5Xk9auNnW57tQHs5hlbt8uZ9fsOjB7JQX1c1NGczDekeOJY15V2SNoXBpXYqTgcS vACG5iGIiPcqwIGLYVBsX2EHaWix38MYEdCVBdestYbPxjzaAteEQYFghXxyI+nFousW pawQwRDMrE1PYCDb/g+4xrpasHHm+TX6SXBWMyu84fyZbm8q0mtzxtIqXiyZ64CnVYG2 iarCwq1CEMEikfDKYsuQfhsqrWTT7aNWExzdiNs1CSIkxtkEGZZznzaphJ4PEOUUxDhX 8D/o+rOdgMjkkRcmVcp1nMD8w7swH0yLHZ4AGjF/1ifHdncs+e6u7GlS8UG0X3fy4jPw a+WA== X-Forwarded-Encrypted: i=1; AFNElJ81muXG6k/loa0sgTc4mH9+EzS+ABYo7x/YvoLJPTwkx6vFaxNuW9GO5aPswnF7QnaaRmgBescSEUJPHcs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyni/K1BuhoqreBZ/RJmGVAjvn+gKvhS03YUVuV3xp50dAiMrGg sJC4NaSxJIIehjl6UmSVOJMLC5okXZSAHoYJFoTIzsuy/D3q2RAjlj0m8RFhYvWUR/Zrt3Duqv6 DQw/420EhBXhNdT8mWQo29iBCW0kvER6xzmqR95p43Zx6jcSfl3cAJADI6xEvtafDLYk= X-Gm-Gg: Acq92OFhy/8qCkPXHefVWOqjZpzMvsH1V5ym4cs/+JPOOUxFdwjF7nAV/fvM+LgW0Fp hzTti7GHlsUyVHuXo9d+pqmA7+BVdYdNjNlWhAU12mQwDNUVxTwf3gRCvNoudwssmQQb9GcUEaK KnOh9J01APzwm3RVyvEVnGY2Jf9MOCrcHrxkdhTD+3ArorL3G21ztjGJvTpcycwTg/z5DWOzgZG kRrugEeh/RmU0RmgRUIhLk1DjVrenSeWD2AufPkhOIlTjLKKNFzGkkNCmV4SKNa3nK3S2VJ+9Me Etnwo01pZrxRppJzaQwULacl/yOu92pcOuzfcLCQir3aJaKVMPImOMH18REHp5u/PnC0rwl2P92 DPI+bXX6NARGKmUj6YqR03bFjEdqBIqwWNC3/xZGWC+WyGtw1dlV0682bw/zOrw1o X-Received: by 2002:a17:902:b58c:b0:2b9:e82f:bfef with SMTP id d9443c01a7336-2c163fa4e05mr46112335ad.21.1780552864476; Wed, 03 Jun 2026 23:01:04 -0700 (PDT) X-Received: by 2002:a17:902:b58c:b0:2b9:e82f:bfef with SMTP id d9443c01a7336-2c163fa4e05mr46111905ad.21.1780552863956; Wed, 03 Jun 2026 23:01:03 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d395sm61450955ad.17.2026.06.03.23.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 23:01:02 -0700 (PDT) Message-ID: <2e4ff886-af8d-b9cb-75f0-ad9bc081bf9b@oss.qualcomm.com> Date: Thu, 4 Jun 2026 11:30:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Vishnu Reddy Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: milos: Add Iris VPU v2.0 To: Alexander Koskovich , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260529-milos-iris-v2-0-7a763d7195ae@pm.me> <20260529-milos-iris-v2-3-7a763d7195ae@pm.me> Content-Language: en-US In-Reply-To: <20260529-milos-iris-v2-3-7a763d7195ae@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: K18JVbD8j6AHBmW11GQKrg2jGM3gh2rU X-Proofpoint-GUID: K18JVbD8j6AHBmW11GQKrg2jGM3gh2rU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDA1NCBTYWx0ZWRfX3C2cjZdrKb5k BPb2l8PVyoSrtaaiysWOzHV+VwTLoI1vU9mEIsV5gtdwWxu1+a2j6pHGwyXN3a6dRxVSUls7OFk Zk34OT6HnszGXWFrBqSOE3qyXAUXuNbjlUYvAv4dNs0LN+3+6mQLUT+fAWZqi35Wtn0OuTA4fI4 h3/8KEbpDMOBAA9pUNlYfLvywn2QD/n3aKVt7qdsxH/NsMTWeBX7T8F2omwreMlKRoccmDJiIaT sG73e9IRYPjSS6S4o1fpj9GI6w9Y4IRP0kOVk003foiehmTMf4xD9xdlM+kHUm1Vg5s9VhkVCak NsFkxtgx7T+Yf4VS1PCll0P1rE4CKY/NMmWfYo1nZx3FZOzks2LRCLpVgw57PQlh5Koo/aPT40J OoxBj+UR2/9OMFwZm2ErlNGJl10gp5nFmJf/sPLVwuQu89FXWCL8hapPTxj+qmwiDessTLgxWVV 4R7ZnoIA/oj0ZF5FVFg== X-Authority-Analysis: v=2.4 cv=f4p4wuyM c=1 sm=1 tr=0 ts=6a2114a1 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=cPBJnOxHEKv7ehhu7hMA:9 a=T0nNOjck6VvS5lE6:21 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040054 On 5/30/2026 2:28 AM, Alexander Koskovich wrote: > Add devicetree nodes for the Iris codec (VPU 2.0) found on the Milos > platform. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Alexander Koskovich > --- > arch/arm64/boot/dts/qcom/milos.dtsi | 85 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi > index 4a64a98a434b..94a3c51d1d0f 100644 > --- a/arch/arm64/boot/dts/qcom/milos.dtsi > +++ b/arch/arm64/boot/dts/qcom/milos.dtsi > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1835,6 +1836,90 @@ usb_1_dwc3_hs: endpoint { > }; > }; > > + iris: video-codec@aa00000 { > + compatible = "qcom,milos-iris"; > + reg = <0x0 0x0aa00000 0x0 0xf0000>; > + > + interrupts = ; > + > + power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>, > + <&videocc VIDEO_CC_MVS0_GDSC>, > + <&rpmhpd RPMHPD_CX>, > + <&rpmhpd RPMHPD_MX>; > + power-domain-names = "venus", > + "vcodec0", > + "cx", > + "mx"; > + > + operating-points-v2 = <&iris_opp_table>; > + > + clocks = <&gcc GCC_VIDEO_AXI0_CLK>, > + <&videocc VIDEO_CC_MVS0C_CLK>, > + <&videocc VIDEO_CC_MVS0_CLK>; > + clock-names = "iface", > + "core", > + "vcodec0_core"; > + > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &cnoc_cfg SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, > + <&mmss_noc MASTER_VIDEO QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "cpu-cfg", > + "video-mem"; > + > + memory-region = <&video_mem>; > + > + resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>, > + <&videocc VIDEO_CC_MVS0C_CLK_ARES>; > + reset-names = "bus", > + "core"; > + > + iommus = <&apps_smmu 0x1960 0>, > + <&apps_smmu 0x1967 0>; > + > + dma-coherent; > + > + /* > + * IRIS firmware is signed by vendors, only enable on > + * boards where the proper signed firmware is available. > + */ > + status = "disabled"; > + > + iris_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-240000000 { > + opp-hz = /bits/ 64 <240000000>; > + required-opps = <&rpmhpd_opp_svs>, > + <&rpmhpd_opp_svs>; This doesn't seem to fully address Dikshita comment from v1 — I believe the suggestion was to update for the mx rail only. > + }; > + > + opp-338000000 { > + opp-hz = /bits/ 64 <338000000>; > + required-opps = <&rpmhpd_opp_svs>, > + <&rpmhpd_opp_svs>; > + }; > + > + opp-366000000 { > + opp-hz = /bits/ 64 <366000000>; > + required-opps = <&rpmhpd_opp_svs>, > + <&rpmhpd_opp_svs>; > + }; > + > + opp-444000000 { > + opp-hz = /bits/ 64 <444000000>; > + required-opps = <&rpmhpd_opp_svs_l1>, > + <&rpmhpd_opp_svs_l1>; > + }; > + > + opp-552000000 { > + opp-hz = /bits/ 64 <552000000>; > + required-opps = <&rpmhpd_opp_nom>, > + <&rpmhpd_opp_nom>; > + }; > + }; > + }; > + > videocc: clock-controller@aaf0000 { > compatible = "qcom,milos-videocc"; > reg = <0x0 0x0aaf0000 0x0 0x10000>; >