From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Douglas Anderson <dianders@chromium.org>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@gmail.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Sean Paul <sean@poorly.run>, Simona Vetter <simona@ffwll.ch>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] drm/msm: Simplify NULL checking in msm_disp_state_dump_regs()
Date: Mon, 14 Oct 2024 12:03:50 -0700 [thread overview]
Message-ID: <2e544299-b40a-4cbe-86b8-6bcbd0ce25b9@quicinc.com> (raw)
In-Reply-To: <20241014093605.3.I66049c2c17bd82767661f0ecd741b20453da02b2@changeid>
On 10/14/2024 9:36 AM, Douglas Anderson wrote:
> The msm_disp_state_dump_regs():
>
> - Doesn't allocate if the caller already allocated. ...but there's one
> caller and it doesn't allocate so we don't need this check.
> - Checks for allocation failure over and over even though it could
> just do it once right after the allocation.
>
> Clean this up.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> .../gpu/drm/msm/disp/msm_disp_snapshot_util.c | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
next prev parent reply other threads:[~2024-10-14 19:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 16:36 [PATCH 1/3] drm/msm: Avoid NULL dereference in msm_disp_state_print_regs() Douglas Anderson
2024-10-14 16:36 ` [PATCH 2/3] drm/msm: Allocate memory for disp snapshot with kvzalloc() Douglas Anderson
2024-10-14 18:56 ` Abhinav Kumar
2024-10-14 16:36 ` [PATCH 3/3] drm/msm: Simplify NULL checking in msm_disp_state_dump_regs() Douglas Anderson
2024-10-14 19:03 ` Abhinav Kumar [this message]
2024-10-14 18:52 ` [PATCH 1/3] drm/msm: Avoid NULL dereference in msm_disp_state_print_regs() Abhinav Kumar
2024-10-27 2:04 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e544299-b40a-4cbe-86b8-6bcbd0ce25b9@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®