mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "* *" <richardvoigt@gmail.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Print sysrq-m messages with KERN_INFO priority
Date: Fri, 29 Dec 2006 23:19:49 -0600	[thread overview]
Message-ID: <2e59e6970612292119o38d96583ie245cb140adaafba@mail.gmail.com> (raw)
In-Reply-To: <E1H0Uq5-0003Fo-1W@candygram.thunk.org>

Was this patch tested?

On 12/29/06, Theodore Ts'o <tytso@mit.edu> wrote:
> Print messages resulting from sysrq-m with a KERN_INFO instead of the
> default KERN_WARNING priority
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>
> Index: linux-2.6/mm/page_alloc.c
> ===================================================================
> --- linux-2.6.orig/mm/page_alloc.c      2006-12-25 09:21:54.000000000 -0500
> +++ linux-2.6/mm/page_alloc.c   2006-12-29 17:19:11.000000000 -0500
> @@ -1505,7 +1505,7 @@
>  static inline void show_node(struct zone *zone)
>  {
>         if (NUMA_BUILD)
> -               printk("Node %d ", zone_to_nid(zone));
> +               printk(KERN_INFO, "Node %d ", zone_to_nid(zone));

Here there is a comma after KERN_INFO, which does not occur elsewhere.

>  }
>
>  void si_meminfo(struct sysinfo *val)
> @@ -1566,8 +1566,8 @@
>
>                         pageset = zone_pcp(zone, cpu);
>
> -                       printk("CPU %4d: Hot: hi:%5d, btch:%4d usd:%4d   "
> -                              "Cold: hi:%5d, btch:%4d usd:%4d\n",
> +                       printk(KERN_INFO "CPU %4d: Hot: hi:%5d, btch:%4d "
> +                              "usd:%4d   Cold: hi:%5d, btch:%4d usd:%4d\n",
>                                cpu, pageset->pcp[0].high,
>                                pageset->pcp[0].batch, pageset->pcp[0].count,
>                                pageset->pcp[1].high, pageset->pcp[1].batch,
> @@ -1577,7 +1577,7 @@
>
>         get_zone_counts(&active, &inactive, &free);
>
> -       printk("Active:%lu inactive:%lu dirty:%lu writeback:%lu "
> +       printk(KERN_INFO "Active:%lu inactive:%lu dirty:%lu writeback:%lu "
>                 "unstable:%lu free:%u slab:%lu mapped:%lu pagetables:%lu\n",
>                 active,
>                 inactive,
> @@ -1619,7 +1619,7 @@
>                         zone->pages_scanned,
>                         (zone->all_unreclaimable ? "yes" : "no")
>                         );
> -               printk("lowmem_reserve[]:");
> +               printk(KERN_INFO "lowmem_reserve[]:");
>                 for (i = 0; i < MAX_NR_ZONES; i++)
>                         printk(" %lu", zone->lowmem_reserve[i]);
>                 printk("\n");
> @@ -1875,7 +1875,7 @@
>                 /* cpuset refresh routine should be here */
>         }
>         vm_total_pages = nr_free_pagecache_pages();
> -       printk("Built %i zonelists.  Total pages: %ld\n",
> +       printk(KERN_INFO "Built %i zonelists.  Total pages: %ld\n",
>                         num_online_nodes(), vm_total_pages);
>  }
>
> Index: linux-2.6/mm/swap_state.c
> ===================================================================
> --- linux-2.6.orig/mm/swap_state.c      2006-07-04 18:38:19.000000000 -0400
> +++ linux-2.6/mm/swap_state.c   2006-12-29 17:18:42.000000000 -0500
> @@ -57,12 +57,14 @@
>
>  void show_swap_cache_info(void)
>  {
> -       printk("Swap cache: add %lu, delete %lu, find %lu/%lu, race %lu+%lu\n",
> +       printk(KERN_INFO "Swap cache: add %lu, delete %lu, find %lu/%lu, race %lu+%lu\n",
>                 swap_cache_info.add_total, swap_cache_info.del_total,
>                 swap_cache_info.find_success, swap_cache_info.find_total,
>                 swap_cache_info.noent_race, swap_cache_info.exist_race);
> -       printk("Free swap  = %lukB\n", nr_swap_pages << (PAGE_SHIFT - 10));
> -       printk("Total swap = %lukB\n", total_swap_pages << (PAGE_SHIFT - 10));
> +       printk(KERN_INFO "Free swap  = %lukB\n",
> +              nr_swap_pages << (PAGE_SHIFT - 10));
> +       printk(KERN_INFO "Total swap = %lukB\n",
> +              total_swap_pages << (PAGE_SHIFT - 10));
>  }
>
>  /*
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

  parent reply	other threads:[~2006-12-30  5:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-30  3:24 Theodore Ts'o
2006-12-30  4:42 ` Andrew Morton
2006-12-30  4:57   ` Dave Jones
2007-01-02  4:37   ` Theodore Tso
2007-01-02 10:33     ` Alan
2007-01-02 17:28       ` Dave Jones
2007-01-02 18:03       ` Theodore Tso
2007-01-02 18:15         ` Dave Jones
2006-12-30  5:19 ` * * [this message]
2007-01-02  4:24   ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e59e6970612292119o38d96583ie245cb140adaafba@mail.gmail.com \
    --to=richardvoigt@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®