From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A47B4C433DB for ; Wed, 24 Feb 2021 16:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BDF464EDD for ; Wed, 24 Feb 2021 16:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235535AbhBXQLa (ORCPT ); Wed, 24 Feb 2021 11:11:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235152AbhBXQGr (ORCPT ); Wed, 24 Feb 2021 11:06:47 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DB8EC061574 for ; Wed, 24 Feb 2021 08:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=3f77s7FhtCsDaYFseaJfdOAC/1AXNuhFWjHHZc+AbRU=; b=wbnsuACT4Zh0mmpleu09iIbQsK xOxqzEFCZUbw0rt9NpLoJOEJCMdQm57jjANGwtsAlJmylF8wOXm0BZarVmAjJkXxn3QUcUPDn3ayp 9mMRtGq9yoKCTdCYM8ui1Y6JLvrEmeYPVy5Q6rAp6evcnO+E/FV8A4WiJZzd3kWW5TyXIqbERWUJ1 Gq2u8GTZrLnxIqw+g8NhnqNjR2ddOqgQPCartCJEtNYQWWEPiGWBX3g/pytAw+e31AM+TXgtP6yG5 ZnzcXd/8kzcEie7q94Yz+GwnV77H/nYylbYYGP+przPwLLFpp/PtBqdACi9WuFv3inHS7oSdFZcRw lpMkrGkQ==; Received: from [2601:1c0:6280:3f0::d05b] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEwfo-0001u2-48; Wed, 24 Feb 2021 16:06:00 +0000 Subject: Re: (.text.ks8851_probe_common+0x370): undefined reference to `__this_module' To: Marek Vasut , Arnd Bergmann Cc: kernel test robot , Arnd Bergmann , kbuild-all@lists.01.org, "linux-kernel@vger.kernel.org" , Andrew Lunn References: <202102221437.vHlLwHmG-lkp@intel.com> <33c7cb1f-b6c0-24bf-0e6c-23d5472e4c29@infradead.org> From: Randy Dunlap Message-ID: <2e59ed9d-8618-d846-e2df-caf48c548e81@infradead.org> Date: Wed, 24 Feb 2021 08:05:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/21 3:02 AM, Marek Vasut wrote: > On 2/24/21 9:38 AM, Arnd Bergmann wrote: >> On Wed, Feb 24, 2021 at 3:38 AM Randy Dunlap wrote: >>> >>> On 2/21/21 10:12 PM, kernel test robot wrote: >>>> Hi Marek, >>>> >>>> FYI, the error/warning still remains. >>>> >>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>>> head:   31caf8b2a847214be856f843e251fc2ed2cd1075 >>>> commit: ef3631220d2b3d8d14cf64464760505baa60d6ac net: ks8851: Register MDIO bus and the internal PHY >>>> date:   7 weeks ago >>>> config: parisc-randconfig-r034-20210222 (attached as .config) >>>> compiler: hppa-linux-gcc (GCC) 9.3.0 >>>> reproduce (this is a W=1 build): >>>>           wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>>           chmod +x ~/bin/make.cross >>>>           # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef3631220d2b3d8d14cf64464760505baa60d6ac >>>>           git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>>           git fetch --no-tags linus master >>>>           git checkout ef3631220d2b3d8d14cf64464760505baa60d6ac >>>>           # save the attached .config to linux build tree >>>>           COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc >>>> >>>> If you fix the issue, kindly add following tag as appropriate >>>> Reported-by: kernel test robot >>>> >>>> All errors (new ones prefixed by >>): >>>> >>>>      hppa-linux-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common': >>>>>> (.text.ks8851_probe_common+0x370): undefined reference to `__this_module' >>>>>> hppa-linux-ld: (.text.ks8851_probe_common+0x374): undefined reference to `__this_module' >>> >>> Hey Arnd- >>> >>> I wanted to see if you had any ideas about this problem. >>> >>> CONFIG_KS8851=y >>> CONFIG_KS8851_MLL=m >>> >>> The problem is that 2 drivers share some common code, but in one case >>> the shared code is builtin and for the other driver it is a loadable >>> module. The common code is first built as builtin, so it does not have >>> the "__this_module" symbol. >> >> This is the patch I sent for it: >> >> https://lore.kernel.org/lkml/20210125121937.3900988-1-arnd@kernel.org/T/#u Thanks! > I was under the impression that the patch was already applied, wasn't it? Not that I can see/tell. -- ~Randy