mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "[6][Mee Ew][μ] !!! -- XKJ || mindless :D" <xiaokj@gmail.com>
To: Greg KH <gregkh@suse.de>, Oliver Neukum <oliver@neukum.name>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Yet another Conexant Clone to add to cdc-acm.c
Date: Thu, 7 May 2009 05:01:22 +0800	[thread overview]
Message-ID: <2e609cef0905061401n2412c448k755a152917f4b9d6@mail.gmail.com> (raw)
In-Reply-To: <20090506145832.GE3478@suse.de>

2009/5/6 Greg KH <gregkh@suse.de>:
> On Wed, May 06, 2009 at 10:47:14PM +0800, [6][Mee Ew][μ] !!! -- XKJ || mindless :D wrote:
>> Dear Mighty Ones,
>>
>> Please be gentle with me. This is my first time...
>>
>> Shiro / Aztech (Singapore) has completely cloned the Conexant USB
>> MODEM RD02-D400 and called it their UM-3100.
>> With the errors, of course.
>>
>> I am trying my best to follow procedures here (as google tells,
>> though), so if I am not right, please feel free to hurl insults back
>> to this mailbox.
>
> Minor thing to change, we need a "Signed-off-by:" line, as per the
> instructions in the file Documentation/SubmittingPatches.
>
> Care to add that to the patch description and resend the whole thing so
> that we can apply it?
>
> thanks,
>
> greg k-h

Understood. I have added you again, this time, because Mr Oliver
Neukum's email bounced on me the last time.

This patch adds another quirky Conexant USB Modem Clone to usb cdc-acm.c

This is to be applied to latest git. (Got off the website...)

Signed-off-by: Xiao Kaijian <xiaokj@gmail.com>

--- a/drivers/usb/class/cdc-acm.c       2009-05-06 22:06:27.556488116 +0800
+++ b/drivers/usb/class/cdc-acm.c       2009-05-06 22:12:56.648401202 +0800
@@ -1375,6 +1375,13 @@ static struct usb_device_id acm_ids[] = {
       { USB_DEVICE(0x0572, 0x1324), /* Conexant USB MODEM RD02-D400 */
       .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
       },
+       { USB_DEVICE(0x0572, 0x1328), /* Shiro / Aztech USB MODEM UM-3100 */
+        .driver_info = NO_UNION_NORMAL, /* has no union descriptor.
+                                          This is basically a clone of
+                                          Conexant USB MODEM RD02-D400.
+                                          Seems like NO_UNION_ _IS_ becoming
+                                          NORMAL... */
+        },
       { USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */
       },
       { USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */

       reply	other threads:[~2009-05-06 21:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2e609cef0905060747m281c15e8ybc8e20f9d4993178@mail.gmail.com>
     [not found] ` <20090506145832.GE3478@suse.de>
2009-05-06 21:01   ` [6][Mee Ew][μ] !!! -- XKJ || mindless :D [this message]
2009-05-06 21:30     ` Greg KH
2009-05-07 16:48       ` [6][Mee Ew][μ] !!! -- XKJ || mindless :D
2009-05-07 22:28         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e609cef0905061401n2412c448k755a152917f4b9d6@mail.gmail.com \
    --to=xiaokj@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®