From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755332AbdKAUxK (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 16:53:10 -0400
Received: from mailout.easymail.ca ([64.68.200.34]:52453 "EHLO
        mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755306AbdKAUxG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 16:53:06 -0400
Reply-To: shuah@kernel.org
Subject: Re: [PATCH] selftests: breakpoints: fix compile error on
 breakpoint_test_arm64
To: Sumit Semwal <sumit.semwal@linaro.org>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: will.deacon@arm.com, panand@redhat.com, paul.elder@pitt.edu,
        Shuah Khan <shuahkh@osg.samsung.com>, Shuah Khan <shuah@kernel.org>
References: <1508744542-11181-1-git-send-email-sumit.semwal@linaro.org>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <2e612e6a-8bf9-4852-d259-ec436f64d886@kernel.org>
Date: Wed, 1 Nov 2017 14:52:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1508744542-11181-1-git-send-email-sumit.semwal@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/23/2017 01:42 AM, Sumit Semwal wrote:
> The current mainline breakpoints test for arm64 fails to compile with
> 
> breakpoint_test_arm64.c: In function ‘set_watchpoint’:
> breakpoint_test_arm64.c:97:28: error: storage size of ‘dreg_state’ isn’t known
>   struct user_hwdebug_state dreg_state;
> 
> Adding a direct include for asm/ptrace.h helps it to build, and passes
> the test on mainline on hikey.
> 
> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
> ---
>  tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index 960d02100c26..2d95e5adde72 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -19,6 +19,7 @@
>  
>  #define _GNU_SOURCE
>  
> +#include <asm/ptrace.h>
>  #include <sys/types.h>
>  #include <sys/wait.h>
>  #include <sys/ptrace.h>
> 

Sumit,

Thanks for the patch. I will queue this up for 4.15-rc1.
This can be marked for stable I would assume?

thanks,
-- Shuah