mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Georgi Djakov <djakov@kernel.org>
To: Marc Zyngier <maz@kernel.org>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Cc: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Abel Vesa <abelvesa@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mostafa Saleh <smostafa@google.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH] Revert "interconnect: qcom: x1e80100: enable QoS configuration"
Date: Tue, 22 Sep 2026 00:36:36 +0300	[thread overview]
Message-ID: <2e666363-9a57-41a0-9605-db0dee304f52@kernel.org> (raw)
In-Reply-To: <86y0cu49iv.wl-maz@kernel.org>

On 9/21/26 11:47 PM, Marc Zyngier wrote:
> On Tue, 15 Sep 2026 13:37:03 +0100,
> Marc Zyngier <maz@kernel.org> wrote:
>>
>> This reverts commit 5a8b2cc36e796d595c9d97eab23c2be22805cc1c.
>>
>> Since the introduction of this QoS change, X1 machines based on the
>> Purwa SoC (such as the Lenovo Mini X) take a hard reset at boot time.
>>
>> Other machines based on Hamoa (such as the X1E001DE Snapdragon Devkit)
>> end-up with a similar hard reset while under load, most likely due to
>> the PCIe ports being starved of traffic.
>>
>> Revert the whole thing until someone figures out what magic parameters
>> allow QoS to work in a sensible manner, as a usable machine is somehow
>> preferable to one that crashes efficiently.
>>
>> Link: https://lore.kernel.org/all/apgeBNSiP01YfNcs@google.com
>> Link: https://lore.kernel.org/all/86ld9d4h4n.wl-maz@kernel.org
>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>> Cc: Georgi Djakov <djakov@kernel.org>
>> Cc: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
>> Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Cc: Abel Vesa <abelvesa@kernel.org>
>> Cc: Bjorn Andersson <andersson@kernel.org>
>> Cc: Mostafa Saleh <smostafa@google.com>
>> Cc: Thorsten Leemhuis <regressions@leemhuis.info>
>> ---
>>   drivers/interconnect/qcom/x1e80100.c | 485 ---------------------------
>>   1 file changed, 485 deletions(-)
> 
> Any update on applying this? These machines have been broken for the
> past 4 release candidates, and it'd be great to get them back to a
> working state.
> 
The revert is in linux-next already and i will propagate it as a fix in
a couple of days. Thank you for the report and for sending the patch!

BR,
Georgi

  reply	other threads:[~2026-09-21 21:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 12:37 Marc Zyngier
2026-09-15 12:48 ` Abel Vesa
2026-09-15 13:16 ` Mostafa Saleh
2026-09-21 20:47 ` Marc Zyngier
2026-09-21 21:36   ` Georgi Djakov [this message]
2026-09-21 22:25     ` Marc Zyngier
2026-09-15 12:44 Abel Vesa
2026-09-15 12:49 ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e666363-9a57-41a0-9605-db0dee304f52@kernel.org \
    --to=djakov@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=raviteja.laggyshetty@oss.qualcomm.com \
    --cc=regressions@leemhuis.info \
    --cc=smostafa@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®