From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71E2C3CDBD9 for ; Wed, 3 Jun 2026 05:45:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780465504; cv=none; b=LH+X+/vM0QhfuANpZzAkV2jDTq+U57RY9WwA9KS8DSJyS/34UCW8ttq27KvpbffsRDvBd+dn9b2cGIvslBwjrZ/AsVIkDRnTAMhn8qKLNkSBQEyv2QvYYz+AwVxRPrrFupskFJXe3NSJXxSpsugBYkQcfXha9IC3lBiii6JMn4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780465504; c=relaxed/simple; bh=CTvSQbKtW8FpaJ7tHjCWQB0GUs6qdPLidJ/+54VFGyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tdYSVhgoZ45cDg/VXnIrMiD78MVHA9zpbW0nV52EIaHj+FdKrJEngZfX45Bh8IhWfLSDl4rRKpNNFcFgmeLbee7aaN+7wjDqoVxGuDKdHRnb8VZXZicXNdIMcv/ueN7nKiVmi9GDhJE3c9Kv/mtoCJxnAWQMWZOO7rkiLmhRsGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nyd0xvc3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JcvAzrqv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nyd0xvc3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JcvAzrqv" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6535WCWJ1619630 for ; Wed, 3 Jun 2026 05:45:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jD4EFN8Ib2vXd/ldbSvARuiM8o4JnTecmLZxDIIYI3o=; b=nyd0xvc38qGbLOMG UfHnb4VdWUp5i29VrqUpHjKTi7OpdukBs4avraR0zi4jlw2chzcBnD5PDoI8DUOj WuayLgSxLQ13A8lEroReSxKimfdbUH2JJw8ZLAPm5r+oTsiiYNbMzCb+NaSIZSBd mGwFBGBDx/VLUvNMvQS7V8VdoyBFCvWV7oSo6qNnuZXwXAatlGOjhk237ZfMrCRc 4Y5eOs4JXAgvZDmUWVArjXlHM1yfJfSBol0ciyAFguLOiGv2Hw/MUMcaJAVzTFzK lVvF1Y1fVS7LAx3R05M1uYRKt9m+fOQTzD1/BltriPzL4Qoaei9Q7yr5W9R8Gam6 2JBdhA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejdq7r4uy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 05:45:01 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-36b7f696b40so5174505a91.1 for ; Tue, 02 Jun 2026 22:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780465501; x=1781070301; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jD4EFN8Ib2vXd/ldbSvARuiM8o4JnTecmLZxDIIYI3o=; b=JcvAzrqv3O1COKTCtqXePUQWqWFpaVDoqXvu+MvD5R5tTcSaL+uPzQeE8kE70EDFtd IMuz4ne+ljZSIFhHHGwUkaZeqyyxSQ1sKqE9XgcrulsB+6ezlHRun6fZ+6X/p0Psx4f0 7z50DpKGm2yrz/MZkIV7GDVDiHeGcDKz8aBj0QZg2fL5CtytjPXSdfWke69WbNeZr2sM rdY79+XbvLhYlVqt9sz3DMmEmGGCn/BbVFvfzXLatvERfPDzowh07SkZC5k3KgtftrKR VkEyrzaIn1dUjf3PKHWWsaHvL4gHAB/IRHcIXg1kmHW5HCKd6ewNPN4RhFgzcr6T1FsN pRVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780465501; x=1781070301; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jD4EFN8Ib2vXd/ldbSvARuiM8o4JnTecmLZxDIIYI3o=; b=EBwTxFTQjKJBzMIc/F3IUXy7rE02w1pNbXJaZc3lRVtFHhI9NBIJYYjhd35Kv4JqZa rPhQ++S9bZe0j/sPAu11MKIw/nhvoFR8gIz6ukeVDDWoBKzj/Ex6wzyDB/rb3DZaK5u2 OIYEn3K7YpKJJbDZUUAvBYrTR8xQeV4aJJOeHxbWzNSV1XQpEIC2ptq3KUrqSN9QxteX QV9SozRUSqwgkmHtvUb8A5dy3NSLiYtAMy3PGekqq0c+mA2SjXeEakOqw3obZSO4BX2J u501LoaoFv56rnP35Cz59pdRAVi51DPJY34Vwe/ioHh0AqyN0OyquacfEQWSGFP9ticr DQjA== X-Forwarded-Encrypted: i=1; AFNElJ9bCFnquAq0BtqaegczBb8vYPjbhcoGajqyCqd/J9krtCvOxjWWqdE58TZpO3ENnMCyIY7cGvJ9rwxwbys=@vger.kernel.org X-Gm-Message-State: AOJu0YxFtl8fOQIvdXAXxF89eYBO6utuqLyMqK/vQvZxX+RmZe1e48MP ooHM2vByZeZd4amXScMjFy4dPLCl7XKWs5huOrQbdzZ3Z6vgtwrJXUXPWpRgcsG2UgnrwuAbCKF Qpk7BXzYE13jynGDv3lcr63g5dpGnnIRpCmKyD+QPLsDOJVPhohAwscWUI+LA87RfXWA= X-Gm-Gg: Acq92OGCSXQgzWICa5EGCGg2pB8TNC7f+SjTnAxsR4OtoZHbab2Ld++VWr2pc0WABqP Yms/c/ic9VtKV55A9SFamxbDIRWuY2gWujOhYT9LpGX1lIfTsrOLKcW/+AEN7v7IdnGwn2AyywO yRAl7NT+fgYd0pfN0Tal8onN9AX0LGYmOBM9Hz+6928yIT72WVXU02Tczoiwop65eAb+Av57nxw U2y+Eip3RoNPMnkHZo+Rdv04aPjXlQWFXMAeh7z2aJj/grY7ZyYwbp8GRkvONQvyZ7hCxw6rT8m deQKnO1HoDv+3pS3Oa2+lO/PCSUHsGRj4+aucSQBwPuHcaZyifiGecgzNJ7OPObS1/hU2dcGkDW BrhvzKVBLq0oUSLjpdN1aBu25Fs48jbP1lH4Mu4kXnvI3qkITJurDBOzG4uTy X-Received: by 2002:a17:903:19ef:b0:2c0:ca99:3d73 with SMTP id d9443c01a7336-2c163a28aa4mr20236155ad.8.1780465500702; Tue, 02 Jun 2026 22:45:00 -0700 (PDT) X-Received: by 2002:a17:903:19ef:b0:2c0:ca99:3d73 with SMTP id d9443c01a7336-2c163a28aa4mr20235635ad.8.1780465500059; Tue, 02 Jun 2026 22:45:00 -0700 (PDT) Received: from [10.204.78.54] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16609e0bbsm11366185ad.50.2026.06.02.22.44.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 22:44:59 -0700 (PDT) Message-ID: <2e66a50b-f392-4ce3-89d2-997e9fef0e6b@oss.qualcomm.com> Date: Wed, 3 Jun 2026 11:14:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/15] accel/qda: Add memory manager for CB devices To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Bharath Kumar , Chenna Kesava Raju , srini@kernel.org, andersson@kernel.org, konradybcio@kernel.org, robin.clark@oss.qualcomm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org References: <20260519-qda-series-v1-0-b2d984c297f8@oss.qualcomm.com> <20260519-qda-series-v1-7-b2d984c297f8@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDA1MiBTYWx0ZWRfX43jypU/s7WxV aCe4tPiS8fWNrpsOZuD04X2imY5mkOu+3vPrvS3/SEuonw6zmc6M8v8soaazuCnPvSv0Q+qSNP0 lUXiZCykKmoDeHledATeItIrOQupzFdeeds3HtxfTRzu6FwcI/RI/jFX65k85ms6upgrNNhZFpc bArCinpLjZq1xsg8FqJSl+xtQV6+3oL0zLX9s6zk9u9h3zSoMUk0I2Xp6NkcYaH0bJPnhXehWJ2 uswFcPhVOoSJch4QDCEwJfAarBBsDPkZLKrJl/TEhqxP41vxpzixf1+pGp2SI4d4z4LbqDSYc6z MzEaPe+PxliWKeDZW+KPjSbfDX+vcZRP2xjIzglSsv9kR4noZLjLHqjdk63siRbErarVXT67d54 XsekDNfUcJTxZA5Lrq4Mc8nyhZ/axTAsa7RD4+h3ErlgrGafcA3AMh+EtuQUlMA8m6+eefi0zbl qh3VrRt2gK9PsbNY9JQ== X-Proofpoint-ORIG-GUID: AQCggOtPVXuX2tOZN-iTjneDuiDJfczD X-Proofpoint-GUID: AQCggOtPVXuX2tOZN-iTjneDuiDJfczD X-Authority-Analysis: v=2.4 cv=ccniaHDM c=1 sm=1 tr=0 ts=6a1fbf5d cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=njyYu5vTmptnp6f7sR4A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030052 On 20-05-2026 19:56, Dmitry Baryshkov wrote: > On Tue, May 19, 2026 at 11:45:57AM +0530, Ekansh Gupta via B4 Relay wrote: >> From: Ekansh Gupta >> >> Introduce the QDA memory manager (qda_memory_manager) to track and >> manage the IOMMU devices that back each compute context bank (CB). >> >> Each CB device registered on the qda-compute-cb bus is assigned a >> unique ID via an XArray and wrapped in a qda_iommu_device descriptor > > Why do you need an XArray? The number of devices is (more or less) > fixed. You can use a normal array, allocated in the probe function after > counting OF children nodes. Normal array should be fine here, I'll check and remove this.> >> that records the device pointer and its stream ID. This registry >> allows the driver to look up the correct IOMMU domain for a given >> session when mapping DSP buffers. >> >> The memory manager is initialised in qda_init_device() before CB >> devices are populated and torn down in qda_deinit_device() after they >> are destroyed, ensuring no dangling references remain in the XArray. >> >> qda_cb.c is extended with qda_cb_setup_device(), which is called >> immediately after a CB device is registered on the bus. It allocates >> a qda_iommu_device, registers it with the memory manager, and stores >> it as the CB device's driver data so that qda_destroy_cb_device() can >> retrieve and unregister it during teardown. >> >> Assisted-by: Claude:claude-4-6-sonnet >> Signed-off-by: Ekansh Gupta >> --- >> drivers/accel/qda/Makefile | 1 + >> drivers/accel/qda/qda_cb.c | 47 ++++++++++++++ >> drivers/accel/qda/qda_drv.c | 34 ++++++++++ >> drivers/accel/qda/qda_drv.h | 5 ++ >> drivers/accel/qda/qda_memory_manager.c | 111 +++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_memory_manager.h | 49 +++++++++++++++ >> drivers/accel/qda/qda_rpmsg.c | 7 +++ >> 7 files changed, 254 insertions(+) >> >> diff --git a/drivers/accel/qda/Makefile b/drivers/accel/qda/Makefile >> index 143c9e4e789e..701fad5ffb50 100644 >> --- a/drivers/accel/qda/Makefile >> +++ b/drivers/accel/qda/Makefile >> @@ -8,6 +8,7 @@ obj-$(CONFIG_DRM_ACCEL_QDA) := qda.o >> qda-y := \ >> qda_cb.o \ >> qda_drv.o \ >> + qda_memory_manager.o \ >> qda_rpmsg.o >> >> obj-$(CONFIG_DRM_ACCEL_QDA_COMPUTE_BUS) += qda_compute_bus.o >> diff --git a/drivers/accel/qda/qda_cb.c b/drivers/accel/qda/qda_cb.c >> index 77caf8438c67..6d540bb0ec7b 100644 >> --- a/drivers/accel/qda/qda_cb.c >> +++ b/drivers/accel/qda/qda_cb.c >> @@ -8,11 +8,42 @@ >> #include >> #include >> #include "qda_drv.h" >> +#include "qda_memory_manager.h" >> #include "qda_cb.h" >> >> +static int qda_cb_setup_device(struct qda_dev *qdev, struct device *cb_dev, u32 sid) >> +{ >> + struct qda_iommu_device *iommu_dev; >> + int rc; >> + >> + drm_dbg_driver(&qdev->drm_dev, "Setting up CB device %s\n", dev_name(cb_dev)); >> + >> + iommu_dev = kzalloc_obj(*iommu_dev); >> + if (!iommu_dev) >> + return -ENOMEM; >> + >> + iommu_dev->dev = cb_dev; >> + iommu_dev->qdev = qdev; >> + iommu_dev->sid = sid; >> + >> + rc = qda_memory_manager_register_device(qdev->iommu_mgr, iommu_dev); >> + if (rc) { >> + drm_err(&qdev->drm_dev, "Failed to register IOMMU device: %d\n", rc); >> + kfree(iommu_dev); >> + return rc; >> + } >> + >> + dev_set_drvdata(cb_dev, iommu_dev); >> + >> + drm_dbg_driver(&qdev->drm_dev, "CB device setup complete - SID: %u\n", sid); >> + >> + return 0; >> +} >> + >> int qda_create_cb_device(struct qda_dev *qdev, struct device_node *cb_node) >> { >> struct device *cb_dev; >> + int ret; >> u32 sid = 0; >> char name[64]; >> struct qda_cb_dev *entry; >> @@ -30,6 +61,13 @@ int qda_create_cb_device(struct qda_dev *qdev, struct device_node *cb_node) >> return PTR_ERR(cb_dev); >> } >> >> + ret = qda_cb_setup_device(qdev, cb_dev, sid); >> + if (ret) { >> + drm_err(&qdev->drm_dev, "CB device setup failed: %d\n", ret); >> + device_unregister(cb_dev); >> + return ret; >> + } >> + >> entry = kzalloc_obj(*entry); >> if (!entry) { >> device_unregister(cb_dev); >> @@ -80,6 +118,7 @@ int qda_cb_populate(struct qda_dev *qdev, struct device_node *parent_node) >> void qda_destroy_cb_device(struct device *cb_dev) >> { >> struct iommu_group *group; >> + struct qda_iommu_device *iommu_dev; >> >> if (!cb_dev) { >> pr_debug("qda: NULL CB device passed to destroy\n"); >> @@ -88,6 +127,14 @@ void qda_destroy_cb_device(struct device *cb_dev) >> >> dev_dbg(cb_dev, "Destroying CB device %s\n", dev_name(cb_dev)); >> >> + iommu_dev = dev_get_drvdata(cb_dev); >> + if (iommu_dev && iommu_dev->qdev && iommu_dev->qdev->iommu_mgr) { >> + dev_dbg(cb_dev, "Unregistering IOMMU device for %s\n", >> + dev_name(cb_dev)); >> + qda_memory_manager_unregister_device(iommu_dev->qdev->iommu_mgr, >> + iommu_dev); >> + } >> + >> group = iommu_group_get(cb_dev); >> if (group) { >> dev_dbg(cb_dev, "Removing %s from IOMMU group\n", dev_name(cb_dev)); >> diff --git a/drivers/accel/qda/qda_drv.c b/drivers/accel/qda/qda_drv.c >> index 6c20d6a2fc47..0ad5d9873d7e 100644 >> --- a/drivers/accel/qda/qda_drv.c >> +++ b/drivers/accel/qda/qda_drv.c >> @@ -57,6 +57,40 @@ struct qda_dev *qda_alloc_device(struct device *dev) >> return qdev; >> } >> >> +static void cleanup_memory_manager(struct qda_dev *qdev) > > Prefixes... ack> >> +{ >> + if (qdev->iommu_mgr) { >> + qda_memory_manager_exit(qdev->iommu_mgr); >> + kfree(qdev->iommu_mgr); >> + qdev->iommu_mgr = NULL; >> + } >> +} >> + >> +static int init_memory_manager(struct qda_dev *qdev) >> +{ >> + qdev->iommu_mgr = kzalloc_obj(*qdev->iommu_mgr); >> + if (!qdev->iommu_mgr) >> + return -ENOMEM; >> + >> + return qda_memory_manager_init(qdev->iommu_mgr); >> +} >> + >> +void qda_deinit_device(struct qda_dev *qdev) >> +{ >> + cleanup_memory_manager(qdev); > > Ugh, inline all your one-line wrappers. ack> >> +} >> + >> +int qda_init_device(struct qda_dev *qdev) >> +{ >> + int ret; >> + >> + ret = init_memory_manager(qdev); >> + if (ret) >> + drm_err(&qdev->drm_dev, "Failed to initialize memory manager: %d\n", ret); >> + >> + return ret; >> +} >> + >> void qda_unregister_device(struct qda_dev *qdev) >> { >> drm_dev_unregister(&qdev->drm_dev); >> diff --git a/drivers/accel/qda/qda_drv.h b/drivers/accel/qda/qda_drv.h >> index 2715f378775d..eb089e586b17 100644 >> --- a/drivers/accel/qda/qda_drv.h >> +++ b/drivers/accel/qda/qda_drv.h >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include "qda_memory_manager.h" >> >> /* Driver identification */ >> #define QDA_DRIVER_NAME "qda" >> @@ -40,6 +41,8 @@ struct qda_dev { >> struct device *dev; >> /** @cb_devs: Compute context-bank (CB) child devices */ >> struct list_head cb_devs; >> + /** @iommu_mgr: IOMMU/memory manager instance */ >> + struct qda_memory_manager *iommu_mgr; >> /** @dsp_name: Name of the DSP domain (e.g. "cdsp", "adsp") */ >> const char *dsp_name; >> }; >> @@ -59,6 +62,8 @@ static inline struct qda_dev *qda_dev_from_drm(struct drm_device *dev) >> struct qda_dev *qda_alloc_device(struct device *dev); >> >> /* Core device lifecycle */ >> +int qda_init_device(struct qda_dev *qdev); >> +void qda_deinit_device(struct qda_dev *qdev); >> int qda_register_device(struct qda_dev *qdev); >> void qda_unregister_device(struct qda_dev *qdev); >> >> diff --git a/drivers/accel/qda/qda_memory_manager.c b/drivers/accel/qda/qda_memory_manager.c >> new file mode 100644 >> index 000000000000..00a9c0ae4224 >> --- /dev/null >> +++ b/drivers/accel/qda/qda_memory_manager.c >> @@ -0,0 +1,111 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include "qda_drv.h" >> +#include "qda_memory_manager.h" >> + >> +static void cleanup_all_memory_devices(struct qda_memory_manager *mem_mgr) >> +{ >> + unsigned long index; >> + void *entry; >> + >> + pr_debug("qda: Starting cleanup of all memory devices\n"); > > pr_debug is a third way to debug. Stop it, please. ack> >> + >> + xa_for_each(&mem_mgr->device_xa, index, entry) { >> + struct qda_iommu_device *iommu_dev = entry; >> + >> + pr_debug("qda: Cleaning up device id=%lu\n", index); >> + >> + xa_erase(&mem_mgr->device_xa, index); >> + kfree(iommu_dev); >> + } >> + >> + pr_debug("qda: Completed cleanup of all memory devices\n"); >> +} >> + >