From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 209C72F8E9F for ; Thu, 25 Jun 2026 15:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782402898; cv=fail; b=D5zFmCQGG5SpURkO+LxQMtdkbj2BuIITJgRey4ue0QXkZzvouPQJSq99QJLTSFtiZ4JXVKwT4lfiWcnR3z+NP11KmxVn2MvQt/t+QClMy5HS6C9V8Blp5E14qN4QXJHOsAxdLDlZZ7eUOpoi44WdnoaFRxLGzWCSPXnDpd5Fypo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782402898; c=relaxed/simple; bh=1FgyG2h+d0yIq2eQ9llEt7u6HNqcTnWwM90YHExp79c=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=uzOwvEeW8noo/wAEwIc/hiTWNQiQr5SjdgKg312ChGBEboa/DPBmgtb3MAvLQAXE9a9V/+P3wf4HsUhh5aAsMAQ5ob+ag0paJUbelyuYBDtHTiJ1s+3V6ftbZ/SsDJspNMuhN46B6r4KtJsT4Fh2V1JxM+gNpfntNM7hNEUCZ74= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DWcqJLf3; arc=fail smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DWcqJLf3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782402887; x=1813938887; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=1FgyG2h+d0yIq2eQ9llEt7u6HNqcTnWwM90YHExp79c=; b=DWcqJLf34GVUxq2zFGpmcpGhZT/bI2KteMHvgyZDIkrJvjKtzQxMbR1R yVAob3tSS1ec98Y72ytxmPocuMq01xSXTTGhT7+nnazORrfdIwVffKONd lB9HchTERuXIWOEKyzRreRQQZCZJKQ6Il8dnjhXjviNG1C9mEPS1DGIZZ G3+Pkocb8HzcSkpo+KtJt7VmWnuO47wtRdjCgMOEo6o7Pa6Wdn/OC5WRC rXmiUi7GHp0ZvvlSDi/NLVMs4kfmLhOj7fmBC2qdLmgLXlKhwTRVamj96 ROP9DzpO6KdRhOwHyMU8lVqmavpo1Pbilmvtu5uNwaZJibmQAA6gWKZf6 Q==; X-CSE-ConnectionGUID: MwXGQ474Qv+iU7rnkrdQHw== X-CSE-MsgGUID: AgInhqUpTvyG3AV5c4QZag== X-IronPort-AV: E=McAfee;i="6800,10657,11828"; a="83185223" X-IronPort-AV: E=Sophos;i="6.24,224,1774335600"; d="scan'208";a="83185223" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2026 08:54:46 -0700 X-CSE-ConnectionGUID: iMnnd6WTSrWPiHPGQBJV0Q== X-CSE-MsgGUID: oEpLD9+/R5irQF5LCCcJUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,224,1774335600"; d="scan'208";a="254890814" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2026 08:54:45 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 25 Jun 2026 08:54:43 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Thu, 25 Jun 2026 08:54:43 -0700 Received: from CH1PR05CU001.outbound.protection.outlook.com (52.101.193.4) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 25 Jun 2026 08:54:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yuganuVbdDbeMYBpVcQy6wir6YxrDGqEScuycwg5KjCdBqfoU1QD9XUcsNuBXJnRvYHewGvLyWczrN7/PBvf8EoX5dmNnhbwJRJaz6lwrvSbvJBj1lgikZLcGY4Y6yjXJR+LU3PofHlIRfo8+wJl47DywA3yWup7wdIKd63IBMIwrHQqmo6U0XP8IrDt5wVGtl2IdTWigg30qov66/6eBhpFp10OBVsvalojkZah0sGFgq984Rh+gdnQ/9IBEH4AP7DfeSVqgMQiHqvB9cP9UJvrX2FuWKAZnozb1Na8eEiZ4AC7sE5gpPaC2CRg4NoFwnMeGZxE8hOlBdWnJiQ1/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GxQNuLtyLTbvtfDFchm+6a5KXtyMyzXwwOck3CSUlwY=; b=GEepnRh8W5XDilQ7VoMEc4gbk49GjTK2OpH+EEypGPFtg64s7iSqhM3esgisE2PRrGnT1yigtB2zPRn5Jc1S4TZz93J9crH7oruAJW/eKizv8UUtg2Ruqnh2403PvzjO6F8JZU6P4Sj9A4UccV76cfSR/K9nkLwI4L1V3l8N/+XCyMOcBwmRc0t8yMhFFEAXMdLRmqGs/4rFkYC/MdHRFrqBmLk+9L8muhx0jX75R050cih5oCqQZQ3qUm5DGsYzItyg13wiMsLF6LRex6LO5cEiVQtgaWME62LP9chXL14KcZehYFYy67GLDNBYLw0mZNHDMlR6ZAzFzjkxM2Lv1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by PH0PR11MB5157.namprd11.prod.outlook.com (2603:10b6:510:3d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.17; Thu, 25 Jun 2026 15:54:41 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0139.018; Thu, 25 Jun 2026 15:54:40 +0000 Message-ID: <2e68bb81-ca13-456c-85ee-6173a23d3abd@intel.com> Date: Thu, 25 Jun 2026 08:54:38 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/6] x86/resctrl: Parse ACPI ERDT table and map RMDD domains by L3 cache ID To: "Chen, Yu C" CC: , , , , , , , , , , , , , References: <807a91c2b6235f85e2d19d4293c17e53a8cc69b2.1781332698.git.yu.c.chen@intel.com> <288153df-307a-40e3-96e1-ff4ae8f6bc5a@intel.com> <2835922f-d2b7-45dc-92e3-c6aed4e79fe9@intel.com> <4b48ec4d-517d-44d0-8be0-7e24d0970b7b@intel.com> <1c671ba2-501d-4b31-bd33-9cb23b54db01@intel.com> <040bb2fd-b8e3-47a9-b560-7d57ed6768cc@intel.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <040bb2fd-b8e3-47a9-b560-7d57ed6768cc@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR04CA0335.namprd04.prod.outlook.com (2603:10b6:303:8a::10) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|PH0PR11MB5157:EE_ X-MS-Office365-Filtering-Correlation-Id: f0aba412-213b-4f44-3ad6-08ded2d21130 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|366016|1800799024|6133799003|56012099006|11063799006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: dy+oxV5IcHmgdOL65JzD1jtMY6F6bnABGqFn6c+BVrCJWQqtmVtgFZ5KSEx0TULlVk4d0Nc+d5IJEC+kETtWjQec+joqcFbS7BCevYpo+42yuTVlcpu4z3TvudG60V13SFojNPPKoX1tDFFu9cIN0Td+Y9uiEmBliVaHOaq7PMfNjfPqaLcaImzgNgTuGayMzxqnBHrxQoPWkNout73R+Kra+vB02sumF+bQsPMwU2/pu5V7U9yATbEjcq/f4SEv7FFBhtV0o9Mz8PdJaXjB7XYBRVeAtHTZsfZEA/ZxBy/AQ4Cn0R84Ts+wpRBKVzIePwJ/rrv5JeDsi7ZIXP4bnt/qGGFGD1t9flCqAPH7keDEyT/+urS5jgwQOMahgn3v4s4ueT/HbpG24ytZidvUfDH31Mdia12zFNMBLooop+mA1TEINnisU8r4Ggwp5vKMhoZYhbpUpFomHxwAzSpVDlscqTI6ozaz160iZoKADq7CjRy1gSIjcgVZbwz3aNQG3OTCCeNCRslOQ1Cg3NYwBNSzbymo6Pgb5o7FJllezUwJPt+ioXS/OsWZCIu7eklSlB8vtCggKMmgBgxSmQSCmLSfUnWP0cwe8uhgZiBtoawR4LDyYTDuvy3j7n+t9ytoHWd3FkFYViB124BRI8FVwyn3foDhKJR/MnsMDnOffRU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(366016)(1800799024)(6133799003)(56012099006)(11063799006)(4143699003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHI0eHVTMDBzVWFuSUVBWk1YSHZ1eFNDdExsN2FtNHU2ajN1Q1BDTHdOaTM3?= =?utf-8?B?R1Q1Mk5TckhaQzd1MWRTZFRXQTc4SEI3c1N4WFpQUTAxUmlIcmY3L2pRL0FM?= =?utf-8?B?eGtRQXdKV2dRNzltT3ljd01GUUhoV0pZWW13VDN3NEhMS0ZXTXh5VVFJVHBt?= =?utf-8?B?dHhkY0VNamlZZklBL0FuK3l2NW10SnNHUWhGY3hPNnZSd21SK1FVWk8rb0cw?= =?utf-8?B?Vnh5T1VPMmFsazE2cHpCRjNsUFBQNlBPSkcrY2Y2Q0x1K1R6VEtabWVvNjNx?= =?utf-8?B?Nm5uUE9Mb2wydkhTTGtTWjh4aS91bGMybXo4R2ZYNTdSdEhkUEszMEppZ1lU?= =?utf-8?B?ak5HbUJmTDhsVldhajRSM0lyYWEycUk3VE0zZXdFOGxNUHVjaHJ2RkxSajJE?= =?utf-8?B?R00yMkE3VGpwV0ErT2psV092OWdIa0dpTGtpL1M4NnNjOVVGNmhIMXh4Z3Qv?= =?utf-8?B?MkVuaWxOZmRuT1hiTHc2VG8yemJPVXIvTi9yc2VNY3MvamQyNmdBeWRUS2Mr?= =?utf-8?B?V3ZSME1GaFJMSCswODFKaGFQMmtQRGlTVVRvNkpSdHlrQmxYUVlPU2pOK25O?= =?utf-8?B?ZURqMWlyODhCcEtPY0xJRHVRSmJYaUswa2xWaG5Ra3dQNTY5OHdpLzYxbk5S?= =?utf-8?B?cEpHMXQvVWphSEdmZmZicUtPRTZwMzZsYm1aTVpCV2hjN0g4Z3hSd055NHdw?= =?utf-8?B?aHJjaE1IZlZTQlpUWjFzSVdDUWxscHBpaUJVelA3NVVFYTNBTGI2SElQVWFa?= =?utf-8?B?MXlHSGd1ZXA5RjdBdFVpbi81MWJBOWU5WnpjNkVUdk05azVhN3lsZFJ5eTFU?= =?utf-8?B?elQ2QURWckM3WElXZmZTdkxPbzg1K1Y5TnByamxKTHRRcFVqRmtQb1BRb01y?= =?utf-8?B?TjlZQ0h1RzF6cDk3NXY2MU9ydTdWS2t3U284SjM5OGxKQ2h5QmxTSHFzR2lx?= =?utf-8?B?dittNWcxWDFyZU9VNzJqOXcxamJkV1ptYzB3SlVDck0xSVdmUEM2dWRVa3BO?= =?utf-8?B?V29wck5laHZObzBCS0t0YnkyL3RkQjVCUFBnNkkxT1c2NlhFU1R3bVlUYkxk?= =?utf-8?B?TFEyMlFzclJGOVFuSlZlblRtTHR6ZmdqQkN5N2h1VUZmVDE5SFBCYkRxWW5N?= =?utf-8?B?RENPNGlxM3dEazU4ZGI3KzQ4Rk9sdFM2OTBNaEttRnExd3MyeWFYc2FhNyth?= =?utf-8?B?bytqZzhZYUdpSVI5NlJyMlZQWDJSdDk0OWlVMUwyRnRQS3V5WVJnVGhYZDhX?= =?utf-8?B?a3cwbTVoWjMyOG96MC80M2YxOXZvUjRBUURrdzZWSDYyYS9LaWpEeXhsNGxs?= =?utf-8?B?Z2RHQ1F3VnYxMzc3N2JrcUJJNG9lNC83WWJEL0xuWkZrT3BTRTRnU0VwQzRW?= =?utf-8?B?Q0lrUWtmSStmUWhaQXpRMXdyMG1tSFRzNzl5VTBaQXdEZVl5RGlwYWNYSXlp?= =?utf-8?B?bE5mQVhaamM2Smc4T1V6S1h0aTJpZDNmdFBkSWJXWXJsN2RwTTIwaTROM01S?= =?utf-8?B?MGVtUTNNQ2ZWMmJQZitsYmVxSG5ValRYaEdDWWlMMFBPbmJKaEhTWkY4cElv?= =?utf-8?B?THc5dlJyOCtXOTllcmRHUVNjcm04cGJEVTBnZWZTZjYzMTVHVXZnenJleUM3?= =?utf-8?B?NE96MjFIcXRiQjBGNy9kWG16THc0dENXSzdlZlh0cTQzeWhhQ0p3VEdjM3Ri?= =?utf-8?B?SWR6UkdjQWNxdllPei9VWWV4TDBtSVg3R284aS92Si9PR1hhUk9mUFpSZ2ty?= =?utf-8?B?RmxCZ2w0TXFMeTFQcHRTenMyZSt4MzRVWGg0RWg1QW0zazgyTEc1ZE1GZHdv?= =?utf-8?B?K2w1N1lmK0RvZUZjNTNNQkhyRTMxbzlzd2pqZHp2eFIxQmxRbU5iQW8xTFg5?= =?utf-8?B?VDRlNEtuV2dWZ0MxRmN5ZDEwU0MxMUlLdGpxRGNlNjhLN2xGd1RaWmkvVzVa?= =?utf-8?B?MFpXWjBBMjF3N3NBZXhISVhIeHA2Y3d0V2pOWUY0T0N0Si8xQVlNRzhHWm5C?= =?utf-8?B?NE0vR0pPVHY3UnR6enhuRlJwTmhtUUxFTDVnMVZnQ24zdVlqY0FWV1pHMnMx?= =?utf-8?B?YVFxMVIrUmJxYTJNYmN3a25oRDk2eE1FOENNb3V4RXRkVjVwM2hjcFNpQTBP?= =?utf-8?B?T2FmZDhTZEt1WXpTQ3RRMUpkenB4MFluUlAvY1VGQmZVWERqaVc0cUNvL1Jy?= =?utf-8?B?VGFlKzFKVTZBc2paUGhmZzFLUGk0bnUvNmsrRFFlZjNhdzdpVjdhSEovV0Mx?= =?utf-8?B?SXVSZklXeFV6ODBncFVFcHlVelR0M0hYMW0vUXFBUmxXUEx2cnJQUUk5WlQ2?= =?utf-8?B?TkpYZGZ1K1NYKy80cWkwRFE4YzNKWFlnK3M5ZGNPOXVTakcvVEZzaE5ma2xz?= =?utf-8?Q?se0vf0gAHZTT5F7Y=3D?= X-Exchange-RoutingPolicyChecked: lNR+MZjhSRORVU0p+BYli0CLJ+GwCkq6/wQmrJ7A0vzdZoqbiuP5NnvJ4mnJbB/iFosvGwUDpDkWVG8s4n5fzUNk7kBGkTpLA/Tn5L1tu1kWNsgbMavOCtl4SfYyqa4MCD9Q0Nk6py1uIDbligogfZpF9hGjhaSk5AumFDpVDk8yvX9iOlBo3t4RCR+PdLX2Dt45uF+BMpV0YlMpG80TgE1lUuGTqzJBHto2RjMeQjuT616Oh04NTfUQOZ1yP2KNrTAHP/BwZWTDn22bbUgwdGpQLstVPzVByXVRygjWhuwBsUXkKKwlCbfF19Nz8o26sqC61q94L1AHZ6lal3IzFw== X-MS-Exchange-CrossTenant-Network-Message-Id: f0aba412-213b-4f44-3ad6-08ded2d21130 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2026 15:54:40.8593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tS5xJdd6T0nKU+QC7idEzlNFPtNPsHIW+KeRM7UR60DxmRFI7SawTYnXz5fceIKLiVqVgYhWUFjAWJnodyvWOPl11h5LcY84DcV1SlhSuog= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5157 X-OriginatorOrg: intel.com Hi Chenyu, On 6/25/26 7:33 AM, Chen, Yu C wrote: > On 6/25/2026 7:44 AM, Reinette Chatre wrote: >> On 6/23/26 9:05 PM, Chen, Yu C wrote: ... >> Considering that this now establishes 1:1 between RMDD and resctrl domain and that >> resctrl already maintains a list of domains, could the x86 arch specific monitoring >> domain (struct rdt_hw_l3_mon_domain) perhaps just point to the ERDT monitoring data >> for that domain instead of maintaining a separate array of domains? So, when x86 is >> requested to read monitoring data for a domain there would be no need to query an >> array for the ERDT domain info since the containing structure already has a pointer >> to it. >> >> This may need more care to organize the ERDT per-domain monitoring data structure when >> considering the references to upcoming additions that are not clear to me at this time. >> > > I see. We could add a void *priv pointer to struct rdt_hw_l3_mon_domain. This is architecture specific code and I do not see a need to hide what the data represents behind a void pointer. struct rdt_hw_l3_mon_domain could have pointer of accurate type. For reference you can compare with struct rdt_hw_resource and all its AMD architecture specific members. > During l3_mon_domain_setup(), we can assign this pointer to the corresponding > erdt_domain_info object from the previously created list. > Since each rdt_hw_l3_mon_domain instance is freed when the last CPU in its domain > goes offline, we need to keep the global list of struct erdt_domain_info objects Sounds good. > persistent at all times. Going forward, we may also need to add the same pointer > assignment to rdt_hw_ctrl_domain for the upcoming region-aware MBA changes. > >>> >>> 3. erdt_mon_read() looks up erdt_domain_xa by hdr->id (L3 cache ID) as before, >>>     but the xarray is now populated lazily at CPU online time. >> >> I do not see the need for an xarray. As new domains are created during CPU online their >> initialization can just point to the needed data, no? >> > > If we add the struct erdt_domain_info pointer to rdt_hw_l3_mon_domain, then > there is no need to maintain the xarray. ack. Thank you. Reinette