From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685AbdBPIy6 (ORCPT ); Thu, 16 Feb 2017 03:54:58 -0500 Received: from mail.kapsi.fi ([217.30.184.167]:33731 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752527AbdBPIy5 (ORCPT ); Thu, 16 Feb 2017 03:54:57 -0500 Subject: Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support To: Stefan Bruens References: <20170215015122.4647-1-stefan.bruens@rwth-aachen.de> <884178a1fe9a4178a480b592e71820f7@rwthex-w2-b.rwth-ad.de> <599879d5-7925-6013-f8bb-a42df69e3f30@iki.fi> <8751632.4KFmXH3LkI@pebbles.site> <557ce694-5edd-169a-7062-da249137f2ed@iki.fi> Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab From: Antti Palosaari Message-ID: <2e741734-86d8-85df-b4f5-e47d99c6d0af@iki.fi> Date: Thu, 16 Feb 2017 10:54:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <557ce694-5edd-169a-7062-da249137f2ed@iki.fi> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 82.128.188.78 X-SA-Exim-Mail-From: crope@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2017 10:48 AM, Antti Palosaari wrote: > On 02/16/2017 01:31 AM, Stefan Bruens wrote: >>>> + /* attach demod */ >>>> + memset(&si2168_config, 0, sizeof(si2168_config)); >>> >>> prefer sizeof dst >> >> You mean sizeof(struct si2168_config) ? > > yeah. See chapter 14 from kernel coding style documentation, it handles > issue slightly. argh, I looked wrong! It is *correct*, do not change it. It is just as it should. Sorry about noise. regards Antti -- http://palosaari.fi/