From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935718AbdAKBuz (ORCPT ); Tue, 10 Jan 2017 20:50:55 -0500 Received: from mga05.intel.com ([192.55.52.43]:12017 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935677AbdAKBuy (ORCPT ); Tue, 10 Jan 2017 20:50:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="47644248" Subject: Re: [PATCH] scsi: remove useless acpi functions in the head file To: Hanjun Guo References: <1484036044-9514-1-git-send-email-guohanjun@huawei.com> Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, John Garry , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Hanjun Guo From: Aaron Lu Message-ID: <2e748ead-9118-9a00-d9e7-711fc2cd85c3@intel.com> Date: Wed, 11 Jan 2017 09:50:51 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/2017 07:44 PM, John Garry wrote: > On 10/01/2017 08:14, Hanjun Guo wrote: >> From: Hanjun Guo >> >> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support") >> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(), >> but forgot to remove them in the head file, do it now. >> >> Signed-off-by: Hanjun Guo Reviewed-by: Aaron Lu Just out of curiosity, did you find this by some tool? If so, can you please let me know the tool name so that I can avoid such problems in the future? Thanks. -Aaron >> --- >> include/scsi/scsi.h | 10 ---------- >> 1 file changed, 10 deletions(-) >> >> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h >> index 8ec7c30..a1e1930 100644 >> --- a/include/scsi/scsi.h >> +++ b/include/scsi/scsi.h >> @@ -29,16 +29,6 @@ enum scsi_timeouts { >> */ >> #define SCAN_WILD_CARD ~0 >> >> -#ifdef CONFIG_ACPI >> -struct acpi_bus_type; >> - >> -extern int >> -scsi_register_acpi_bus_type(struct acpi_bus_type *bus); >> - >> -extern void >> -scsi_unregister_acpi_bus_type(struct acpi_bus_type *bus); >> -#endif >> - >> /** scsi_status_is_good - check the status return. >> * >> * @status: the status passed up from the driver (including host and >> > > Looks ok, > > Reviewed-by: John Garry >