From: Stephen Boyd <sboyd@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: Reorder fields in 'struct clk_fractional_divider'
Date: Wed, 29 Mar 2023 11:46:36 -0700 [thread overview]
Message-ID: <2e74c4c93f4bcc6a7af0c3ef5a8edd23.sboyd@kernel.org> (raw)
In-Reply-To: <d1874eb8848d5f97f87337011188640a1463a666.1676649335.git.christophe.jaillet@wanadoo.fr>
Quoting Christophe JAILLET (2023-02-17 07:55:55)
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index cf1adfeaf257..8cec844f5dde 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -1134,13 +1134,13 @@ struct clk_hw *clk_hw_register_fixed_factor_parent_hw(struct device *dev,
> struct clk_fractional_divider {
> struct clk_hw hw;
> void __iomem *reg;
> + u8 flags;
> u8 mshift;
> u8 mwidth;
> u32 mmask;
This member ...
> u8 nshift;
> u8 nwidth;
> u32 nmask;
and this member can be calculated. Doing that would save more bytes when
combined with this patch. Can you make this into a patch series?
> - u8 flags;
> void (*approximation)(struct clk_hw *hw,
> unsigned long rate, unsigned long *parent_rate,
> unsigned long *m, unsigned long *n);
next prev parent reply other threads:[~2023-03-29 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 15:55 Christophe JAILLET
2023-03-29 18:46 ` Stephen Boyd [this message]
2023-04-02 8:22 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e74c4c93f4bcc6a7af0c3ef5a8edd23.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®