From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756540AbcE1Ayl (ORCPT ); Fri, 27 May 2016 20:54:41 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:33987 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbcE1Ayl (ORCPT ); Fri, 27 May 2016 20:54:41 -0400 Subject: Re: [PATCH] f2fs: fix to redirty page if fail to gc data page To: Chao Yu , References: <1463807951-10472-1-git-send-email-chao@kernel.org> CC: , From: Chao Yu Message-ID: <2e7be62f-62b3-bb9a-8831-8208d1d9eeb9@huawei.com> Date: Sat, 28 May 2016 08:54:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1463807951-10472-1-git-send-email-chao@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090206.5748EC43.005C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 7552e87dd03fc4d587dc221b3a28f532 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping, On 2016/5/21 13:19, Chao Yu wrote: > From: Chao Yu > > If we fail to move data page during foreground GC, we should give another > chance to writeback that page which was set dirty previously by writer. > > Signed-off-by: Chao Yu > --- > fs/f2fs/gc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 38d56f6..ee213a8 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -653,12 +653,15 @@ static void move_data_page(struct inode *inode, block_t bidx, int gc_type) > .page = page, > .encrypted_page = NULL, > }; > + bool is_dirty = PageDirty(page); > + > set_page_dirty(page); > f2fs_wait_on_page_writeback(page, DATA, true); > if (clear_page_dirty_for_io(page)) > inode_dec_dirty_pages(inode); > set_cold_data(page); > - do_write_data_page(&fio); > + if (do_write_data_page(&fio) && is_dirty) > + set_page_dirty(page); > clear_cold_data(page); > } > out: >