From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2159F352C2B for ; Wed, 13 May 2026 18:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778697235; cv=none; b=AG47Ph8xwg6TonikINcvA/7eAfbXzqlamRUZZQR45uYhimRlMFyi+jKkGSQYrzcVagLcyOxRL5WGEAeW0MpjPoav7xv8ga1/AS6cYnWnKHYI/LCXfsY6MTmRVc2ERXa6HlIBtlr2NnFuD+UIKZqE/jfq/fQ1Wk3HRkYejVXXxhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778697235; c=relaxed/simple; bh=0f1ZEKDDaOgMChfr+mLQhigNHbVnKxBChEzB3s/XUgg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h6yJL5mak/C5+Xj3tCp+zw46eu4SubEukZ7BPOGR6bGA/fKI+7Nw7KLlWu9oEAEZrYJhCKfEH+5QfKUeU928q+552WrauAZIvXikrC41r/ipg4AkUvHKWxaJ/UO/f+ZS3wfQQGuq12GBolXKtGLmIubHznfZnrI8fEtYI7Vjj6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WZJUlFE3; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WZJUlFE3" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43d7645adbdso3919337f8f.1 for ; Wed, 13 May 2026 11:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778697232; x=1779302032; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fiTNYVNzm2EWJXlIasqEdyA9slSNwJ07VhnNecnrUKs=; b=WZJUlFE3wj2rhBn/uV3vLM9yJO1b24iYljkLbOrKw2qbcpIWP0pxFR3ZxvpGyikWr7 hMX3lo4u07cfTuElj3r6Eu1EhwXJ3Z5rNv2CJCLzylnc/M9bhqMnO7EZ8RRDDzE2fsdI XPoFTGvAtDqEmSDFWW440itRIPxzFXC5b0uIMaWaDbFfIJmdO1Oc+aoQHbXN+qvZ+/WK L8ZJs0MBwYnNtBm+ksu23E3DHveSQlWhaMUV4MnOR/wm7Pf4KqaB6nevgUWbiwPLf8cw EbMuOaBw1a9tmH5wzal0Vau9kO+MqXV0/L4ErLAw006JMk4pswt4aJfBtaHTzIOMlfYS 91tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778697232; x=1779302032; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fiTNYVNzm2EWJXlIasqEdyA9slSNwJ07VhnNecnrUKs=; b=UA8eUcIsJj5R0hxUcZFOOehPeMKgaHH7n9LnCSyUa+6vEoA5vIcf7whqpp5+TpGBAL 1wcPXfySwXRF7ElCVtVZ+KryYM6VZeZ5vuiqHY5MdH3sT0raFXLr4A9l73rl1xj74daY tUXGD9Z4y8Mllod01NmdcbQ7XXTZ7XZzMQEF62knOkiWKCBIItA92awLFOo58E1njJuv bhYy4Z8HgTo9sXHk9IMQop9dTyRt2yRVNWS+Yq1wo5MJJFaRZHxtpjCyHMjBo22fRfSS tQgsIjDMcGjYns1fNM4Ko9MVco3Sl/iDIrVu20PSm98gxic63f1JlyxP30ymy7KWI28s xIhA== X-Forwarded-Encrypted: i=1; AFNElJ/VewOUM8Q53MEKsbGs0jyPzgRI5lbyHdmvCPl5/jnjA+3iSQhiGVRYhfp3bz3riWNHx2HREMfW8z7W73s=@vger.kernel.org X-Gm-Message-State: AOJu0YzLteXVrlMEczpk8A8JeCMljoYvM7BBoJCzmQ4e5u4hZbunhWd8 RKKmzLEidqrQwdyCLMkOLsI8FgZr5POkCn1BAhi5NYG50Akk0q9Qs0nf X-Gm-Gg: Acq92OFuPzGBHnJBCBBCz+83FHq4f8FnOISJcfsuoTsdsefgS1jt/16u9JMuBMBES91 qmPr4OxQ4bH5DMNvs3KuOJKCy9HFsBqVqfWT0nePb2i8xMTmfgVAUAVo+wleuMg4EQx85pwmqgM vdmtzdiv28H2vyc1qBPeXhJQDwQsOAy72QNAOaR4KtcfD4sU0ts8V4sz7C8BM78jYAWnnUJzWi8 B0AOS9IwXUZRg+OTXb5RdsmH1JrA83GwHYqX8ulytf0tFKRxWIdZW55dnGbQzcjAREZ/9WAOonw ECtsBFOMhk5csJ/Uzuxj9iDtmR3ReMCyUFnFb3e+VcDpe9dJmVSy3VfX0RNBcI5hhFUnWfAxPv9 4anA05vYw4AiyqYcMYJT50Fyq0F2wIjN1ayblwczxOaxByylgrxU6zpmgT9zbG4bUIkwnLpzhlM D04j9HWThil3wkJwFwWPDQ/4XWGpLrsHtVhgxqwG+G01iIWc3xBrFKDvs86Q== X-Received: by 2002:a05:600c:3f0f:b0:48e:60a3:220a with SMTP id 5b1f17b1804b1-48fc99a1af8mr65251675e9.0.1778697232515; Wed, 13 May 2026 11:33:52 -0700 (PDT) Received: from [10.247.142.6] ([129.234.0.190]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fd769141fsm772355e9.32.2026.05.13.11.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 11:33:52 -0700 (PDT) Message-ID: <2e80f456-a208-4cf7-9ab8-739a8314b275@gmail.com> Date: Wed, 13 May 2026 19:33:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c To: laurentiu.palcu@oss.nxp.com, l.stach@pengutronix.de, maarten.lankhorst@linux.intel.com, Maxime Ripard , Thomas Zimmermann , airlied@gmail.com, alexander.deucher@amd.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com References: <20260406180013.2442096-1-yiconghui@gmail.com> From: Yicong Hui Content-Language: en-US In-Reply-To: <20260406180013.2442096-1-yiconghui@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/04/2026 7:00 pm, Yicong Hui wrote: > Fix the following W=1 kerneldoc warnings by adding the missing parameter > descriptions for @phase0_identity and @nn_interpolation in > dcss_scaler_filter_design() and @phase0_identity in > dcss_scaler_gaussian_filter() > > Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter' > Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design' > Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design' > > Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ") > Signed-off-by: Yicong Hui > --- > drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c > index 32c3f46b21da..5c7f8d952ec1 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c > @@ -166,6 +166,7 @@ static int exp_approx_q(int x) > * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter. > * @fc_q: fixed-point cutoff frequency normalized to range [0, 1] > * @use_5_taps: indicates whether to use 5 taps or 7 taps > + * @phase0_identity: whether to override phase 0 coefficients with identity filter > * @coef: output filter coefficients > */ > static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps, > @@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps, > * @src_length: length of input > * @dst_length: length of output > * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps > + * @phase0_identity: whether to override phase 0 coefficients with identity filter > * @coef: output coefficients > + * @nn_interpolation: whether to use nearest neighbor instead of gaussian filter > */ > static void dcss_scaler_filter_design(int src_length, int dst_length, > bool use_5_taps, bool phase0_identity, Hello! Is there any further feedback or progress on this patch? Thank you! Yicong