mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: sumesh.k.naduvalath@intel.com, hdegoede@redhat.com,
	mgross@linux.intel.com, srinivas.pandruvada@linux.intel.com
Cc: srinivas.pandruvada@intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, ganapathi.chinnu@intel.com,
	nachiketa.kumar@intel.com
Subject: Re: [PATCH v3 1/1] ishtp: Add support for Intel ishtp eclite driver
Date: Wed, 1 Sep 2021 12:31:54 -0700	[thread overview]
Message-ID: <2e82bbb6-59c1-e713-f153-57ddd1e68163@infradead.org> (raw)
In-Reply-To: <20210901124307.16886-1-sumesh.k.naduvalath@intel.com>

On 9/1/21 5:43 AM, sumesh.k.naduvalath@intel.com wrote:
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index d12db6c316ea..8a0945ed1182 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1176,6 +1176,22 @@ config INTEL_CHTDC_TI_PWRBTN
>   	  To compile this driver as a module, choose M here: the module
>   	  will be called intel_chtdc_ti_pwrbtn.
>   
> +config INTEL_ISHTP_ECLITE
> +	tristate "Intel ISHTP eclite controller"
> +	depends on INTEL_ISH_HID
> +	depends on ACPI
> +	help
> +	  This driver is for accessing the PSE (Programmable Service Engine),
> +	  an Embedded Controller like IP, using ISHTP (Integrated Sensor Hub

Which "IP" is that?  "an Embedded Controller like IP" doesn't make sense IMO.


> +	  Transport Protocol) to get battery, thermal and UCSI (USB Type-C
> +          Connector System Software Interface) related data from the platform.

Indent above line with tab + 2 spaces instead of many spaces.

> +	  Users who don't want to use discrete Embedded Controller on Intel's
> +	  Elkhartlake platform, can leverage this integrated solution of

	Drop this comma       ^

> +	  ECLite which is part of PSE subsystem.
> +
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called intel_ishtp_eclite

End the last sentence with a period ('.').


thanks.
-- 
~Randy


  reply	other threads:[~2021-09-01 19:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 12:43 sumesh.k.naduvalath
2021-09-01 19:31 ` Randy Dunlap [this message]
2021-09-02 12:07   ` K Naduvalath, Sumesh
2021-09-09  7:15     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e82bbb6-59c1-e713-f153-57ddd1e68163@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=ganapathi.chinnu@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=nachiketa.kumar@intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=srinivas.pandruvada@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=sumesh.k.naduvalath@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®