From: Breno Leitao <leitao@debian.org>
To: Christoph Hellwig <hch@lst.de>
Cc: leit@meta.com, axboe@kernel.dk, tj@kernel.org,
josef@toxicpanda.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, aherrmann@suse.de, mkoutny@suse.com,
linux-kernel@vger.kernel.org, leit@fb.com
Subject: Re: [PATCH v2] blk-iocost: Pass disk queue to ioc_refresh_params
Date: Mon, 27 Feb 2023 14:52:15 +0000 [thread overview]
Message-ID: <2e8c8937-b027-8b20-a16b-3dfed8217ad2@debian.org> (raw)
In-Reply-To: <20230227140847.GA18644@lst.de>
Hello Christoph,
On 27/02/2023 14:08, Christoph Hellwig wrote:
> Hi Breno,
>
> and sorry for the late reply. This looks correct to me, but I'd
> be much happier if the disk was passed in instead of the request_queue
> as that's where we're generally heading. If you don't have time to
> respin I could live with this version for a fix, though.
No worries, I can definitely do a respin passing the disk instead of
request_queue.
I hope to send a v3 in the next few hours.
prev parent reply other threads:[~2023-02-27 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 13:56 Breno Leitao
2023-02-27 14:08 ` Christoph Hellwig
2023-02-27 14:52 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e8c8937-b027-8b20-a16b-3dfed8217ad2@debian.org \
--to=leitao@debian.org \
--cc=aherrmann@suse.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=leit@fb.com \
--cc=leit@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®