From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E10C433E0 for ; Sun, 14 Jun 2020 08:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CE02206D7 for ; Sun, 14 Jun 2020 08:50:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="UDLnelPf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbgFNIuZ (ORCPT ); Sun, 14 Jun 2020 04:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbgFNIuZ (ORCPT ); Sun, 14 Jun 2020 04:50:25 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA79AC03E96F for ; Sun, 14 Jun 2020 01:50:24 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id a26so3315496lfj.13 for ; Sun, 14 Jun 2020 01:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zRg9XKIL4vBu4icocKftZKBDvYCe4QXeJ3tHeratzYk=; b=UDLnelPfwlf525l+MyBjVDfxPBd2Oe89tkH5Gi/pAQNqFNVnQuBubyBZijjlGBtnJR VF2YE93Btypk75ygsyas50iz61OirOjcoNmrpTPjnZ0MVJtzkTrxaUBpjkP0jDxfIP0f FfvFr1xZlC1NaIID0JMIoVcAEkUQs0ECam5XakY7UIgiQR9mzYtyFJai1wAXympJNwy7 G3ca8HzdwHUjS4hXr5ni2T6RNvqznH5tFxR6UhC6b4Lqi/oFnt2MKeSGhAH4j4IVFSGi gx+hLFnie7/jlzvJJiG+AaC2+6PDctR7ay0roquujQ8wAsevGKxHtwoc0cAl43JLHEvf ZAEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zRg9XKIL4vBu4icocKftZKBDvYCe4QXeJ3tHeratzYk=; b=TkxhecGziUX/rhSCz0DqdluzfWl+HeHBmbCArK5/Pmb55IQBDtEnJeqvrJc5iolsJx bfQSdhxZvkmwU6tzpcwjMbDhD3LD+PgJCrR9EGvp01iw1/wjgT2TjmL0B/NrHYAiuXWu pPkz2dtfph/PEwHUoYqbMZTttFPJydIhbg7tqEK1crGiibHPZB68XWVBRbPbDZ2B04cb IDpEiJTFQHlVaB9cMdACVLwDaCcP38v+TTFe4CEhMMWNxw6KrsttRVor7b89L0sSoNK3 Apb86XKqyAfPkEWqgkaKTiPxUsYkTndwylXHUmlZARKxuBADcX/ifoe6oRKJU0udYTlI j5Hg== X-Gm-Message-State: AOAM533aiK8bqqxprqjD8eHQL6dzONgP77OLluaBT+4YLtfRMEHtR2xD ADYgzwYVEG5FWmUwbYLIMZgfxmhoo7C7uA== X-Google-Smtp-Source: ABdhPJy5o7xwjtDRjce0A+7PCgU9ZEZGrjzSHYQmSs2+SswKlfCozNnp/FVZLU2hmh8PR0XP4hmSfA== X-Received: by 2002:a05:6512:3089:: with SMTP id z9mr601823lfd.83.1592124623089; Sun, 14 Jun 2020 01:50:23 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:42e0:5405:a560:8954:33ef:54e2? ([2a00:1fa0:42e0:5405:a560:8954:33ef:54e2]) by smtp.gmail.com with ESMTPSA id n21sm3166415ljj.97.2020.06.14.01.50.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jun 2020 01:50:22 -0700 (PDT) Subject: Re: [PATCH] usb: dwc3: pci: Fix reference count leak in dwc3_pci_resume_work To: Aditya Pakki Cc: kjlu@umn.edu, wu000273@umn.edu, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200614031525.128556-1-pakki001@umn.edu> From: Sergei Shtylyov Message-ID: <2e8e923c-3f3d-29ff-6abf-ae333b81bd45@cogentembedded.com> Date: Sun, 14 Jun 2020 11:50:18 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200614031525.128556-1-pakki001@umn.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 14.06.2020 6:15, Aditya Pakki wrote: > dwc3_pci_resume_work() calls pm_runtime_get_sync() that increments > the reference counter. In case of failure, decrement the reference > count and return the error. In this case you still return nothing. > > Signed-off-by: Aditya Pakki > --- > drivers/usb/dwc3/dwc3-pci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > index b67372737dc9..96c05b121fac 100644 > --- a/drivers/usb/dwc3/dwc3-pci.c > +++ b/drivers/usb/dwc3/dwc3-pci.c > @@ -206,8 +206,10 @@ static void dwc3_pci_resume_work(struct work_struct *work) > int ret; > > ret = pm_runtime_get_sync(&dwc3->dev); > - if (ret) > + if (ret) { > + pm_runtime_put_sync_autosuspend(&dwc3->dev); > return; > + } > > pm_runtime_mark_last_busy(&dwc3->dev); > pm_runtime_put_sync_autosuspend(&dwc3->dev); MBR, Sergei