From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1137033343A for ; Mon, 1 Dec 2025 16:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764606931; cv=none; b=mM8LtFvO/6Q6kieoOo8bFdNeyDyXm0vmQPe9n008B2sRlhRUuNrVNvuJZnuR8ur/AKosV0XxAybQrIwbApmMND2OaDBj8yac01+ApN8y5Dho0H7oHemxT+B9wvoTb8/I6GiEy9RXpAf6SPN9WpGKCB96Ix1m8sPnk2LJY6lX3fE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764606931; c=relaxed/simple; bh=ualFSGhxOXnCUkEQ/rzm1kpIoLxJiw3EnDXjRikh9RQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RYJkeibD5DVC0p+Yn7HCIkm/oGwaIs89TU5FotZ20MH34+Q0vIZPvtgZRylWxexLrhtUyMLQFkOjKwvpk2YgtglnGPotK56BSAqAv4Fh+e+jNZwA5xFegYonn5T3NGcw1FuvWnOdO6/bD8T3ek8WirPu5WYbyHxKwdH5jcnM6Wg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E6AA153B; Mon, 1 Dec 2025 08:35:20 -0800 (PST) Received: from [10.57.76.143] (unknown [10.57.76.143]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 910133F73B; Mon, 1 Dec 2025 08:35:25 -0800 (PST) Message-ID: <2e8ece6c-954d-4b81-b860-4944789e22dd@arm.com> Date: Mon, 1 Dec 2025 16:35:23 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/panthor: Enable timestamp propagation To: Ashley Smith , Boris Brezillon , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251127115019.2113040-1-ashley.smith@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20251127115019.2113040-1-ashley.smith@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/11/2025 11:44, Ashley Smith wrote: > Set the GLB_COUNTER_EN bit to enable coherent propagation of GPU > timestamp values to shader cores. This is a prerequisite for exposing > device-coherent timestamp queries. > > Bump the version to 1.6 so userspace can detect support. > > v2: > - GLB_COUNTER_EN is not a toggle bit move to panthor_fw_update_reqs > > Signed-off-by: Ashley Smith Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_drv.c | 3 ++- > drivers/gpu/drm/panthor/panthor_fw.c | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c > index d1d4c50da5bf..0b0ec3b978c6 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -1604,6 +1604,7 @@ static void panthor_debugfs_init(struct drm_minor *minor) > * - 1.3 - adds DRM_PANTHOR_GROUP_STATE_INNOCENT flag > * - 1.4 - adds DRM_IOCTL_PANTHOR_BO_SET_LABEL ioctl > * - 1.5 - adds DRM_PANTHOR_SET_USER_MMIO_OFFSET ioctl > + * - 1.6 - enables GLB_COUNTER_EN > */ > static const struct drm_driver panthor_drm_driver = { > .driver_features = DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ | > @@ -1617,7 +1618,7 @@ static const struct drm_driver panthor_drm_driver = { > .name = "panthor", > .desc = "Panthor DRM driver", > .major = 1, > - .minor = 5, > + .minor = 6, > > .gem_create_object = panthor_gem_create_object, > .gem_prime_import_sg_table = drm_gem_shmem_prime_import_sg_table, > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index 38d87ab92eda..a55731e95884 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -996,7 +996,9 @@ static void panthor_fw_init_global_iface(struct panthor_device *ptdev) > GLB_IDLE_EN | > GLB_IDLE; > > - panthor_fw_update_reqs(glb_iface, req, GLB_IDLE_EN, GLB_IDLE_EN); > + panthor_fw_update_reqs(glb_iface, req, > + GLB_IDLE_EN | GLB_COUNTER_EN, > + GLB_IDLE_EN | GLB_COUNTER_EN); > panthor_fw_toggle_reqs(glb_iface, req, ack, > GLB_CFG_ALLOC_EN | > GLB_CFG_POWEROFF_TIMER | > > base-commit: 92c49b3f4df8f9acfa95551ef38fc00c675319fd