From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B61FC433E1 for ; Fri, 10 Jul 2020 07:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69A28206A5 for ; Fri, 10 Jul 2020 07:48:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UIwwVZez" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbgGJHsl (ORCPT ); Fri, 10 Jul 2020 03:48:41 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:38679 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726925AbgGJHsk (ORCPT ); Fri, 10 Jul 2020 03:48:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594367318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w3lPi8IIyg6JHok2MkrSRXRUKV+20Z+zeyOlBbulHrA=; b=UIwwVZezTDq6vUmce3Y1ef+Ehzm4G3VyUPnegLqxtIOw4MahNujDj9DYBiQ22AT1KosoRF whFbgfxVdWntveU+CGH47c3k7ucYNEYnp0AWblCtvNadzsmUVivZCaOe7p63ePL4M9GI9d yyiK71vwBliW02CQo2kSbPhg2o6llng= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-lkYdQbLWMhqPcEG9dTVisg-1; Fri, 10 Jul 2020 03:48:36 -0400 X-MC-Unique: lkYdQbLWMhqPcEG9dTVisg-1 Received: by mail-wm1-f72.google.com with SMTP id y204so5704548wmd.2 for ; Fri, 10 Jul 2020 00:48:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w3lPi8IIyg6JHok2MkrSRXRUKV+20Z+zeyOlBbulHrA=; b=BFJ2PnE1XaOcYxT4HAFpOcPn0VFcB/aewPbht1UMme2FctC1SIFU5DS24SL9k0UKMv kYa1dOFBgGSzKYD0HXFB6Y3zQOLvIkQINIHscPFz2hoasA1dQwxQyOtLsibod0FGkUab cAKbSZPCcVCIWjbi4PcCFOWSR0zjdp5zwQPuFj5Ae3qbWTQO920dWFw8Xh3A65tAf80N Tc4Hq2+MuzNgZmUxJGrq59re1yyAs0C/vuLrd5dWfQnFuVHOebd8k3INq9QBA5wZvm+P 3YdO2mlpzVukh+pFp8MBSujtgo+D0s24Rd9vtN0Alvp6AkQGbSiyap0+JARdPqmUioaK EyhQ== X-Gm-Message-State: AOAM533Hbd7vw+muT3HyjnAGZzZCeRCp2QuPQl7q+Ia5kZyA0H/KBpfk 99OZEsH9BHFu5lcddK1G4nabKwOakFrIjdwSieXEUCKpso6qAWWpNwSUkdq1nFhzwKi6KwQXa8L cCTreZSS8rq4ljQAr9Z1Nof85 X-Received: by 2002:a7b:c952:: with SMTP id i18mr4118724wml.65.1594367315235; Fri, 10 Jul 2020 00:48:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoVcmgycalDG2NxxBpe/F1Ip5MhErG5G/6zxHhUH+uoCv6KdhugBz3NZfr470zRIHVmrw60A== X-Received: by 2002:a7b:c952:: with SMTP id i18mr4118689wml.65.1594367315031; Fri, 10 Jul 2020 00:48:35 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9541:9439:cb0f:89c? ([2001:b07:6468:f312:9541:9439:cb0f:89c]) by smtp.gmail.com with ESMTPSA id o9sm8786762wrs.1.2020.07.10.00.48.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 00:48:34 -0700 (PDT) Subject: Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters To: Christian Borntraeger , Tianjia Zhang , tsbogend@alpha.franken.de, paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, christoffer.dall@arm.com, peterx@redhat.com, thuth@redhat.com, chenhuacai@gmail.com Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200623131418.31473-1-tianjia.zhang@linux.alibaba.com> <20200623131418.31473-2-tianjia.zhang@linux.alibaba.com> From: Paolo Bonzini Message-ID: <2e986527-1585-e1b4-1251-ef36ac3bd233@redhat.com> Date: Fri, 10 Jul 2020 09:48:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/20 17:31, Christian Borntraeger wrote: > > I have trouble seeing value in this particular patch. We add LOCs > without providing any noticable benefit. All other patches in this series at > least reduce the amount of code. So I would defer this to Paolo if he prefers > to have this way across all architectures. Yes, it adds lines of code but they're just + struct kvm_run *kvm_run = vcpu->run; You could avoid the LoC increase by repeating vcpu->run over and over, but I think the code overall is clearer. Paolo