From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911Ab1CJKgT (ORCPT ); Thu, 10 Mar 2011 05:36:19 -0500 Received: from smarthost1.greenhost.nl ([195.190.28.78]:57563 "EHLO smarthost1.greenhost.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290Ab1CJKgS (ORCPT ); Thu, 10 Mar 2011 05:36:18 -0500 Message-ID: <2e9ca0040729649ed989a16a07bb2c49.squirrel@webmail.greenhost.nl> In-Reply-To: <8b77a7a0de898635c8b25e7612907deb.squirrel@www.ffwll.ch> References: <1298395549-4064-1-git-send-email-daniel.vetter@ffwll.ch> <25dfe766fbe767e249ef95d1fda0094c.squirrel@www.ffwll.ch> <0378a20bb9cfafee46c89461fa2dd4d6.squirrel@webmail.greenhost.nl> <8b77a7a0de898635c8b25e7612907deb.squirrel@www.ffwll.ch> Date: Thu, 10 Mar 2011 11:36:15 +0100 (CET) Subject: Re: [PATCH] drm/i915: fix corruptions on i8xx due to relaxed fencing From: "Indan Zupancic" To: "Daniel Vetter" Cc: "Daniel Vetter" , "Daniel Vetter" , "Chris Wilson" , dri-devel@lists.freedesktop.org, "LKML" User-Agent: SquirrelMail/1.4.17 MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: 0.1 X-Scan-Signature: 258bd43c1b7c380ff6f1b27dffaa1ebc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, March 10, 2011 08:52, Daniel Vetter wrote: > Am Do, 10.03.2011, 06:06 schrieb Indan Zupancic: >> This isn't in rc8, can someone make sure it gets into 2.6.38-rc9/2.6.38? > > The patch unfortunately broke gen4+ (more precisely: the unwritten abi > guarantee that userspace can tile buffers that don't have a complete last > tile row, as long as it promises not to touch it). Hence it got reverted. > It was just a enforcement check to prevent broken userspace from fooling > itself. The proper fix is to upgrade your userspace (libdrm + > xf86-video-intel). > > [Aside: This only happens if you have new enough userspace that supports > relaxed tiling. Old userspace and new kernels are _not_ broken.] Yes, I noticed it got reverted when digging into git log, but the commit message only said it broke gen4+, not how gen2 should be unbroken after the revert. Which versions fix this, just for reference? I got libdrm 2.4.23 and xf86-video-intel 2.14.0. (As a side note, do you have version checking on the kernel side? If so, you could return 0 for the relaxed fencing feature check if the driver is the wrong version.) To keep things manageable I either upgrade the kernel, or userspace, but never both at once. It seems that that doesn't work with graphics. Thanks, Indan