mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaroslav Kysela <perex@perex.cz>
To: Mario Limonciello <mario.limonciello@amd.com>,
	Mukunda Vijendar <Vijendar.Mukunda@amd.com>,
	Saba Kareem Syed <Syed.SabaKareem@amd.com>,
	linux-kernel@vger.kernel.org
Cc: Pananchikkal Renjith <Renjith.Pananchikkal@amd.com>,
	Mark Pearson <mpearson@lenovo.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/6] ASoC: amd: yc: Add a module parameter to influence pdm_gain
Date: Fri, 27 Jan 2023 17:23:12 +0100	[thread overview]
Message-ID: <2e9f4301-0211-04f5-5b38-caf2be9f4fd1@perex.cz> (raw)
In-Reply-To: <20230127160134.2658-3-mario.limonciello@amd.com>

On 27. 01. 23 17:01, Mario Limonciello wrote:
> In case of regressions for any users that the new pdm_gain value is
> too high and for additional debugging, introduce a module parameter
> that would let them configure it.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   sound/soc/amd/yc/acp6x-pdm-dma.c | 7 ++++++-
>   sound/soc/amd/yc/acp6x.h         | 2 +-
>   2 files changed, 7 insertions(+), 2 deletions(-)

...

>   	pdm_ctrl = acp6x_readl(acp_base + ACP_WOV_MISC_CTRL);
> -	pdm_ctrl |= ACP_WOV_MISC_CTRL_MASK;
> +	pdm_ctrl |= FIELD_PREP(ACP_WOV_GAIN_CONTROL, pdm_gain);

The bits should be zeroed (AND - &) before OR to make sure that the correct 
value is written to the register. More related patches are affected.

>   	acp6x_writel(pdm_ctrl, acp_base + ACP_WOV_MISC_CTRL);

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


  reply	other threads:[~2023-01-27 16:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 16:01 [PATCH 0/6] Fix default DMIC gain on AMD PDM drivers Mario Limonciello
2023-01-27 16:01 ` [PATCH 1/6] ASoC: amd: yc: Adjust the gain for PDM DMIC Mario Limonciello
2023-01-27 16:53   ` Mark Brown
2023-01-27 17:02     ` Limonciello, Mario
2023-01-27 16:01 ` [PATCH 2/6] ASoC: amd: yc: Add a module parameter to influence pdm_gain Mario Limonciello
2023-01-27 16:23   ` Jaroslav Kysela [this message]
2023-01-27 16:25     ` Limonciello, Mario
2023-01-27 16:41       ` Jaroslav Kysela
2023-01-27 16:55         ` Mark Brown
2023-01-27 16:01 ` [PATCH 3/6] ASoC: amd: renoir: Adjust the gain for PDM DMIC Mario Limonciello
2023-01-27 16:01 ` [PATCH 4/6] ASoC: amd: renoir: Add a module parameter to influence pdm_gain Mario Limonciello
2023-01-27 16:01 ` [PATCH 5/6] ASoC: amd: ps: Adjust the gain for PDM DMIC Mario Limonciello
2023-01-27 16:01 ` [PATCH 6/6] ASoC: amd: ps: Add a module parameter to influence pdm_gain Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e9f4301-0211-04f5-5b38-caf2be9f4fd1@perex.cz \
    --to=perex@perex.cz \
    --cc=Renjith.Pananchikkal@amd.com \
    --cc=Syed.SabaKareem@amd.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mpearson@lenovo.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®