From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DFDAC48BD1 for ; Fri, 11 Jun 2021 15:54:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFCAB61004 for ; Fri, 11 Jun 2021 15:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbhFKP4D (ORCPT ); Fri, 11 Jun 2021 11:56:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24564 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229935AbhFKP4C (ORCPT ); Fri, 11 Jun 2021 11:56:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623426843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K/W9sou9gDRpHUzvlAgo/d0h0bEb4aG6pesxj4+DQaY=; b=P9VanDl3dI6xiCvnXoW2XldUnSIWxN6zY0Zju9erEDVGz1Mqs3DKcn/Qn+30jPSEcPXtd/ yrRD9AYhxpuGnVtj16R/qaeqYuLZGMi1JYrC738Etc1OMbYQBz7OaVNcxJB4DiwFtZl4L2 VSk6eVuZbIKk+I9RrzqHLfsfjLZWkVY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-548-lXZmDq4sN2qJluzxO1QBrA-1; Fri, 11 Jun 2021 11:54:02 -0400 X-MC-Unique: lXZmDq4sN2qJluzxO1QBrA-1 Received: by mail-wr1-f71.google.com with SMTP id s8-20020adff8080000b0290114e1eeb8c6so2811914wrp.23 for ; Fri, 11 Jun 2021 08:54:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K/W9sou9gDRpHUzvlAgo/d0h0bEb4aG6pesxj4+DQaY=; b=YrhqFXF2g7jO8h9AyEmMJTp/ggvaYEfH6pP7VXuXfZcCY+r2Tar/7Pz3rGcZcYRhrZ adzZQIuWThWx0QLbqidd+5NbGuyGo4S7Qc94BD+r158nM+vqesmCRFmFGWqPrRoOqR4R 5PeBl5zXroyMKc+ltRDj8468vUXmH1aZBMA1Zzg0pR0mD6ZW+Fr/DtuwvkfcPy2MDRxY BFY3D8zFk9JvFie0LsyzO+MoS1i+/Ohenmd/AQnfefsv0VsvaIDJpiwk7JhB+olvCalw pO+Sg9Y4gxXOF9rjBbh5epXMRmOTMeYjn5vuK+5yuB6ffEsIKmanR8Q3Z3NsKge4AIYe J0rA== X-Gm-Message-State: AOAM533rbFn2NdqtQX+1tMEG8a/JaOs21QfKtE1Yc9+/hFI65Qz7KdNL EZZH2j6ZCKHzNv20YrBKXb6ilrVl5eeJcpX7XDnwiO92qfW2tDXd0ZotQA0lVLS11Mo5QU5Ddcr 0KEGbrg10820JYFtAAOal+zyu X-Received: by 2002:a7b:c189:: with SMTP id y9mr4664407wmi.106.1623426840816; Fri, 11 Jun 2021 08:54:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZCst0fXPSfny8EGVNzM5i2LQfg5owSCBUWeIsLcOMd7YqAYkLzgvGWGmqL3W6popgFe4ebA== X-Received: by 2002:a7b:c189:: with SMTP id y9mr4664390wmi.106.1623426840602; Fri, 11 Jun 2021 08:54:00 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id b135sm13410912wmb.5.2021.06.11.08.53.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 08:53:59 -0700 (PDT) Subject: Re: [PATCH] KVM: X86: Fix x86_emulator slab cache leak To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , stable@vger.kernel.org References: <1623387573-5969-1-git-send-email-wanpengli@tencent.com> From: Paolo Bonzini Message-ID: <2ea05111-1598-f82c-e868-0615bc003612@redhat.com> Date: Fri, 11 Jun 2021 17:53:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1623387573-5969-1-git-send-email-wanpengli@tencent.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/21 06:59, Wanpeng Li wrote: > From: Wanpeng Li > > Commit c9b8b07cded58 (KVM: x86: Dynamically allocate per-vCPU emulation context) > tries to allocate per-vCPU emulation context dynamically, however, the > x86_emulator slab cache is still exiting after the kvm module is unload > as below after destroying the VM and unloading the kvm module. > > grep x86_emulator /proc/slabinfo > x86_emulator 36 36 2672 12 8 : tunables 0 0 0 : slabdata 3 3 0 > > This patch fixes this slab cache leak by destroying the x86_emulator slab cache > when the kvm module is unloaded. > > Fixes: c9b8b07cded58 (KVM: x86: Dynamically allocate per-vCPU emulation context) > Cc: stable@vger.kernel.org > Signed-off-by: Wanpeng Li > --- > arch/x86/kvm/x86.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 6d3955a6a763..fe26f33e8782 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8258,6 +8258,7 @@ void kvm_arch_exit(void) > kvm_x86_ops.hardware_enable = NULL; > kvm_mmu_module_exit(); > free_percpu(user_return_msrs); > + kmem_cache_destroy(x86_emulator_cache); > kmem_cache_destroy(x86_fpu_cache); > #ifdef CONFIG_KVM_XEN > static_key_deferred_flush(&kvm_xen_enabled); > Queued, thanks Paolo